Uh oh!
There was an error while loading. Please reload this page.
Debloat serialization guard - #89706
Merged
Merged
Conversation
Use `UnsafeAccessor` instead of a delegate. Shrinks the size of a `PublishAot` app that just `Process.Start`s a new process from 2.2 MB to 1.7 MB. It's still half a MB bigger than what I would expect but now it's `Process`'s fault (the `ToString()` brings some serious amount of garbage and we can't practically trim `ToString`). Fixesdotnet#87470.
ghost
commented
Jul 31, 2023
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue DetailsUse Shrinks the size of a Fixes #87470.
|
jkotas
commented
Jul 31, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
UnsafeAccessorinstead of a delegate.Shrinks the size of a
PublishAotapp that justProcess.Starts a new process from 2.2 MB to 1.7 MB. It's still half a MB bigger than what I would expect but now it'sProcess's fault (theToString()brings some serious amount of garbage and we can't practically trimToString).Fixes#87470.