Skip to content

Don't have getVectorTByteLength() return 0 for the time being - #89802

Merged
tannergooding merged 1 commit into
dotnet:mainfrom
tannergooding:workaround-87515
Aug 1, 2023
Merged

Don't have getVectorTByteLength() return 0 for the time being#89802
tannergooding merged 1 commit into
dotnet:mainfrom
tannergooding:workaround-87515

Conversation

@tannergooding

Copy link
Copy Markdown
Member

This resolves#87515, resolves#87511, resolves#87388

The proper fix for this is tracked by #87502, but for the time being we'll continue matching what we did in .NET Core 2.0 through .NET 7

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 1, 2023
@ghost

ghost commented Aug 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This resolves #87515, resolves #87511, resolves #87388

The proper fix for this is tracked by #87502, but for the time being we'll continue matching what we did in .NET Core 2.0 through .NET 7

Author:tannergooding
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@tannergooding

Copy link
Copy Markdown
MemberAuthor

CC. @dotnet/jit-contrib. Small fix for 3 of the DOTNET_EnableHWIntrinsic issues that were showing up for Arm64.

It just reverts us back to the behavior we had in .NET 7 (and prior releases) where we report the Vector size to be the 16-byte register even if HWIntrinsics are disabled.

Allowing it to report 0 will require more work and ensuring that any required ABI related handling remains correct in the face of that.

@tannergooding
tannergooding merged commit 4448e41 into dotnet:mainAug 1, 2023
@tannergooding
tannergooding deleted the workaround-87515 branch August 1, 2023 22:20
@ghostghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

3 participants

@tannergooding@BruceForstall@JulieLeeMSFT