Skip to content

Add test for TypeIdentifierAttribute - #89882

Merged
steveharter merged 3 commits into
dotnet:mainfrom
steveharter:AddTypeIdentifierTest
Aug 4, 2023
Merged

Add test for TypeIdentifierAttribute#89882
steveharter merged 3 commits into
dotnet:mainfrom
steveharter:AddTypeIdentifierTest

Conversation

@steveharter

Copy link
Copy Markdown
Contributor

@stevehartersteveharter added area-System.Reflection test-enhancement Improvements of test source code labels Aug 2, 2023
@stevehartersteveharter self-assigned this Aug 2, 2023
@ghost

ghost commented Aug 2, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds a test for #73103 which was previously fixed in 0a587ff#diff-ac44b8df606ec5a6fd2ec32bd3c61853f77cfb6ecef622b7ce1bfc5ed245edf4L796

Fixes #73103

Author:steveharter
Assignees:steveharter
Labels:

area-System.Reflection, test-enhancement

Milestone:-

@jkotas

Copy link
Copy Markdown
Member

TypeEquivalence is only supported in full CoreCLR. The test is going to fail in Mono and native AOT.

@jkotas

Copy link
Copy Markdown
Member

Maybe add a new property to PlatformDetection for type equivalence.

@steveharter
steveharter merged commit c2a0416 into dotnet:mainAug 4, 2023
@steveharter
steveharter deleted the AddTypeIdentifierTest branch August 4, 2023 14:28
@ghostghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Reflectiontest-enhancementImprovements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AF: System.RuntimeType.CheckValue trying to reflection invoke method with equivalent types

2 participants

@steveharter@jkotas