Put HasNativeCodeReJITAware into GetFunctionAddress by mikelle-rogers · Pull Request #90049 · dotnet/runtime

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

mikelle-rogers · 2023-08-04T21:22:29Z

Went through many branches of the call tree to understand which changes needed to be made to ensure safe behavior when updating GetFunctionAddress to return possibly arbitrary nativeCode.

mikelle-rogers · 2023-08-04T22:21:19Z

Fixes #89475.
There are a few more branches that need investigation, and some that have been investigated that still need fixing. I will open a new issue to specify those. I wanted to push the code I had so far to start getting feedback.

noahfalk · 2023-08-10T04:56:34Z

 if (startAddr == NULL)
 {
 startAddr = g_pEEInterface->GetFunctionAddress(fd);
+ if (startAddr == NULL)


Are there scenarios that are still calling into FindOrCreateInitAndAddJitInfo() with startAddr=NULL after the other changes we did? (I'm not pushing back or implying anything, just asking)
If there aren't any scenarios left then we should assert startAddr != NULL and remove the code that handles the NULL case.
If there are still scenarios where startAddr==NULL can we enumerate them in a comment? What I'd like to get recorded is whether we've explicitly determined that searching default + active code version only is the correct behavior, or we know it isn't fully correct but we are using it for expediency, or we don't know one way or the other.
If GetNativeCodeReJITAware() is just a heuristic that often works but isn't fully correct then we should comment it clearly so that other devs don't accidentally start using it and dig the hole any deeper than it already is.

No more scenarios after calling GetFunctionAddress, I put an Assert in the code and the test still passes.

noahfalk

LGTM modulo a last little bug on ARM commented inline

hoyosjs · 2023-08-12T01:44:55Z

 CodeVersionManager::LockHolder codeVersioningLockHolder;
-ILCodeVersion ilVersion = pCodeVersionManager->GetActiveILCodeVersion(PTR_MethodDesc(this));
-if (!ilVersion.IsDefaultVersion())
+ILCodeVersionCollection ilVersionCollection = pCodeVersionManager->GetILCodeVersions(PTR_MethodDesc(this));


Before you were getting the current IL version's address. Is there any guarantee of what order you get this in? Does it return in order of IL version and descend until a native body is found? For things like deoptimization, is that what we want?

There is no guarantee of order, however, the work has been done to look through everything that calls this code, and make adjustments to allow this behavior to be safe. GetNativeCodeAnyVersion is only used in HasNativeCodeAnyVersion, which is used in EnumMethodInstances::Next and CdStart. It is only used to see whether or not there is a native code body. The reason it was changed is with the addition of deoptimization, there is a possibility that the user asks the code to be deoptimized before it has a default and active version (before the method is jitted). Thus, the code could have a native code version even though it did not have an active nor default native code version. @davmason @noahfalk

…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

mikelle-rogers · 2023-09-26T20:31:09Z

/backport to release/8.0

github-actions · 2023-09-26T20:31:24Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6317993923

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Put HasNativeCodeReJITAware into GetFunctionAddress
0872883

mikelle-rogers requested review from davmason, hoyosjs, noahfalk and tommcdon August 4, 2023 21:22

mikelle-rogers self-assigned this Aug 4, 2023

ghost added the area-VM-coreclr label Aug 4, 2023

get rid of unused code
3fe7c02

noahfalk reviewed Aug 8, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/di/breakpoint.cpp
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/eedbginterfaceimpl.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated
Comment threadsrc/coreclr/debug/daccess/task.cpp Outdated

reverting GetFunctionAddress to previous behavior
8a9d0b1

mikelle-rogers requested a review from noahfalk August 9, 2023 18:31

noahfalk reviewed Aug 10, 2023
View reviewed changes

removing if statement
49697d0

build-analysisBot mentioned this pull request Aug 10, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

mikelle-rogers added 3 commits August 10, 2023 15:55

clarify method names
d69d33d

add comments
86e84bd

use BreakpointData.codeStartAddress
aaa2f7b

mikelle-rogers requested a review from noahfalk August 11, 2023 17:11

dac cast
31529d5

build-analysisBot mentioned this pull request Aug 11, 2023
Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests.ConfigurationBinderTests.GetCanReadStaticProperty failed #88843
Closed

mikelle-rogers mentioned this pull request Aug 11, 2023
Build Failure on MacOS ARM64 Rid issue with sqlite #90434
Closed

noahfalk approved these changes Aug 11, 2023
View reviewed changes

Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
Comment threadsrc/coreclr/vm/method.hpp Outdated

address code review
e4d8bfe

hoyosjs reviewed Aug 12, 2023
View reviewed changes

mikelle-rogers merged commit eacb32e into dotnet:mainAug 14, 2023

tommcdon mentioned this pull request Aug 14, 2023
HasNativeCodeReJitAware #89475
Closed

mikelle-rogers added a commit to mikelle-rogers/runtime that referenced this pull request Aug 16, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (dotnet#9…
bc0eda3
…0049)" This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

carlossanlop pushed a commit that referenced this pull request Aug 17, 2023
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (…
149a289
…#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.

radical mentioned this pull request Aug 28, 2023
[IGNORE][wasm] wasm symbols #91241
Closed

ghost locked as resolved and limited conversation to collaborators Sep 14, 2023

radical mentioned this pull request Sep 26, 2023
wasm symbols 8 #92626
Closed

github-actionsBot unlocked this conversation Sep 26, 2023

github-actionsBot locked as resolved and limited conversation to collaborators Sep 26, 2023

Uh oh!

Conversation

mikelle-rogers commented Aug 4, 2023

Uh oh!

mikelle-rogers commented Aug 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikelle-rogers commented Sep 26, 2023

Uh oh!

github-actionsBot commented Sep 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mikelle-rogers commented Aug 4, 2023

Uh oh!

mikelle-rogers commented Aug 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikelle-rogers commented Sep 26, 2023

Uh oh!

github-actionsBot commented Sep 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development