Use Microsoft.Net.Compilers.Toolset in coreclr/src/Common projects by ViktorHofer · Pull Request #901 · dotnet/runtime

ViktorHofer · 2019-12-16T14:39:56Z

Remove dependencies.props favor of Versions.props
Versions.props is the Arcade entry point to manage version which are
being used throughout the repository.
Use Arcade Sdk.targets in coreclr/src/Common
At the moment only Arcade Sdk.props are being imported in the common
managed projects. Changing that to make sure that the same compiler is
being used everywhere.
Consolidate managed properties to OSGroup, ArchGroup and ConfigurationGroup. With the ongoing work done by @Anipik which will allow multi-targeting by OS this will be cleaned-up further.
Packaging fixes to point to the right license and third party notices
A lot of cleanup

Versions.props is the Arcade entry point to manage version which are being used throughout the repository.

At the moment only Arcade Sdk.props are being imported in the common managed projects. Changing that to make sure that the same compiler is being used everywhere.

Restore and Build targets shouldn't run in the same msbuild invocation as that could cause issues with nuget auto-generated props/targets.

Intermediate paths are encoded wrong so that MSBuildProjectExtensionsPath which defaults to BaseIntermediateOutputPath is set wrong and the in-built msbuild Exists check fails. This is because of a mixture of different slashes.

The restore and build target invocations need to happen in separate msbuild task invocations and different global properties need to be passed in to mitigate issues with caching the invocations. For more context see dotnet/msbuild#2811.

stephentoub · 2020-02-13T02:35:30Z

@ViktorHofer, what's the state of this? Thanks.

stephentoub · 2020-02-20T15:33:33Z

@ViktorHofer, given this has been open for two months, hasn't been touched in a month, has a bunch of conflicts, and there's been no response in over a week about status, I'm going to close this. It can obviously be re-opened when you're ready to proceed with it. Thanks.

ViktorHofer · 2020-02-20T16:23:21Z

I've been working on this over the weekend but am still not in a state to push an update. Closing is fine, I'll reopen when this is ready again.

stephentoub · 2020-02-20T16:23:51Z

Thanks.

ViktorHofer added the area-Infrastructure-coreclr Only use for closed issues label Dec 16, 2019

ViktorHofer self-assigned this Dec 16, 2019

ViktorHofer force-pushed the CoreClrTestFixes branch from 1d8edc8 to 191da91Compare December 16, 2019 14:47

ViktorHofer changed the title ~~Core clr test fixes~~Use Microsoft.Net.Compilers.Toolset in coreclr/src/Common projectsDec 16, 2019

safern reviewed Dec 16, 2019
View reviewed changes

Comment threadsrc/coreclr/tests/src/Common/Directory.Build.props Outdated

ViktorHofer force-pushed the CoreClrTestFixes branch from 50acc07 to 750dee1Compare December 17, 2019 17:22

ViktorHofer added 11 commits January 14, 2020 12:39

Remove dependencies.props favor of Versions.props
12b164a
Versions.props is the Arcade entry point to manage version which are being used throughout the repository.

Use Arcade Sdk.targets in coreclr/src/Common
550cde8
At the moment only Arcade Sdk.props are being imported in the common managed projects. Changing that to make sure that the same compiler is being used everywhere.

Split restore and build targets in runtest.proj
22f4c79
Restore and Build targets shouldn't run in the same msbuild invocation as that could cause issues with nuget auto-generated props/targets.

Fix duplicate imports of liveBuild.targets
d8017e9

Fix intermediate paths for test projects
35475c3
Intermediate paths are encoded wrong so that MSBuildProjectExtensionsPath which defaults to BaseIntermediateOutputPath is set wrong and the in-built msbuild Exists check fails. This is because of a mixture of different slashes.

Various path fixes
9ead24c

MSBuild cleanup
fab6cf3

Update paths and common props
99d0310

Cleanup coreclr managed properties
b638594

Split restore and build to fix design time imports
699ca67
The restore and build target invocations need to happen in separate msbuild task invocations and different global properties need to be passed in to mitigate issues with caching the invocations. For more context see dotnet/msbuild#2811.

Further path fixes
35e8971

ViktorHofer force-pushed the CoreClrTestFixes branch 3 times, most recently from 1742717 to 2507255Compare January 14, 2020 14:07

Pre-Christmas changes
c8745d8

ViktorHofer force-pushed the CoreClrTestFixes branch from 2507255 to c8745d8Compare January 14, 2020 16:50