Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110

Merged
TIHan merged 9 commits into
dotnet:mainfrom
TIHan:il-rt-folder
Oct 6, 2023
Merged

Conversation

@TIHan

@TIHanTIHan commented Aug 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves#71119
Resolves#71316

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 7, 2023
@ghostghost assigned TIHanAug 7, 2023
@TIHan

TIHan commented Aug 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr ilasm

@azure-pipelines

azure-pipelinesBot commented Aug 7, 2023

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TIHanTIHan changed the title Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan changed the title Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan

TIHan commented Aug 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr ilasm

@azure-pipelines

azure-pipelinesBot commented Aug 7, 2023

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TIHan
TIHan marked this pull request as ready for review August 8, 2023 00:32
@TIHan

TIHan commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib @jakobbotsch this is ready.

@jakobbotsch

jakobbotsch commented Aug 8, 2023

Copy link
Copy Markdown
Member

I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results

@markples

markples commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.

Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.

cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run

@jakobbotsch

jakobbotsch commented Aug 8, 2023

Copy link
Copy Markdown
Member

I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.

The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.

@BruceForstall

BruceForstall commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.

It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare

A test that goes badly and trashes the test directory may be rare, but it's an important scenario.

@markples

markples commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...

I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).

[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.

@TIHan

TIHan commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.

For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.

Another question, is the behavior better than before with this change?

@markples

markples commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.

@TIHan

TIHan commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

I see, thought the test runs propagated to this PR. Will look into it.

@TIHan

TIHan commented Aug 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"

@markples

markples commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains

pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.

Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.

@TIHan

TIHan commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr ilasm

@azure-pipelines

azure-pipelinesBot commented Aug 9, 2023

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TIHan

TIHan commented Aug 9, 2023

Copy link
Copy Markdown
ContributorAuthor

@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results

@build-analysisbuild-analysisBot mentioned this pull request Aug 9, 2023
Closed
BruceForstall
BruceForstall reviewed Aug 9, 2023
View reviewed changes

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.

Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).

IMO, we should just push this work to .NET 9. Missing one test isn't terrible.

I'm more worried about:

Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.

@markples What test coverage are we missing? Is there a GitHub issue detailing it?

Comment threadeng/pipelines/coreclr/ilasm.yml Outdated
jobParameters:
testGroup: ilasm
liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file

@BruceForstallBruceForstall added area-ILTools-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 9, 2023
@ghost

ghost commented Aug 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #71119
Resolves #71316

Author:TIHan
Assignees:TIHan
Labels:

area-ILTools-coreclr, needs-area-label

Milestone:-

@markples

markples commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

@TIHan I guess there's a github-side configuration that I don't know about. Oh well.

@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.

@BruceForstall

BruceForstall commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.

So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.

@markples

markples commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

That's correct. Only RequiresProcessIsolation would be preserved right now.

@JulieLeeMSFTJulieLeeMSFT added this to the 9.0.0 milestone Sep 6, 2023
@BruceForstall

BruceForstall commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

@TIHan Can you mark this "Draft" until it's ready to review again?

@TIHan
TIHan marked this pull request as draft September 13, 2023 19:20
@TIHan

TIHan commented Oct 3, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr ilasm

@azure-pipelines

azure-pipelinesBot commented Oct 3, 2023

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@TIHan

TIHan commented Oct 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Only about 10 failures now.

@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Open
5 tasks
@TIHan
TIHan marked this pull request as ready for review October 5, 2023 15:56
@TIHan

TIHan commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results

The original assemblies get copied to IL-RT

@TIHan

TIHan commented Oct 5, 2023

Copy link
Copy Markdown
ContributorAuthor

// cc @dotnet/jit-contrib

@ghostghost mentioned this pull request Oct 5, 2023
Closed
BruceForstall
BruceForstall approved these changes Oct 5, 2023
View reviewed changes

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.

@TIHan

TIHan commented Oct 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results

@TIHan
TIHan merged commit 7f32a81 into dotnet:mainOct 6, 2023
@TIHanTIHan mentioned this pull request Oct 6, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name

5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Create IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtripping - #90110
Merged
TIHan merged 9 commits into
dotnet:mainfrom 
TIHan:il-rt-folder
Oct 6, 2023
Merged
Conversation
@TIHan
@TIHanTIHan
commented
Aug 7, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Resolves#71119
Resolves#71316
@ghostghost
added
the 
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 7, 2023
@ghostghost
assigned TIHanAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sourcesCreate IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHanTIHan
changed the title
Create IL-RT folder to store round-tripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingCreate IL-RT folder to store roundtripped IL assemblies and sources, removed suffix '.asm' to roundtripped files, re-enabled rejit ilasm roundtrippingAug 7, 2023
@TIHan
TIHan
commented
Aug 7, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 7, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
marked this pull request as ready for review
August 8, 2023 00:32
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib @jakobbotsch this is ready.
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I kicked off a runtime-coreclr ilasm run from AzDO manually: https://dev.azure.com/dnceng-public/public/_build/results?buildId=366414&view=results
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure. Perhaps some of that can be mitigated (as I think will be the case here) by executing the test with the test "root" as the working directory rather than the new subdirectory (for example, a test with an input text file in the current directory could still work). I'm not sure how a test finding library assemblies is going to work.
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this. Maybe running the tests with a roundtripped wrapper but not the tests themselves is enough to test this, but I'm not sure. However, the library assemblies comment above is especially important because basically all test code is going to be in library assemblies, and you'll need this IL-RT setup to find the roundtripped assemblies rather than the originals.
cc @jkoritzinsky who I believe suggested that ilasm roundtripping simply overwrite the originals. It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare and a developer can rebuild the test, and (2) not applicable in the lab where the test tree is discarded after a test run
@jakobbotsch
jakobbotsch
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
I am concerned that trying to use a subdirectory is going to introduce a different set of problems when the test has dependencies on the folder/file structure.
The way crossgen2 handles it is by moving the original assemblies into the IL-CG2 folder and then create the new ones in the current folder. I think ilasm roundtrip testing should follow the same model.
@BruceForstall
BruceForstall
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
IMO, any model where the existing tests are modified (overwritten, originals moved, etc.) is broken. That includes the current crossgen2 model. Running the tests in a particular mode should not alter the built artifacts. It should be trivial to get back to the "just built" situation. It should be trivial to rerun a test without worrying about it running on top of altered artifacts.
It trades simplicity of the ilasm testing scenario for the possibility of trashing the test directory if roundtripping goes badly, but that case is (1) rare
A test that goes badly and trashes the test directory may be rare, but it's an important scenario.
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
There's a fundamental problem that r2r and ilasm are build steps that exist outside of the build [1] and the logic for them is general and exists outside of the test execution. It shows up in various ways - how do they find dependent assemblies being another (r2r appears to do *.dll, which I guess is somehow resilient to non-assemblies, or maybe those tests are all disabled?). A risk of not actually doing the test is another (ilasm is in this state today after merged groups). Test-specific dependencies on assembly filenames and other test assets are another. Copying the entire test directory elsewhere (and modifying it there) could be another attempt, but one problem with that would be any absolute paths (to test assets would be ok maybe? do these exist? I don't know). Or maybe a more robust "save the test directory, do stuff, restore it", though I don't think this strategy could be perfect against ctrl-cs and stuff like that. I supposed some kind of virtualized file system could it...
I certainly don't like the idea of the test artifacts getting trashed, and it's easy for a "hey, if you're running r2r or ilasm, be aware that you might need to rebuild" rule being forgotten, leading to frustration. But I don't see any alternatives (or know who is going to do them).
[1] I assume that we don't want running build.cmd or msbuild directly on a test project to (somehow) create multiple copies of a test and do those steps. Or have a separate build mode for them (such that the "anycpu" shared build isn't sufficient anymore, etc.) Maybe there's some hybrid. These are probably conceptually some correct fixes.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I don't have a strong opinion here, and there seems to be some outstanding concerns in general regarding how we handle testing like this, including the existing CrossGen2 tests.
For the purposes of moving this PR forward, what do you all recommend? Should we delay this to .NET 9? It's not a critical component for .NET 8.
Another question, is the behavior better than before with this change?
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
The ilasm run failed - looks like the test in the subdirectory can't find dependent assemblies.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
I see, thought the test runs propagated to this PR. Will look into it.
@TIHan
TIHan
commented
Aug 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Will need to copy DLLs to the IL-RT folder like crossgen2, "cp *.dll IL-CG2/"
@markples
markples
commented
Aug 8, 2023

Copy link


Copy Markdown

Contributor
Since the test run was triggered manually, there was nothing to propagate any results back to here. ilasm.yml contains
pr:
branches:
include:
- main
paths:
include:
- src/coreclr/ilasm/*
- src/coreclr/ildasm/*

so my guess is that the PR containing ilasm/ildasm changes is what blocked your attempt. You don't want to change those paths to include src/tests because I suspect it would automatically run the pipeline too much for others. You might be able to temporarily change that include or temporarily make a little change in ilasm/ildasm (assuming that the PR contents are examined and not main itself...) to get the github integration to work (of course make sure to revert before merging, which will retrigger the runtime job...) or continue to manually execute it.
Note that your proposal is still different from r2r. r2r copies the originals out and modifies the originals (the point of contention), whereas I believe you are doing the modifications in the subdirectory. You could still hit issues with the subdirectory but could try it to see how it works.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Aug 9, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Aug 9, 2023

Copy link


Copy Markdown

ContributorAuthor
@markples I tried modifying ilasm.yml just by modifying whitespace, but it still wouldn't let me trigger it here. I manually triggered it though: https://dev.azure.com/dnceng-public/public/_build/results?buildId=367708&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 9, 2023

Closed

BruceForstall
BruceForstall
reviewed
Aug 9, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, as some expected, there are tests that depend on the directory structure.
Perhaps Jakob's suggestion of saving off the originals and modifying in place is the only solution, without some more drastic general solution (e.g., copying the entire directory structure to be a sibling directory?).
IMO, we should just push this work to .NET 9. Missing one test isn't terrible.
I'm more worried about:
Related - you probably need to address the ilasm test coverage issue with merged test groups before doing this.
@markples What test coverage are we missing? Is there a GitHub issue detailing it?
Comment threadeng/pipelines/coreclr/ilasm.yml
Outdated

 jobParameters:
 testGroup: ilasm
 liveLibrariesBuildConfig: Release

@BruceForstallBruceForstallAug 9, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the (empty) change to this file
@BruceForstallBruceForstall
added

area-ILTools-coreclr

and removed

needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 9, 2023
@ghost
ghost
commented
Aug 9, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT

See info in area-owners.md if you want to be subscribed.
Issue Details
Resolves #71119

Resolves #71316
Author:TIHan
Assignees:TIHan
Labels:
area-ILTools-coreclr, needs-area-label
Milestone:-
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@TIHan I guess there's a github-side configuration that I don't know about. Oh well.
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
@BruceForstall
BruceForstall
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
@BruceForstall It's listed in #71732 and @TIHan is aware. Short answer is most of it and the ilasm scripts only look at the entrypoint dll, and merged groups put the tests in other dlls.
So we're not actually round-tripping the tests anymore? That sounds like a significant drop in test coverage. Presumably the "entrypoint dlls" are stylized so we aren't getting a variety of code patterns through the round-trip testing.
@markples
markples
commented
Aug 9, 2023

Copy link


Copy Markdown

Contributor
That's correct. Only RequiresProcessIsolation would be preserved right now.
@JulieLeeMSFTJulieLeeMSFT
added this to the 9.0.0 milestone
Sep 6, 2023
@BruceForstall
BruceForstall
commented
Sep 13, 2023

Copy link


Copy Markdown

Contributor
@TIHan Can you mark this "Draft" until it's ready to review again?
@TIHan
TIHan
marked this pull request as draft
September 13, 2023 19:20
@TIHan
TIHan
commented
Oct 3, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp run runtime-coreclr ilasm
@azure-pipelines
azure-pipelinesBot
commented
Oct 3, 2023

Copy link


Copy Markdown


Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
@TIHan
TIHan
commented
Oct 4, 2023

Copy link


Copy Markdown

ContributorAuthor
Only about 10 failures now.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Open

5 tasks
@TIHan
TIHan
marked this pull request as ready for review
October 5, 2023 15:56
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
@BruceForstall this is ready - CI passed green - https://dev.azure.com/dnceng-public/public/_build/results?buildId=427905&view=results
The original assemblies get copied to IL-RT
@TIHan
TIHan
commented
Oct 5, 2023

Copy link


Copy Markdown

ContributorAuthor
// cc @dotnet/jit-contrib
@ghostghost
mentioned this pull request
Oct 5, 2023

Closed

BruceForstall
BruceForstall
approved these changes
Oct 5, 2023
View reviewed changes
@BruceForstallBruceForstall
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please trigger the ilasm pipeline on your final changes and ensure the pipeline is clean before merging.
@TIHan
TIHan
commented
Oct 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Pipeline run green: https://dev.azure.com/dnceng-public/public/_build/results?buildId=429300&view=results
@TIHan
TIHan
merged commit 7f32a81
into
dotnet:mainOct 6, 2023
@TIHanTIHan
mentioned this pull request
Oct 6, 2023
 Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 5, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-ILTools-coreclr

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Test failure profiler\\rejit\\rejit\\rejit.cmd

ilasm roundtrip testing should ensure roundtripped assembly file name matches baked-in assembly name


5 participants

@TIHan@jakobbotsch@markples@BruceForstall@JulieLeeMSFT