Uh oh!
There was an error while loading. Please reload this page.
Add emitDispEmbBroadcastCount to display the embedded broadcasted element count. - #90123
Merged
Merged
Conversation
the embedded broadcasted element count.
ghost
commented
Aug 7, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsDescriptionJitDisasm doesn't include embedded broadcast syntax in disassembly. This PR will add the missing tag with the broadcasted element count, so the new disassembly will look like:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rename the previous `emitGetMemOpSize` to `emitGetBaseMemOpSize`, the new `emitGetMemOpSize` will check if EVEX.b is set and return the memory size accordingly.
Ruihan-Yin
marked this pull request as ready for review
August 8, 2023 17:58
added 2 missing break
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1. remove un-needed helper function. 2. move the Evexb check into the display function.
BruceForstall
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JitDisasm doesn't include embedded broadcast syntax in disassembly.
Eg.
vaddps zmm0, zmm0, dword ptr [reloc @RWD00]This PR will add the missing tag with the broadcasted element count, so the new disassembly will look like:
vaddps zmm0, zmm0, dword ptr [reloc @RWD00] {1to16}