Add metrics configuration APIs - #90201

Merged
noahfalk merged 50 commits into
dotnet:mainfrom
Tratcher:tratcher/metrics
Aug 11, 2023
Merged

Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom
Tratcher:tratcher/metrics

Conversation

@Tratcher

@TratcherTratcher commented Aug 8, 2023

Copy link
Copy Markdown
Member

Contributes to #85684.

This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.

One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.

The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.

The goal is to have this merged by Thursday afternoon.

Tratcher added 30 commits July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs Outdated
tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs Outdated
return;
}

if (_instruments.TryGetValue(instrument, out var _))

@tarekghtarekghAug 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _))

Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.

@TratcherTratcherAug 10, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.

@tarekghtarekghAug 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like

runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15 in 79b9707

<CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" />

tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs Outdated
tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs Outdated
tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

var ruleMeterName = rule.MeterName.AsSpan();
// Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))

@tarekghtarekghAug 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))

what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.

@TratcherTratcherAug 10, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)

tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs Outdated
tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
/// </summary>
public MeterScope Scopes { get; } = scopes == MeterScope.None
? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
: scopes;

@tarekghtarekghAug 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes;

should we validate this if someone added more unsupported values? or we don't care?

@TratcherTratcherAug 10, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.

@tarekghtarekghAug 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.

tarekgh
tarekgh reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs Outdated
@carlossanlop

carlossanlop commented Aug 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

CC @gewarren@carlosalberto

Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄

@tarekgh

tarekgh commented Aug 10, 2023

Copy link
Copy Markdown
Member

Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄

Sorry @carlosalberto, I promise will be more careful next time.

noahfalk
noahfalk approved these changes Aug 11, 2023
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.

@noahfalk
noahfalk merged commit 786b987 into dotnet:mainAug 11, 2023
@tarekgh

tarekgh commented Aug 11, 2023

Copy link
Copy Markdown
Member

@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.

@Tratcher
Tratcher deleted the tratcher/metrics branch August 11, 2023 16:11
@captainsafiacaptainsafia mentioned this pull request Aug 14, 2023
Merged
@TratcherTratcher mentioned this pull request Aug 15, 2023
Merged
@noahfalknoahfalk mentioned this pull request Aug 15, 2023
Merged
xakep139
xakep139 reviewed Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
<!-- Disabling baseline validation since this is a brand new package.
Once this package has shipped a stable version, the following line
should be removed in order to re-enable validation. -->
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>

@xakep139xakep139Aug 17, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?

@tarekghtarekghAug 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.

@ViktorHoferViktorHoferAug 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.

@ghostghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes
+1 more reviewer
@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add metrics configuration APIs - #90201
Merged
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Aug 11, 2023
Merged
Add metrics configuration APIs#90201
noahfalk merged 50 commits into
dotnet:mainfrom 
Tratcher:tratcher/metrics
Conversation
@Tratcher
@TratcherTratcher
commented
Aug 8, 2023

Copy link


Copy Markdown

Member
Contributes to #85684.
This adds a set of new APIs used to configure metrics and which listeners they should be paired with. The API closely follows the design from logging.
One new package is added, Microsoft.Extensions.Diagnostics.Abstractions.
The components in the Microsoft.Extensions.Diagnostics.Configuration namespace will be implemented in a later PR.
The goal is to have this merged by Thursday afternoon.
Tratcher
added 30 commits
July 25, 2023 10:12
@Tratcher
Packaging
919033d
@Tratcher
Bulk add types
775c9dd
@Tratcher
Configuration packaging, API ref
a537d9e
@Tratcher
Hosting API dump, dependencies
7453b2a
@Tratcher
AddConsole
784becb
@Tratcher
Hosting wireup
6103d82
@Tratcher
Rules
f599cb9
@Tratcher
Wire up the factory
97aee1f
@Tratcher
Revert non-CLS Compliance
646fe7c
@Tratcher
Feedback, scopes
7b90ec2
@Tratcher
Split DefaultMeterFactory
80dfa86
@Tratcher
Remove hosting CLS compliance
4d789be
@Tratcher
Split out listener subscriptions.
3bf5e56
@Tratcher
Remove filter, add enable, replace TListener with string, internal Co…
74da7e1
…nsole Listener
@Tratcher
IMetric_s_SubscriptionManager
0c11591
@Tratcher
Better matching
2109487
@Tratcher
sealed
a7e1884
@Tratcher
Rule heirarchy, tests
f0f578b
@Tratcher
Test cases
74bc673
@Tratcher
Listener name constant
743d27f
@Tratcher
Add/ClearListener
c2a249d
@Tratcher
More console output
8275820
@Tratcher
Revert DefaultMeterFactory changes
3747367
@Tratcher
Cleanup
84eebd6
@Tratcher
Notes
5205861
@Tratcher
Console updates, SetSoruce
dd8c364
@Tratcher
Update InstrumentPublished
fc3553e
@Tratcher
Move MetricsBuilderEnableExtensions back
5e042a7
@Tratcher
API refactor
2852d14
@Tratcher
GetMeasurementHandlers();
98f3eff
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DebugConsoleMetricListener.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

 return;
 }

 if (_instruments.TryGetValue(instrument, out var _))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(_instruments.TryGetValue(instrument, out var _)) 
Should we ensure the dictionary is created with reference equality comparer? In the future there may be added equality support to the instrument which possibly can make two instruments with the same name/descriptions be equal.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not available on all of our TFMs.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can polyfill this I guess the same way we do like 
runtime/src/libraries/Microsoft.Extensions.Options.DataAnnotations/src/Microsoft.Extensions.Options.DataAnnotations.csproj

Line 15
in
79b9707
 <CompileInclude="$(CoreLibSharedDir)System\Collections\Generic\ReferenceEqualityComparer.cs" /> 
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs

 var ruleMeterName = rule.MeterName.AsSpan();
 // Rule "System.Net.*" matches meter "System.Net" and "System.Net.Http"
 if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal))
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ruleMeterName.EndsWith(".*".AsSpan(), StringComparison.Ordinal)) 
what happen if someone specify the rule .* only? would it be ok to have this equal to the rule with empty string or * only? I think this may be confusing.
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being discussed over at #90201 (comment)
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/ListenerSubscription.cs
Outdated

tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/InstrumentRule.cs
 /// </summary>
 public MeterScope Scopes { get; } = scopes == MeterScope.None
 ? throw new ArgumentOutOfRangeException(nameof(scopes), scopes, "The MeterScope must be Global, Local, or both.")
 : scopes;
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes; 
should we validate this if someone added more unsupported values? or we don't care?
@TratcherTratcherAug 10, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly worried about the common case where someone passes in None by mistake. If they want to deliberately pass in other values I'm not going to question them too closely 😁.
@tarekghtarekghAug 10, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here but would prefer to communicate the failure sooner instead of having the user see unexpected behavior later and it will be hard to investigate.
tarekgh
tarekgh
reviewed
Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Hosting/ref/Microsoft.Extensions.Hosting.cs
Outdated

@carlossanlop
carlossanlop
commented
Aug 10, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
CC @gewarren@carlosalberto
Poor @carlosalberto. He always gets tagged by @tarekgh instead of me. 😄
@tarekgh
tarekgh
commented
Aug 10, 2023

Copy link


Copy Markdown

Member
Poor @carlosalberto. He always gets tagged by @tarekgh Tarek Mahmoud Sayed FTE instead of me. 😄
Sorry @carlosalberto, I promise will be more careful next time.
noahfalk
noahfalk
approved these changes
Aug 11, 2023
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking approved so we can get this into RC1. The vast majority looks good but I still disagree with the inconsistent behavior for string matching between metrics and logging. Chris is out tomorrow so any changes there will need to happen in RC2.
@noahfalk
noahfalk
merged commit 786b987
into
dotnet:mainAug 11, 2023
@tarekgh
tarekgh
commented
Aug 11, 2023

Copy link


Copy Markdown

Member
@noahfalk@Tratcher we still have Monday if we need to do anything more before RC1 snap.
@Tratcher
Tratcher
deleted the

tratcher/metrics

branch
August 11, 2023 16:11
@captainsafiacaptainsafia
mentioned this pull request
Aug 14, 2023
 Merged

@TratcherTratcher
mentioned this pull request
Aug 15, 2023
 Merged

@noahfalknoahfalk
mentioned this pull request
Aug 15, 2023
 Merged

xakep139
xakep139
reviewed
Aug 17, 2023
View reviewed changes
Comment thread...Extensions.Diagnostics.Abstractions/src/Microsoft.Extensions.Diagnostics.Abstractions.csproj
 <!-- Disabling baseline validation since this is a brand new package.
 Once this package has shipped a stable version, the following line
 should be removed in order to re-enable validation. -->
 <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
@xakep139xakep139Aug 17, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an issue be created to track that?
@tarekghtarekghAug 17, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We scan all libraries for this and remove it. @ViktorHofer may advise if we need to track individual libraries.
@ViktorHoferViktorHoferAug 17, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tracking issue needed. We do this every year around December when the previous .NET version has released. We have this written down in a OneNote.
@ghostghost
locked as resolved and limited conversation to collaborators
Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@stephentoubstephentoubstephentoub left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@tarekghtarekghtarekgh left review comments
@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@xakep139xakep139xakep139 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TratcherTratcher

Labels

area-System.Diagnostics.Metricnew-api-needs-documentation

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@Tratcher@joperezr@tarekgh@wtgodbe@carlossanlop@stephentoub@noahfalk@xakep139@ViktorHofer