Skip to content

[RISC-V] Initial commit for libraries directory - #90203

Merged
jkotas merged 2 commits into
dotnet:mainfrom
t-mustafin:riscv_libraries
Sep 13, 2023
Merged

[RISC-V] Initial commit for libraries directory#90203
jkotas merged 2 commits into
dotnet:mainfrom
t-mustafin:riscv_libraries

Conversation

@t-mustafin

@t-mustafint-mustafin commented Aug 8, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

RISC-V API proposed in #73437.
Part of #84834.
cc @alpencolt@gbalykov@ashaurtaev@clamp03.

@ghostghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Aug 8, 2023
@ghost

ghost commented Aug 8, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Aug 8, 2023
This was referenced Aug 9, 2023
Closed
Closed
am11
am11 reviewed Aug 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Architecture.cs Outdated
@t-mustafin
t-mustafin marked this pull request as ready for review August 9, 2023 19:49
@clamp03clamp03 added the arch-riscv Related to the RISC-V architecture label Aug 10, 2023
@t-mustafin
t-mustafin requested a review from am11August 10, 2023 13:59
@am11am11 added this to the 9.0.0 milestone Aug 10, 2023
@am11

am11 commented Aug 10, 2023

Copy link
Copy Markdown
Member
  • We will need to wait for API to be approved.
  • Lets drop Riscv32 and Riscv128, since those targets are not supported (yet 🙂)

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Aug 10, 2023
View reviewed changes
Comment threadsrc/libraries/Common/tests/System/Net/Http/TestHelper.cs Outdated
@t-mustafin

t-mustafin commented Aug 15, 2023

Copy link
Copy Markdown
ContributorAuthor
  • Lets drop Riscv32 and Riscv128, since those targets are not supported (yet 🙂)

@am11 Should I drop Riscv{32,128} all over the patch or except Machine.cs and System.Reflection.Metadata.cs? This two files also have some targets are not supported yet, e.g. LoongArch32.

@am11

am11 commented Aug 15, 2023

Copy link
Copy Markdown
Member

I think the metadata change is fine if it makes things consistent, but we can ask this question during (or after) the API review whenever it will take place.

@gbalykov

gbalykov commented Aug 22, 2023

Copy link
Copy Markdown
Member

@am11 do we need to open separate PR to approve new API?

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Aug 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@am11 do we need to open separate PR to approve new API?

I believe #73437 is tracking the API. If it is ready, I can set it ready for approval.

EDIT Based on this work and the question, I marked #73437 "ready for review".

jkotas
jkotas reviewed Aug 30, 2023
View reviewed changes
Comment thread...es/System.Reflection.Metadata/src/System/Reflection/PortableExecutable/ManagedTextSection.cs Outdated

@jkotasjkotasAug 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only needed if Windows got ported to Riscv64.

There are many 64-bit architectures missing in this check and it is not causing any issues.

I would keep this simple and omit the Riscv check from here.

@t-mustafint-mustafinAug 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@t-mustafin
t-mustafinforce-pushed the riscv_libraries branch 2 times, most recently from 4b9e266 to ad6e24aCompareAugust 30, 2023 21:41
@jkotasjkotas added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 31, 2023
@ghost

ghost commented Aug 31, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

RISC-V API proposed in #73437.
Part of #84834.
cc @alpencolt@gbalykov@ashaurtaev@clamp03.

Author:t-mustafin
Assignees:t-mustafin
Labels:

area-System.Runtime.InteropServices, new-api-needs-documentation, community-contribution, arch-riscv, needs-area-label

Milestone:9.0.0

@jkotasjkotas added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 31, 2023
@jkotas

jkotas commented Aug 31, 2023

Copy link
Copy Markdown
Member

#73437 needs to go through API review before this can be merged.

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Sep 12, 2023

Copy link
Copy Markdown
Member

These new APIs have been approved. The only update was to change the casing of the v to be uppercase so it properly refers to "5".

am11
am11 reviewed Sep 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated
@AaronRobinsonMSFTAaronRobinsonMSFT removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 12, 2023
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Sep 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/ref/System.Reflection.Metadata.cs Outdated
jkotas
jkotas reviewed Sep 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Architecture.cs Outdated
jkotas
jkotas reviewed Sep 13, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEHeadersTests.cs Outdated
@t-mustafin@jkotas
Update src/libraries/System.Reflection.Metadata/tests/PortableExecuta…
8e835e6
…ble/PEHeadersTests.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
jkotas approved these changes Sep 13, 2023
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jkotasjkotas mentioned this pull request Sep 13, 2023
Closed
@jkotas
jkotas merged commit 1c93ad7 into dotnet:mainSep 13, 2023
@am11am11 mentioned this pull request Sep 13, 2023
Closed
@t-mustafin
t-mustafin deleted the riscv_libraries branch September 19, 2023 18:58
@ghostghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT left review comments
@jkotasjkotasjkotas approved these changes
+3 more reviewers
@am11am11am11 left review comments
@clamp03clamp03clamp03 approved these changes
@ashaurtaevashaurtaevashaurtaev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@t-mustafint-mustafin

Labels

arch-riscvRelated to the RISC-V architecturearea-System.Runtime.InteropServicescommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@t-mustafin@am11@gbalykov@AaronRobinsonMSFT@jkotas@clamp03@ashaurtaev