Uh oh!
There was an error while loading. Please reload this page.
CodeDom null annotations fixes - #90393
Closed
halgab wants to merge 3 commits into
Closed
Conversation
ghost
commented
Aug 11, 2023
Tagging subscribers to this area: @dotnet/area-system-codedom Issue DetailsThis is a first step towards fixing #78036. Here, I fix three classes identified to have false annotations today. I hope to get some feedback from the team to see if I'm heading in the right direction.
|
3 tasks
steveharter
commented
Aug 14, 2023
Contributor
Closing since #90401 disabled nullability for System.CodeDom. We can work on a full nullability approach in v9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step towards fixing #78036. Here, I fix three classes identified to have false annotations today. I hope to get some feedback from the team to see if I'm heading in the right direction.