Skip to content

Update DNNE - #90425

Merged
jtschuster merged 1 commit into
dotnet:mainfrom
jtschuster:jtschuster-patch-2
Aug 12, 2023
Merged

Update DNNE#90425
jtschuster merged 1 commit into
dotnet:mainfrom
jtschuster:jtschuster-patch-2

Conversation

@jtschuster

@jtschusterjtschuster commented Aug 11, 2023

Copy link
Copy Markdown
Member

Fixes#90376

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 11, 2023
@ghostghost assigned jtschusterAug 11, 2023
@jtschusterjtschuster added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 11, 2023
@ghost

ghost commented Aug 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #90376

Author:jtschuster
Assignees:jtschuster
Labels:

area-System.Runtime.InteropServices, needs-area-label

Milestone:-

@build-analysisbuild-analysisBot mentioned this pull request Aug 11, 2023
Closed
3 tasks
@BruceForstall

BruceForstall commented Aug 12, 2023

Copy link
Copy Markdown
Contributor

Ready to merge?

@jtschuster

jtschuster commented Aug 12, 2023

Copy link
Copy Markdown
MemberAuthor

Yes, thanks for the bump, I lost track of this waiting for CI.

@jtschuster
jtschuster merged commit 39c0dbf into dotnet:mainAug 12, 2023
@BruceForstall

BruceForstall commented Aug 12, 2023

Copy link
Copy Markdown
Contributor

@jtschuster@AaronRobinsonMSFT@jkoritzinsky It doesn't look like this fixed the problem. I kicked off a run after this merged, and it still has the failures:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=371718&view=ms.vss-test-web.build-test-results-tab&runId=7887268&resultId=200384&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

@jtschuster

jtschuster commented Aug 12, 2023

Copy link
Copy Markdown
MemberAuthor

I don't access to a computer to make the PR, but if you need it ASAP you can revert the version back to 1.0.27 and it should work again.

@ghostghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@jtschusterjtschuster

Labels

area-System.Runtime.InteropServices

Projects

None yet

Milestone

No milestone

4 participants

@jtschuster@BruceForstall@jkoritzinsky@AaronRobinsonMSFT