Skip to content

support SslStream SSLKEYLOGFILE in debug builds - #90429

Merged
wfurt merged 3 commits into
dotnet:mainfrom
wfurt:keylog
Aug 14, 2023
Merged

support SslStream SSLKEYLOGFILE in debug builds#90429
wfurt merged 3 commits into
dotnet:mainfrom
wfurt:keylog

Conversation

@wfurt

@wfurtwfurt commented Aug 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

As #83001 introduced this for Quic, this change adds support to SslStream as well.
For security reasons this requires debug binaries (similar to browsers)
Works only on platforms where OpenSSL is the backend e.g. Linux & FreeBSD.

fixes#37915

@wfurtwfurt added area-System.Net.Security os-linux Linux OS (any supported distro) labels Aug 11, 2023
@wfurtwfurt added this to the 8.0.0 milestone Aug 11, 2023
@wfurt
wfurt requested review from a team and stephentoubAugust 11, 2023 21:17
@wfurtwfurt self-assigned this Aug 11, 2023
@ghost

ghost commented Aug 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

As #83001 introduced this for Quic, this change adds support to SslStream as well.
For security reasons this requires debug binaries (similar to browsers)
Works only on platforms where OpenSSL is the backend e.g. Linux & FreeBSD.

fixs #37915

Author:wfurt
Assignees:wfurt
Labels:

area-System.Net.Security, os-linux

Milestone:8.0.0

This was referenced Aug 12, 2023
Closed
Closed
stephentoub
stephentoub approved these changes Aug 14, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs Outdated
Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs Outdated
@wfurt
wfurt merged commit 58e0349 into dotnet:mainAug 14, 2023
@wfurt
wfurt deleted the keylog branch August 14, 2023 23:13
@build-analysisbuild-analysisBot mentioned this pull request Aug 15, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@wfurtwfurt

Labels

area-System.Net.Securityos-linuxLinux OS (any supported distro)

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Support SSLKEYLOGFILE in SslStream

2 participants

@wfurt@stephentoub