Uh oh!
There was an error while loading. Please reload this page.
[mono][ios] Revert LLVM mode for apple mobile tests - #90586
Conversation
kotlarmilos
commented
Aug 15, 2023
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ghost
commented
Aug 15, 2023
Tagging subscribers to this area: @directhex Issue DetailsThis PR reverts using LLVM mode for apple mobile tests. The regression was introduced in https://github.com/dotnet/runtime/pull/87773/files#diff-efa78f3f0523ef8b61f94772d9c204608051d411527cb9be83ca60266dc1d2f9R19.
|
ghost
commented
Aug 15, 2023
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsThis PR reverts using LLVM mode for apple mobile tests. The regression was introduced in https://github.com/dotnet/runtime/pull/87773/files#diff-efa78f3f0523ef8b61f94772d9c204608051d411527cb9be83ca60266dc1d2f9R19.
|
kotlarmilos
commented
Aug 15, 2023
We probably need to backport it to .NET 8. |
| <_AOTBuildCommand Condition="'$(ContinuousIntegrationBuild)' != 'true'">$(_AOTBuildCommand) /p:RuntimeSrcDir=$(RepoRoot) /p:RuntimeConfig=$(Configuration)</_AOTBuildCommand> | ||
| <_AOTBuildCommand>$(_AOTBuildCommand) /p:XHARNESS_EXECUTION_DIR="$XHARNESS_EXECUTION_DIR" /p:RunAOTCompilation=$(RunAOTCompilation) /p:UseNativeAOTRuntime=$(UseNativeAOTRuntime) /p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:MonoForceInterpreter=$(MonoForceInterpreter) /p:DevTeamProvisioning=$(DevTeamProvisioning) /p:UsePortableRuntimePack=true /p:Configuration=$(Configuration)</_AOTBuildCommand> | ||
| <_AOTBuildCommand>$(_AOTBuildCommand) /p:XHARNESS_EXECUTION_DIR="$XHARNESS_EXECUTION_DIR" /p:RunAOTCompilation=$(RunAOTCompilation) /p:UseNativeAOTRuntime=$(UseNativeAOTRuntime) /p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:MonoForceInterpreter=$(MonoForceInterpreter) /p:MonoEnableLLVM=true /p:DevTeamProvisioning=$(DevTeamProvisioning) /p:UsePortableRuntimePack=true /p:Configuration=$(Configuration)</_AOTBuildCommand> |
There was a problem hiding this comment.
Might be good to add a comment what is the reason of passing /p:MonoEnableLLVM=true here, so we don't end up trying to remove again it is some later refactoring
There was a problem hiding this comment.
These could be in AppleBuild.LocalBuild.props/targets instead. They were originally here to guarantee the right values were being provided and to reduce iterating on helix.
SamMonoRT
commented
Aug 15, 2023
Yes, backport to RC1 following standard backport proccess |
kotlarmilos
commented
Aug 15, 2023
/backport to release/8.0-rc1 |
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5870449646 |
This PR reverts using LLVM mode for apple mobile tests. The regression was introduced in https://github.com/dotnet/runtime/pull/87773/files#diff-efa78f3f0523ef8b61f94772d9c204608051d411527cb9be83ca60266dc1d2f9R19.