Skip to content

[release/8.0-rc1] Add missing type forwards - #90673

Merged
ViktorHofer merged 2 commits into
release/8.0-rc1from
backport/pr-90669-to-release/8.0-rc1
Aug 16, 2023
Merged

[release/8.0-rc1] Add missing type forwards#90673
ViktorHofer merged 2 commits into
release/8.0-rc1from
backport/pr-90669-to-release/8.0-rc1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 16, 2023•
edited by ViktorHofer
Loading

Copy link
Copy Markdown
Contributor

Backport of #90669 to release/8.0-rc1

/cc @ViktorHofer

Customer Impact

Customers migrating from .NET Framework to .NET who reference the AssemblyRegistrationFlags, ExporterEventKind, PEFileKinds, RegistrationClassContext or RegistrationConnectionType types would see an application crash because of a TypeLoadException. Reason is that type forwards are missing from the mscorlib facade assembly.

Testing

Manually tested by diffing the produced assembly via ILDasm.

Risk

Low. Type forwards are added to the mscorlib.dll assembly only. Other code isn't impacted.

@ViktorHofer
Add missing type forwards
16dae46
Fixes#90578
IDispatchImplAttribute, IDispatchImplType and SetWin32ContextInIDispatchAttribute were removed with 9f1dd1a and 26a91ad
Those dropped types weren't flagged because APICompat only validates reference assemblies. We have three implementation only shim assemblies: mscorlib, System and System.Data. I verified that no other type forwards were lost between .NET 7 and .NET 8.
@ghost

ghost commented Aug 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90669 to release/8.0-rc1

/cc @ViktorHofer

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release Servicing-consider Issue for next servicing release review and removed Servicing-approved Approved for servicing release labels Aug 16, 2023
@carlossanlop

carlossanlop commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

Assuming all feedback in the main PR is addressed, we can merge this.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 16, 2023
@ViktorHofer

ViktorHofer commented Aug 16, 2023

Copy link
Copy Markdown
Member

Ready to merge in for .NET 8 to fix the regression. Further discussions in the main PR shouldn't affect this backport.

@ViktorHofer
ViktorHofer merged commit 7cc25f5 into release/8.0-rc1Aug 16, 2023
@ViktorHofer
ViktorHofer deleted the backport/pr-90669-to-release/8.0-rc1 branch August 16, 2023 19:42
@radicalradical mentioned this pull request Aug 28, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop@ViktorHofer