Expose extension points needed by UnityLinker.

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe

[mrvoorhe]

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

[ghost]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Expose stages of MarkStep for customization

• Add back MethodsWithOverrideInformation

• Expose TypeMapInfo and EnsureProcessed

• Re-expose a way to pass in a different UnintializedContextFactory

• Move AssemblyResolver creation to UnintializedContextFactory so that we can have control over the resolver again.

• Make AssemblyResolver more extensible

• We need to search winmd files.

• We control over setting up the ReaderParameters

• Expose some methods we need to override.

• Make KeepMembersForDebugger a property so we can turn it on or off.

• Make MarkAssembly virtual

• Re-expose ShouldMarkInterfaceImplementation

Author:	mrvoorhe
Assignees:	-
Labels:	linkable-framework, area-Tools-ILLink
Milestone:	-

[mrvoorhe]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

[vitek-karas]

This is probably going to fail the ref api checks. I forget the command to update the suppressions, but I remember the job that fails tells you the command to run. If I get that failure I'll update the PR.

I don't know about the api checks, but there's an intentional difference between members marked as public and the surface exposed through the ref assemblies. I would expect this change to NOT modify the ref assemblies. The ref assemblies are solely for custom steps - basically an attempt to minimize the API surface exposed to custom steps (with an eventual goal of removing custom steps altogether).

@sbomer might know details about the ref assembly generation - if it does become a problem.

[sbomer]

The api compat validation changed with the move to dotnet/runtime, and it now checks that public APIs in the implementation are also in the ref assembly. As @vitek-karas described, that's not what we want, so we use the suppressions.

The build failure is showing:

error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

Last time you updated the suppressions it looked right to me. I assume this is how you did it.

[mrvoorhe]

@vitek-karas@sbomer I think this PR is ready. There are failures but I don't think they are related.

[vitek-karas]

Looks good.

[mrvoorhe]

@vitek-karas This PR is ready to be merged.

[vitek-karas]

Thanks a lot @mrvoorhe