Skip to content

[RISC-V] Fix MarshalStructAsLayoutSeq - #90719

Merged
jakobbotsch merged 3 commits into
dotnet:mainfrom
clamp03:fixmarshal
Aug 29, 2023
Merged

[RISC-V] Fix MarshalStructAsLayoutSeq#90719
jakobbotsch merged 3 commits into
dotnet:mainfrom
clamp03:fixmarshal

Conversation

@clamp03

Copy link
Copy Markdown
Member
  • Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest
  • Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
    Ex. Argument in struct { int a, int b, float c} type should be passed with two integer registers (not one integer register and one float register).

Part of #84834
cc @wscho77@HJLeee@JongHeonChoi@t-mustafin@alpencolt@gbalykov@tomeksowi

- Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest
- Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Aug 17, 2023
@clamp03clamp03 self-assigned this Aug 17, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fix MarshalStructAsParam_AsSeqByValFixedBufferClassificationTest
  • Fix MarshalStructAsParam_AsSeqByValUnicodeCharArrayClassification
    Ex. Argument in struct { int a, int b, float c} type should be passed with two integer registers (not one integer register and one float register).

Part of #84834
cc @wscho77@HJLeee@JongHeonChoi@t-mustafin@alpencolt@gbalykov@tomeksowi

Author:clamp03
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@clamp03clamp03 added the arch-riscv Related to the RISC-V architecture label Aug 17, 2023
@clamp03
clamp03 marked this pull request as ready for review August 18, 2023 02:24
@clamp03

Copy link
Copy Markdown
MemberAuthor

@jakobbotsch Could you take a look at this PR? Thank you so much.

Comment threadsrc/coreclr/jit/lclvars.cpp Outdated
@jakobbotsch
jakobbotsch merged commit f175acf into dotnet:mainAug 29, 2023
@clamp03
clamp03 deleted the fixmarshal branch August 30, 2023 10:56
@ghostghost locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-riscvRelated to the RISC-V architecturearea-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@clamp03@tomeksowi@alpencolt@jakobbotsch@t-mustafin