Skip to content

[release/8.0] Expose TC_CallCountThreshold and TC_CallCountingDelayMs as runtime knobs - #90761

Merged
carlossanlop merged 1 commit into
release/8.0from
backport/pr-90724-to-release/8.0
Aug 17, 2023
Merged

[release/8.0] Expose TC_CallCountThreshold and TC_CallCountingDelayMs as runtime knobs#90761
carlossanlop merged 1 commit into
release/8.0from
backport/pr-90724-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Backport of #90724 to release/8.0

/cc @EgorBo

Customer Impact

We have two groups of low-level configuration knobs:

  1. Only available via env vars (e.g. $env:DOTNET_Foo=1)
  2. Available via env vars and runtime.json + msbuild properties

This PR promotes these two knobs from 1) to 2) because:

  1. We're shipping PGO this relese and it may potentially impact startup time and these settings being promoted make it easier to play with them to mitigate potential startup time regressions
  2. An Internal customer requested these to be available in runtime.config

Testing

Tested locally

Risk

No risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghostghost added the area-VM-coreclr label Aug 17, 2023

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and then this is ready to merge

@EgorBo

Copy link
Copy Markdown
Member

PTAL @mangod9

@EgorBo
EgorBo requested a review from mangod9August 17, 2023 18:26
@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Aug 17, 2023
@carlossanlop

Copy link
Copy Markdown
Contributor

Failure is known: #90593

Ready to merge.

@carlossanlop
carlossanlop merged commit 38a1170 into release/8.0Aug 17, 2023
@carlossanlop
carlossanlop deleted the backport/pr-90724-to-release/8.0 branch August 17, 2023 21:33
@ghostghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@carlossanlop@jeffschwMSFT@mangod9