Skip to content

JIT: Remove the minopts policy against cctors - #90792

Merged
JulieLeeMSFT merged 3 commits into
dotnet:mainfrom
hez2010:nominopt-cctor
Sep 1, 2023
Merged

JIT: Remove the minopts policy against cctors#90792
JulieLeeMSFT merged 3 commits into
dotnet:mainfrom
hez2010:nominopt-cctor

Conversation

@hez2010

@hez2010hez2010 commented Aug 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Removed the obsoleted policy.

/cc:@EgorBo

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Aug 18, 2023
@ghost

ghost commented Aug 18, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduce a switch to enable optimizations for cctors.

The plan is to leverage this switch to measure startup performance of some real-world applications, so I would like to ship this switch in net8.0.

Author:hez2010
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@hez2010
hez2010 marked this pull request as draft August 18, 2023 13:28
@hez2010
hez2010 marked this pull request as ready for review August 18, 2023 14:45
jkotas
jkotas reviewed Aug 18, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.cpp Outdated
@jkotas

jkotas commented Aug 18, 2023

Copy link
Copy Markdown
Member

The plan is to leverage this switch to measure startup performance of some real-world applications, so I would like to ship this switch in net8.0.

You can build your clrjit.dll with this change, replace it in your .NET 8 setup and measure it that way. This change does not meet the bar for .NET 8 backport.

@build-analysisbuild-analysisBot mentioned this pull request Aug 18, 2023
Closed
@hez2010hez2010 changed the title Introduce a switch to use FullOpts for cctorsJIT: Remove the minopts policy against cctorsAug 19, 2023
@EgorBo

EgorBo commented Aug 20, 2023•
edited
Loading

Copy link
Copy Markdown
Member

I needed opts in CCTORs for my prototype that replaces allocators with frozen allocators but I guess doing that in R2R only is fine.

@JulieLeeMSFTJulieLeeMSFT added this to the 9.0.0 milestone Sep 1, 2023
@JulieLeeMSFT
JulieLeeMSFT merged commit 31fc330 into dotnet:mainSep 1, 2023
@ghostghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@EgorBoEgorBoEgorBo approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hez2010@jkotas@EgorBo@JulieLeeMSFT