Skip to content

[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812

Merged
carlossanlop merged 5 commits into
dotnet:mainfrom
carlossanlop:LocMain
Aug 21, 2023
Merged

[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom
carlossanlop:LocMain

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Aug 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#90755

Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches

The first change requires changing the main mirror branch to release/8.0 temporarily.

The second change is to backport this to release/8.0.

@carlossanlopcarlossanlop self-assigned this Aug 18, 2023
@ghost

ghost commented Aug 18, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #90755

Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade

The first change requires changing the main mirror branch to release/8.0 temporarily.

The second change is to backport this to release/8.0.

Author:carlossanlop
Assignees:carlossanlop
Labels:

area-Infrastructure-libraries

Milestone:-

@carlossanlop

carlossanlop commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to release/8.0

@github-actions

github-actionsBot commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537

@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2023
Merged
@carlossanlopcarlossanlop mentioned this pull request Aug 18, 2023
Closed
@carlossanlop

carlossanlop commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to release/8.0-rc1

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2023
Closed
ericstj
ericstj reviewed Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
pool: ''

CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex

@ericstjericstjAug 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.

Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
# Localization build
#

# disabled due to https://github.com/dotnet/runtime/issues/90466

@ericstjericstjAug 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.

@carlossanlopcarlossanlopAug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?

@carlossanlopcarlossanlopAug 18, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.

@ericstjericstjAug 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.

@carlossanlop

carlossanlop commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp help

@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop

carlossanlop commented Aug 18, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp list

@azure-pipelines

azure-pipelinesBot commented Aug 18, 2023

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

ericstj
ericstj reviewed Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml Outdated
@build-analysisbuild-analysisBot mentioned this pull request Aug 19, 2023
Open
@carlossanlop

carlossanlop commented Aug 21, 2023

Copy link
Copy Markdown
ContributorAuthor

I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.

@carlossanlop
carlossanlop merged commit f868d08 into dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop deleted the LocMain branch August 21, 2023 16:44
This was referenced Aug 24, 2023
Merged
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0

4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[main] Change OneLocBuild mirror branch to release/8.0 temporarily by carlossanlop · Pull Request #90812 · dotnet/runtime · GitHub
Skip to content
[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812
Merged
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Aug 21, 2023
Merged
[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
@carlossanlopcarlossanlop
self-assigned this
Aug 18, 2023
@ghost
ghost
commented
Aug 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
Author:carlossanlop
Assignees:carlossanlop
Labels:
area-Infrastructure-libraries
Milestone:-
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@carlossanlopcarlossanlop
mentioned this pull request
Aug 18, 2023

Closed

@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Closed

ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
 pool: ''

 CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
@ericstjericstjAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
 # Localization build
 #

 # disabled due to https://github.com/dotnet/runtime/issues/90466
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
@carlossanlopcarlossanlopAug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
@carlossanlopcarlossanlopAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Aug 18, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Aug 19, 2023

Open

@carlossanlop
carlossanlop
commented
Aug 21, 2023

Copy link


Copy Markdown

ContributorAuthor
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.
@carlossanlop
carlossanlop
merged commit f868d08
into
dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop
deleted the

LocMain

branch
August 21, 2023 16:44

This was referenced Aug 24, 2023
 Merged

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0


4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Change OneLocBuild mirror branch to release/8.0 temporarily by carlossanlop · Pull Request #90812 · dotnet/runtime · GitHub
Skip to content
[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812
Merged
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Aug 21, 2023
Merged
[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
@carlossanlopcarlossanlop
self-assigned this
Aug 18, 2023
@ghost
ghost
commented
Aug 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
Author:carlossanlop
Assignees:carlossanlop
Labels:
area-Infrastructure-libraries
Milestone:-
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@carlossanlopcarlossanlop
mentioned this pull request
Aug 18, 2023

Closed

@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Closed

ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
 pool: ''

 CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
@ericstjericstjAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
 # Localization build
 #

 # disabled due to https://github.com/dotnet/runtime/issues/90466
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
@carlossanlopcarlossanlopAug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
@carlossanlopcarlossanlopAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Aug 18, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Aug 19, 2023

Open

@carlossanlop
carlossanlop
commented
Aug 21, 2023

Copy link


Copy Markdown

ContributorAuthor
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.
@carlossanlop
carlossanlop
merged commit f868d08
into
dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop
deleted the

LocMain

branch
August 21, 2023 16:44

This was referenced Aug 24, 2023
 Merged

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0


4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Change OneLocBuild mirror branch to release/8.0 temporarily by carlossanlop · Pull Request #90812 · dotnet/runtime · GitHub
Skip to content
[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812
Merged
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Aug 21, 2023
Merged
[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
@carlossanlopcarlossanlop
self-assigned this
Aug 18, 2023
@ghost
ghost
commented
Aug 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
Author:carlossanlop
Assignees:carlossanlop
Labels:
area-Infrastructure-libraries
Milestone:-
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@carlossanlopcarlossanlop
mentioned this pull request
Aug 18, 2023

Closed

@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Closed

ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
 pool: ''

 CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
@ericstjericstjAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
 # Localization build
 #

 # disabled due to https://github.com/dotnet/runtime/issues/90466
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
@carlossanlopcarlossanlopAug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
@carlossanlopcarlossanlopAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Aug 18, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Aug 19, 2023

Open

@carlossanlop
carlossanlop
commented
Aug 21, 2023

Copy link


Copy Markdown

ContributorAuthor
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.
@carlossanlop
carlossanlop
merged commit f868d08
into
dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop
deleted the

LocMain

branch
August 21, 2023 16:44

This was referenced Aug 24, 2023
 Merged

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0


4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[main] Change OneLocBuild mirror branch to release/8.0 temporarily by carlossanlop · Pull Request #90812 · dotnet/runtime · GitHub
Skip to content
[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812
Merged
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Aug 21, 2023
Merged
[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
@carlossanlopcarlossanlop
self-assigned this
Aug 18, 2023
@ghost
ghost
commented
Aug 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
Author:carlossanlop
Assignees:carlossanlop
Labels:
area-Infrastructure-libraries
Milestone:-
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@carlossanlopcarlossanlop
mentioned this pull request
Aug 18, 2023

Closed

@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Closed

ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
 pool: ''

 CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
@ericstjericstjAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
 # Localization build
 #

 # disabled due to https://github.com/dotnet/runtime/issues/90466
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
@carlossanlopcarlossanlopAug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
@carlossanlopcarlossanlopAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Aug 18, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Aug 19, 2023

Open

@carlossanlop
carlossanlop
commented
Aug 21, 2023

Copy link


Copy Markdown

ContributorAuthor
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.
@carlossanlop
carlossanlop
merged commit f868d08
into
dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop
deleted the

LocMain

branch
August 21, 2023 16:44

This was referenced Aug 24, 2023
 Merged

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0


4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[main] Change OneLocBuild mirror branch to release/8.0 temporarily by carlossanlop · Pull Request #90812 · dotnet/runtime · GitHub
Skip to content
[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812
Merged
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Aug 21, 2023
Merged
[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
@carlossanlopcarlossanlop
self-assigned this
Aug 18, 2023
@ghost
ghost
commented
Aug 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
Author:carlossanlop
Assignees:carlossanlop
Labels:
area-Infrastructure-libraries
Milestone:-
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@carlossanlopcarlossanlop
mentioned this pull request
Aug 18, 2023

Closed

@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Closed

ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
 pool: ''

 CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
@ericstjericstjAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
 # Localization build
 #

 # disabled due to https://github.com/dotnet/runtime/issues/90466
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
@carlossanlopcarlossanlopAug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
@carlossanlopcarlossanlopAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Aug 18, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Aug 19, 2023

Open

@carlossanlop
carlossanlop
commented
Aug 21, 2023

Copy link


Copy Markdown

ContributorAuthor
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.
@carlossanlop
carlossanlop
merged commit f868d08
into
dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop
deleted the

LocMain

branch
August 21, 2023 16:44

This was referenced Aug 24, 2023
 Merged

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0


4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[main] Change OneLocBuild mirror branch to release/8.0 temporarily by carlossanlop · Pull Request #90812 · dotnet/runtime · GitHub
Skip to content
[main] Change OneLocBuild mirror branch to release/8.0 temporarily - #90812
Merged
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Aug 21, 2023
Merged
[main] Change OneLocBuild mirror branch to release/8.0 temporarily#90812
carlossanlop merged 5 commits into
dotnet:mainfrom 
carlossanlop:LocMain
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes#90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
@carlossanlopcarlossanlop
self-assigned this
Aug 18, 2023
@ghost
ghost
commented
Aug 18, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.
Author:carlossanlop
Assignees:carlossanlop
Labels:
area-Infrastructure-libraries
Milestone:-
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Aug 18, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Merged

@carlossanlopcarlossanlop
mentioned this pull request
Aug 18, 2023

Closed

@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0-rc1
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2023
 Closed

ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/common/templates/job/onelocbuild.yml
 pool: ''

 CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
@ericstjericstjAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
 # Localization build
 #

 # disabled due to https://github.com/dotnet/runtime/issues/90466
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
@carlossanlopcarlossanlopAug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
@carlossanlopcarlossanlopAug 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
@ericstjericstjAug 18, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp help
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Aug 18, 2023

Copy link


Copy Markdown

ContributorAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Aug 18, 2023

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
ericstj
ericstj
reviewed
Aug 18, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Aug 19, 2023

Open

@carlossanlop
carlossanlop
commented
Aug 21, 2023

Copy link


Copy Markdown

ContributorAuthor
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems.
@carlossanlop
carlossanlop
merged commit f868d08
into
dotnet:mainAug 21, 2023
@carlossanlop
carlossanlop
deleted the

LocMain

branch
August 21, 2023 16:44

This was referenced Aug 24, 2023
 Merged

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Sep 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ericstjericstjericstj left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@cristianosuzuki77cristianosuzuki77Awaiting requested review from cristianosuzuki77
@lewinglewingAwaiting requested review from lewing

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Ensure localization changes are ported to release/8.0


4 participants

@carlossanlop@akoeplinger@ViktorHofer@ericstj