Skip to content

Events for IL methods without IL headers - #90826

Merged
AaronRobinsonMSFT merged 6 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime_90580_90485
Aug 19, 2023
Merged

Events for IL methods without IL headers#90826
AaronRobinsonMSFT merged 6 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime_90580_90485

Conversation

@AaronRobinsonMSFT

@AaronRobinsonMSFTAaronRobinsonMSFT commented Aug 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Dynamically generated methods like UnsafeAccessorAttribute
functions are marked as IL, but don't contain an IL header.
The lack of header is an indication the IL must be generated
at runtime.

Fixes#90485
Fixes#90580
Fixes#90593

@AaronRobinsonMSFT
Events for IL methods without IL headers
442d98b
Dynamically generated methods like UnsafeAccessor
functions are marked as IL, but don't contain an IL
header. The lack of header is an indication the IL must
be generated at runtime.
@ghostghost added the area-VM-coreclr label Aug 18, 2023
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Aug 18, 2023

Copy link
Copy Markdown
MemberAuthor

This also reverts #90801.

@AaronRobinsonMSFTAaronRobinsonMSFT added this to the 8.0.0 milestone Aug 18, 2023
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Aug 18, 2023

Copy link
Copy Markdown
MemberAuthor

There are also two places in the dac that should probably be updated.

tlakollo
tlakollo reviewed Aug 18, 2023
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/stack.cpp Outdated
@AaronRobinsonMSFT@tlakollo
Update src/coreclr/debug/daccess/stack.cpp
de9cb9f
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
jkotas
jkotas reviewed Aug 18, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/eventtrace.cpp Outdated
jkotas
jkotas reviewed Aug 18, 2023
View reviewed changes
Comment threadsrc/coreclr/debug/daccess/stack.cpp Outdated
jkotas
jkotas approved these changes Aug 18, 2023
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Aug 19, 2023

Copy link
Copy Markdown
MemberAuthor

Failure is #90605

This was referenced Aug 19, 2023
Closed
Open
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit a429b0c into dotnet:mainAug 19, 2023
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the runtime_90580_90485 branch August 19, 2023 15:03
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Aug 19, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0

@github-actions

github-actionsBot commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5912095063

@github-actionsgithub-actionsBot mentioned this pull request Aug 19, 2023
Merged
@jkotasjkotas mentioned this pull request Aug 23, 2023
Closed
This was referenced Sep 14, 2023
Closed
Closed
Closed
@adamsitnikadamsitnik mentioned this pull request Sep 18, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
+1 more reviewer
@tlakollotlakollotlakollo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@AaronRobinsonMSFTAaronRobinsonMSFT

Labels

area-VM-coreclr

Projects

None yet

Milestone

8.0.0

3 participants

@AaronRobinsonMSFT@jkotas@tlakollo