Uh oh!
There was an error while loading. Please reload this page.
[release/8.0] Fix config names for CallCountThreshold and CallCountingDelayMs - #90841
Merged
Merged
Conversation
EgorBo
commented
Aug 19, 2023
Member
@mangod9 PTAL backported fix, thanks |
mangod9
approved these changes
Aug 21, 2023
carlossanlop
commented
Aug 23, 2023
Contributor
@jeffschwMSFT can we get your blessing? |
jeffschwMSFT
approved these changes
Aug 23, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. once ready this can be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #90799 to release/8.0
/cc @EgorBo
Customer Impact
No impact, these config knobs were not yet surfaced, but in my previous attempt I didn't figure out there are existing config knobs for tiered compilation and they have a different naming convention 😞 . e.g. https://github.com/dotnet/sdk/blob/62d3e897cce38a3df8d0ff4eb489a3f2e16f6dce/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L604-L611.
Testing
Risk
No risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.