') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix incomplete type errors when debugging in lldb/gdb (#90791) by a74nh · Pull Request #90873 · dotnet/runtime · GitHub
Skip to content

Fix incomplete type errors when debugging in lldb/gdb (#90791) - #90873

Merged
janvorli merged 1 commit into
dotnet:mainfrom
a74nh:lldb
Aug 21, 2023
Merged

Fix incomplete type errors when debugging in lldb/gdb (#90791)#90873
janvorli merged 1 commit into
dotnet:mainfrom
a74nh:lldb

Conversation

@a74nh

@a74nha74nh commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

When building with Clang-13 or newer, some types will fail to resolve in lldb and gdb.

@a74nh
Fix incomplete type errors when debugging in lldb/gdb
8dc00f0
When building with Clang-13 or newer, some types will fail to
resolve in lldb and gdb.
@ghostghost added area-Infrastructure-coreclr Only use for closed issues community-contribution Indicates that the PR has been added by a community member labels Aug 21, 2023
@ghost

ghost commented Aug 21, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

When building with Clang-13 or newer, some types will fail to resolve in lldb and gdb.

Author:a74nh
Assignees:-
Labels:

area-Infrastructure-coreclr, community-contribution

Milestone:-

@a74nha74nh changed the title Fix incomplete type errors when debugging in lldb/gdb #90791Fix incomplete type errors when debugging in lldb/gdb (#90791)Aug 21, 2023
@a74nh

a74nh commented Aug 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Tested on Ubuntu Linux, both X64 and Arm64, using clang-10, clang-12 and clang-14.
With all the above, could debug in both lldb and gdb.

Tried building with gcc, but got various build errors from elsewhere, so gave up on that. There should be no difference in the flags passed to gcc (uses -g)

@a74nh

a74nh commented Aug 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Fixes #90791

@a74nh

a74nh commented Aug 21, 2023

Copy link
Copy Markdown
ContributorAuthor

@janvorli

janvorli
janvorli approved these changes Aug 21, 2023
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
janvorli merged commit bf05d64 into dotnet:mainAug 21, 2023
mangod9 added a commit to mangod9/runtime that referenced this pull request Aug 23, 2023
@mangod9
Revert "Fix incomplete type errors when debugging in lldb/gdb (dotnet…
5ac0f8d
…#90873)"
This reverts commit bf05d64.
@ghostghost locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorlijanvorlijanvorli approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issuescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a74nh@janvorli