Skip to content

Upgrade our TFM to net9.0 - #90880

Merged
ViktorHofer merged 21 commits into
mainfrom
net90tfm
Aug 31, 2023
Merged

Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom
net90tfm

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Aug 21, 2023

Copy link
Copy Markdown
Member

Upgrade the TFM in the repo to net9.0

Drop support for net6.0 and net7.0

Follow-up to #90558

@ghost

ghost commented Aug 21, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Upgrade the TFM in the repo to net9.0

Drop support for net6.0 and net7.0

Follow-up to #90558

Author:jkoritzinsky
Assignees:-
Labels:

area-Infrastructure

Milestone:-

@jkoritzinskyjkoritzinsky mentioned this pull request Aug 21, 2023
Merged
ViktorHofer
ViktorHofer reviewed Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets Outdated
ViktorHofer
ViktorHofer reviewed Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets Outdated
ViktorHofer
ViktorHofer reviewed Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj Outdated
ViktorHofer
ViktorHofer reviewed Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj Outdated
ViktorHofer
ViktorHofer reviewed Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj Outdated
ViktorHofer
ViktorHofer reviewed Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj Outdated
ViktorHofer
ViktorHofer reviewed Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot mentioned this pull request Aug 22, 2023
Closed
@MihaZupanMihaZupan mentioned this pull request Aug 23, 2023
Closed
@jkoritzinsky

jkoritzinsky commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.

@radical

radical commented Aug 23, 2023

Copy link
Copy Markdown
Member

@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.

Sure, I can take a look later today.

ViktorHofer
ViktorHofer reviewed Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj Outdated
<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>

@ViktorHoferViktorHoferAug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?

@radicalradicalAug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.

ViktorHofer
ViktorHofer reviewed Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj
Comment on lines +19 to +23
<!--
The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
-->
<IsTrimmable>false</IsTrimmable>

@ViktorHoferViktorHoferAug 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.

@radical

radical commented Aug 24, 2023

Copy link
Copy Markdown
Member

@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.

Sure, I can take a look later today.

I'll have to dig in tomorrow.

@radical

radical commented Aug 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".

I'm working on this in #91105 , so it doesn't disturb work on this PR.

ViktorHofer added a commit to dotnet/arcade that referenced this pull request Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer mentioned this pull request Aug 25, 2023
Merged
1 task
@radicalradical mentioned this pull request Aug 30, 2023
Closed
@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot mentioned this pull request Aug 31, 2023
Closed
This was referenced Aug 31, 2023
Open
Closed
@jkoritzinsky
jkoritzinsky marked this pull request as ready for review August 31, 2023 16:24
@jkoritzinsky

jkoritzinsky commented Aug 31, 2023

Copy link
Copy Markdown
MemberAuthor

I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?

@ViktorHofer

ViktorHofer commented Aug 31, 2023

Copy link
Copy Markdown
Member

Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.

@ViktorHofer

ViktorHofer commented Aug 31, 2023

Copy link
Copy Markdown
Member

Actually, let's look at the baseline suppressions in a follow-up.

@ViktorHofer
ViktorHofer merged commit 85fa924 into mainAug 31, 2023
@ViktorHofer
ViktorHofer deleted the net90tfm branch August 31, 2023 16:40
marek-safar
marek-safar reviewed Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

<PropertyGroup>
<NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
<NetCoreAppCurrent>net9.0</NetCoreAppCurrent>

@marek-safarmarek-safarSep 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?

@ViktorHoferViktorHoferSep 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.

@sbomersbomer mentioned this pull request Sep 1, 2023
Closed
@ViktorHoferViktorHofer added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 12, 2023
@ViktorHofer

ViktorHofer commented Sep 12, 2023

Copy link
Copy Markdown
Member

Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.

@ghostghost locked as resolved and limited conversation to collaborators Oct 12, 2023
@ericstjericstj added this to the 8.0.0 milestone Oct 16, 2023
@jkoritzinskyjkoritzinsky modified the milestones: 8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+1 more reviewer
@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Upgrade our TFM to net9.0 by jkoritzinsky · Pull Request #90880 · dotnet/runtime · GitHub
Skip to content
Upgrade our TFM to net9.0 - #90880
Merged
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Aug 31, 2023
Merged
Upgrade our TFM to net9.0#90880
ViktorHofer merged 21 commits into
mainfrom 
net90tfm
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Aug 21, 2023

Copy link


Copy Markdown

Member
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
@ghost
ghost
commented
Aug 21, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:-
@jkoritzinskyjkoritzinsky
mentioned this pull request
Aug 21, 2023
 Merged

ViktorHofer
ViktorHofer
reviewed
Aug 21, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadeng/targetingpacks.targets
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS-NativeAOT/Program.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated

ViktorHofer
ViktorHofer
reviewed
Aug 22, 2023
View reviewed changes
Comment threadsrc/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 22, 2023

Closed

@MihaZupanMihaZupan
mentioned this pull request
Aug 23, 2023

Closed

@jkoritzinsky
jkoritzinsky
commented
Aug 23, 2023

Copy link


Copy Markdown

MemberAuthor
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
@radical
radical
commented
Aug 23, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj
Outdated

<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
 <PropertyGroup>
 <TargetFramework>net8.0</TargetFramework>
 <TargetFramework>net9.0</TargetFramework>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?
@radicalradicalAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.
ViktorHofer
ViktorHofer
reviewed
Aug 24, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj

Comment on lines

+19
 to 
+23

 <!--
 The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
 We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
 -->
 <IsTrimmable>false</IsTrimmable>
@ViktorHoferViktorHoferAug 24, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
@radical
radical
commented
Aug 24, 2023

Copy link


Copy Markdown

Member
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.
Sure, I can take a look later today.
I'll have to dig in tomorrow.
@radical
radical
commented
Aug 25, 2023•

edited

Loading

Copy link


Copy Markdown

Member
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".
I'm working on this in #91105 , so it doesn't disturb work on this PR.
ViktorHofer added a commit
to dotnet/arcade
that referenced
this pull request
Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce
Follow-up on dotnet/runtime#90880
These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.
Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHoferViktorHofer
mentioned this pull request
Aug 25, 2023
 Merged

1 task
@radicalradical
mentioned this pull request
Aug 30, 2023

Closed

@radical
Disable non-wasm build tests
e070989
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 31, 2023

Closed


This was referenced Aug 31, 2023

Open


Closed

@jkoritzinsky
jkoritzinsky
marked this pull request as ready for review
August 31, 2023 16:24
@jkoritzinsky
jkoritzinsky
commented
Aug 31, 2023

Copy link


Copy Markdown

MemberAuthor
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.
@ViktorHofer
ViktorHofer
commented
Aug 31, 2023

Copy link


Copy Markdown

Member
Actually, let's look at the baseline suppressions in a follow-up.
@ViktorHofer
ViktorHofer
merged commit 85fa924
into
mainAug 31, 2023
@ViktorHofer
ViktorHofer
deleted the

net90tfm

branch
August 31, 2023 16:40
marek-safar
marek-safar
reviewed
Sep 1, 2023
View reviewed changes
Comment threadsrc/installer/tests/Assets/TestUtils/TestProjects.props

 <PropertyGroup>
 <NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
 <NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
@marek-safarmarek-safarSep 1, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?
@ViktorHoferViktorHoferSep 1, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.
@sbomersbomer
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHoferViktorHofer
added
the 
needs-breaking-change-doc-created
Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
label
Sep 12, 2023
@ViktorHofer
ViktorHofer
commented
Sep 12, 2023

Copy link


Copy Markdown

Member
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 12, 2023
@ericstjericstj
added this to the 8.0.0 milestone
Oct 16, 2023
@jkoritzinskyjkoritzinsky
modified the milestones:
8.0.0, 9.0.0Oct 16, 2023
@ericstjericstj
added
the 
breaking-change
Issue or PR that represents a breaking API or functional change over a previous release.
label
Mar 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@ViktorHoferViktorHoferViktorHofer approved these changes
@radicalradicalAwaiting requested review from radical
@ericstjericstjAwaiting requested review from ericstj
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructurebreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jkoritzinsky@radical@ViktorHofer@marek-safar@kasperk81@ericstj@fanyang-mono