Skip to content

[Docs][tests] Add Mono Profiled AOT Functional Test and doc - #90959

Merged
mdh1418 merged 5 commits into
dotnet:mainfrom
mdh1418:mono_profiled_aot_story
Aug 24, 2023
Merged

[Docs][tests] Add Mono Profiled AOT Functional Test and doc#90959
mdh1418 merged 5 commits into
dotnet:mainfrom
mdh1418:mono_profiled_aot_story

Conversation

@mdh1418

@mdh1418mdh1418 commented Aug 22, 2023

Copy link
Copy Markdown
Member

This PR looks to add documentation surrounding Mono's dotnet-pgo based Profiled AOT story enabled through #69512. It also adds an Android functional test to test the Mono AOT Compiler ingesting a .mibc profile and a .nettrace.

@ghostghost assigned mdh1418Aug 22, 2023
@ghost

ghost commented Aug 22, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR looks to add documentation surrounding Mono's dotnet-pgo based Profiled AOT story enabled through #69512. It also adds an Android functional test to test the Mono AOT Compiler ingesting a .mibc profile and a .nettrace.

Author:mdh1418
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

akoeplinger
akoeplinger approved these changes Aug 23, 2023
View reviewed changes
Comment threadsrc/tests/FunctionalTests/Android/Device_Emulator/AOT_PROFILED/README.md Outdated
@@ -0,0 +1 @@
See [Profiled Ahead-Of-Time Compilation on Mono](https://github.com/dotnet/runtime/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test) No newline at end of file

@akoeplingerakoeplingerAug 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that link won't work since it's missing the branch name. Instead you can just use a relative link:

Suggested change
See [Profiled Ahead-Of-Time Compilation on Mono](https://github.com/dotnet/runtime/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test)
See [Profiled Ahead-Of-Time Compilation on Mono](/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test)

Comment thread...lTests/Android/Device_Emulator/AOT_PROFILED/Android.Device_Emulator.Aot_Profiled.Test.csproj Outdated

<!-- Profiled AOT with .mibc-->
<PropertyGroup>
<ProfiledAOTProfilePaths>$(MSBuildThisFileDirectory)\adeapt.mibc</ProfiledAOTProfilePaths>

@akoeplingerakoeplingerAug 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to call this just test.mibc and test.nettrace so it is clearer that these are test assets.

@mdh1418

mdh1418 commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-android

@azure-pipelines

azure-pipelinesBot commented Aug 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418

mdh1418 commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-android

@azure-pipelines

azure-pipelinesBot commented Aug 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
mdh1418force-pushed the mono_profiled_aot_story branch from 4dc3a06 to 695e526CompareAugust 23, 2023 19:52
@mdh1418

mdh1418 commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-android

@azure-pipelines

azure-pipelinesBot commented Aug 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 23, 2023
Closed
Closed
Closed
@mdh1418

mdh1418 commented Aug 24, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Test failure is issue #88843

@mdh1418
mdh1418 merged commit fd6d5fd into dotnet:mainAug 24, 2023
@mdh1418mdh1418 mentioned this pull request Sep 11, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2023
@mdh1418
mdh1418 deleted the mono_profiled_aot_story branch June 24, 2025 16:06
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@steveisoksteveisokAwaiting requested review from steveisok
@lambdageeklambdageekAwaiting requested review from lambdageek
@lateralusXlateralusXAwaiting requested review from lateralusX

Assignees

@mdh1418mdh1418

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdh1418@akoeplinger