Uh oh!
There was an error while loading. Please reload this page.
[release/8.0] [NativeAOT] Fix --make-repro-path ILC option - #90989
Merged
Conversation
jkotas
approved these changes
Aug 23, 2023
carlossanlop
commented
Aug 23, 2023
Contributor
@jeffschwMSFT do we have your blessing? |
jeffschwMSFT
approved these changes
Aug 23, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we can merge once ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #90935 to release/8.0
/cc @jkotas@ivanpovazan
Customer Impact
--make-repro-pathcommand line option got broken by upgrading System.CommandLine package. It prevents customers from sending us self-contained repros for native AOT compiler issues.Testing
Manual test. We will consider adding automated test to SDK.
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.