') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add regression test for GitHub issue #74132 by trylek · Pull Request #91009 · dotnet/runtime · GitHub
Skip to content

Add regression test for GitHub issue #74132 - #91009

Closed
trylek wants to merge 1 commit into
dotnet:mainfrom
trylek:74132
Closed

Add regression test for GitHub issue #74132#91009
trylek wants to merge 1 commit into
dotnet:mainfrom
trylek:74132

Conversation

@trylek

@trylektrylek commented Aug 23, 2023

Copy link
Copy Markdown
Member

I have verified locally that the problem described in the issue no longer exists in .NET 8 RC1, the bug was probably fixed earlier this year by David Wrighton. I think the regression test described in the issue is useful so I'm proposing to merge it in; this PR will then close the issue.

Fixes: #74132

Thanks

Tomas

@trylek
Add regression test for GitHub issuedotnet#74132
3f887ce
I have verified locally that the problem described in the issue
no longer exists in .NET 8 RC1, the bug was probably fixed earlier
this year by David Wrighton. I think the regression test described
in the issue is useful so I'm proposing to merge it in; this PR
will then close the issue.
Fixes: dotnet#74132
Thanks
Tomas
@trylektrylek added this to the 9.0.0 milestone Aug 23, 2023
@trylek
trylek requested a review from ivdiazsaAugust 23, 2023 19:24
@ghostghost assigned trylekAug 23, 2023
@ivdiazsa

ivdiazsa commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

I assume the specific-issue regression tests will remain in the old testing system? As in, the executable directly rather than the Fact/Theory thingies?

jkotas
jkotas reviewed Aug 23, 2023
View reviewed changes
Comment threadsrc/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_74132.cs

using System;

// This regression test tracks the issue where GetInterfaceMap returns incorrect

@jkotasjkotasAug 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is regression test for a BCL API behavior. It would be more appropriate to add it under src\libraries, similar to #90518 - if this case is not covered by the tests being added already.

@trylektrylekAug 23, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for pointing that out, in such case I'll abandon this PR and I'll follow up on the #90518 PR thread.

@trylek

trylek commented Aug 23, 2023

Copy link
Copy Markdown
MemberAuthor

Closing per JanK's PR feedback.

@trylektrylek closed this Aug 23, 2023
@build-analysisbuild-analysisBot mentioned this pull request Aug 23, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@ivdiazsaivdiazsaAwaiting requested review from ivdiazsa

Assignees

@trylektrylek

Labels

area-VM-coreclr

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

InterfaceMap returns non-GenericMethodDefinition for static abstract interface generic methods on the target type

3 participants

@trylek@ivdiazsa@jkotas