Uh oh!
There was an error while loading. Please reload this page.
[release/8.0] JIT: Skip Create(ToScalar(Dot(...))) transformation on mismatched types - #91089
Merged
Merged
Conversation
ghost
commented
Aug 24, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #91063 to release/8.0 /cc @jakobbotsch Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
tannergooding
approved these changes
Aug 25, 2023
jeffschwMSFT
approved these changes
Aug 25, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. once ready this pr can be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #91063 to release/8.0
/cc @jakobbotsch
Customer Impact
The JIT may produce invalid internal IR that can lead to JIT crashes for a specific C# pattern
Vector2.Lerp(<arg>, <arg>, Vector128.Dot(...)).Testing
Regression test included.
Risk
Low. Skip a transformation in the specific case.