Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtschuster merged 5 commits into from
Aug 25, 2023
Merged

Recommend [In] and [Out] attributes on array parameters #91094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b58abc5
wip
jtschuster Aug 21, 2023
ee1b3bb
wip
jtschuster Aug 22, 2023
b686622
Added tests
jtschuster Aug 23, 2023
b03475c
Added LibraryImport tests
jtschuster Aug 24, 2023
89f14b9
Cleaned up some code
jtschuster Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/project/list-of-diagnostics.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down
1 change: 1 addition & 0 deletions .../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
{ IsFatal: false } => null,
{ TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
{ TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down
11 changes: 11 additions & 0 deletions ...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
DiagnosticSeverity.Info,
isEnabledByDefault: true);

/// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
new DiagnosticDescriptor(
Ids.NotRecommendedGeneratedComInterfaceUsage,
GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
Category,
DiagnosticSeverity.Info,
isEnabledByDefault: true,
helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

/// <summary>
/// Report diagnostic for invalid configuration for string marshalling.
/// </summary>
Expand Down
25 changes: 23 additions & 2 deletions src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
<value>[In] and [Out] attributes</value>
</data>
<data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
<value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
<value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
</data>
<data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
<value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
</data>
<data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
<value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
</data>
<data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
<value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
<data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
<value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
</data>
</root>
<data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
<value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
</data>
<data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
<value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
</data>
<data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
<value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
</data>
<data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
<value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
</data>
<data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
<value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
</data>
</root>
39 changes: 37 additions & 2 deletions src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
<target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
<note />
</trans-unit>
<trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
<source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
<target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
<note />
</trans-unit>
<trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
<source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
<target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
<note />
</trans-unit>
<trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
<source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
<target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
<target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
<note />
</trans-unit>
<trans-unit id="InAttributeNotSupportedOnByValueParameters">
<source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
<target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
<note />
</trans-unit>
<trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
<source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
<target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
<target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
<note />
</trans-unit>
<trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
<source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
<target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
<note />
</trans-unit>
<trans-unit id="InOutAttributes">
<source>[In] and [Out] attributes</source>
<target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
<target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
<note />
</trans-unit>
<trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
<source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
<target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
<note />
</trans-unit>
<trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
<source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
<target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
<note />
</trans-unit>
<trans-unit id="LinearCollectionElementTypesMustMatchDescription">
<source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
<target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
<note />
</trans-unit>
<trans-unit id="OutAttributeNotSupportedOnByValueParameters">
<source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
<target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
<source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
<target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
<note />
</trans-unit>
<trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
<target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
<note />
</trans-unit>
<trans-unit id="PreferExplicitInOutAttributesOnArrays">
<source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
<target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
<note />
</trans-unit>
<trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
<source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
<target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down
39 changes: 37 additions & 2 deletions src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
<target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
<note />
</trans-unit>
<trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
<source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
<target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
<note />
</trans-unit>
<trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
<source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
<target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
<note />
</trans-unit>
<trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
<source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
<target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
<target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
<note />
</trans-unit>
<trans-unit id="InAttributeNotSupportedOnByValueParameters">
<source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
<target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
<note />
</trans-unit>
<trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
<source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
<target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
<target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
<note />
</trans-unit>
<trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
<source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
<target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
<note />
</trans-unit>
<trans-unit id="InOutAttributes">
<source>[In] and [Out] attributes</source>
<target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
<target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
<note />
</trans-unit>
<trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
<source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
<target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
<note />
</trans-unit>
<trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
<source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
<target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
<note />
</trans-unit>
<trans-unit id="LinearCollectionElementTypesMustMatchDescription">
<source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
<target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
<note />
</trans-unit>
<trans-unit id="OutAttributeNotSupportedOnByValueParameters">
<source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
<target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
<source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
<target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
<note />
</trans-unit>
<trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
<target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
<note />
</trans-unit>
<trans-unit id="PreferExplicitInOutAttributesOnArrays">
<source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
<target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
<note />
</trans-unit>
<trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
<source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
<target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Recommend [In] and [Out] attributes on array parameters#91094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jtschuster
merged 5 commits into

from

Aug 25, 2023
 Merged


Recommend [In] and [Out] attributes on array parameters
#91094
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
b58abc5

wip


jtschuster Aug 21, 2023
ee1b3bb

wip


jtschuster Aug 22, 2023
b686622

Added tests


jtschuster Aug 23, 2023
b03475c

Added LibraryImport tests


jtschuster Aug 24, 2023
89f14b9

Cleaned up some code


jtschuster Aug 24, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
docs/project/list-of-diagnostics.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -208,7 +208,7 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1089`__ | _`SYSLIB1070`-`SYSLIB1089` reserved for System.Runtime.InteropServices.JavaScript.JSImportGenerator._ |
| __`SYSLIB1090`__ | Invalid 'GeneratedComInterfaceAttribute' usage |
| __`SYSLIB1091`__ | Method is declared in different partial declaration than the 'GeneratedComInterface' attribute. |
| __`SYSLIB1092`__ | 'GenerateComInterfaceAttribute' usage not recommended. See aka.ms/GeneratedComInterfaceUsage for recommended usage. |
| __`SYSLIB1092`__ | Usage of '[LibraryImport|GeneratedComInterface]' does not follow recommendation. See aka.ms/[LibraryImport|GeneratedComInterface]Usage for best practices. |
| __`SYSLIB1093`__ | Analysis for COM interface generation has failed |
| __`SYSLIB1094`__ | The base COM interface failed to generate source. Code will not be generated for this interface. |
| __`SYSLIB1095`__ | Invalid 'GeneratedComClassAttribute' usage |
Expand Down

1 change: 1 addition & 0 deletions
.../System.Runtime.InteropServices/gen/ComInterfaceGenerator/DiagnosticDescriptorProvider.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ internal sealed class DiagnosticDescriptorProvider : IDiagnosticDescriptorProvid
 GeneratorDiagnostic.NotSupported { NotSupportedDetails: not null, TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupportedWithDetails,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.UnnecessaryParameterMarshallingInfo,
 GeneratorDiagnostic.UnnecessaryData { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.UnnecessaryReturnMarshallingInfo,
 GeneratorDiagnostic.NotRecommended => GeneratorDiagnostics.GeneratedComInterfaceUsageDoesNotFollowBestPractices,
 { IsFatal: false } => null,
 { TypePositionInfo.IsManagedReturnPosition: true } => GeneratorDiagnostics.ReturnTypeNotSupported,
 { TypePositionInfo.IsManagedReturnPosition: false } => GeneratorDiagnostics.ParameterTypeNotSupported,
Expand Down

11 changes: 11 additions & 0 deletions
...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -485,6 +485,17 @@ public class Ids
 DiagnosticSeverity.Info,
 isEnabledByDefault: true);

 /// <inheritdoc cref="SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails"/>
 public static readonly DiagnosticDescriptor GeneratedComInterfaceUsageDoesNotFollowBestPractices =
 new DiagnosticDescriptor(
 Ids.NotRecommendedGeneratedComInterfaceUsage,
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesTitle)),
 GetResourceString(nameof(SR.ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails)),
 Category,
 DiagnosticSeverity.Info,
 isEnabledByDefault: true,
 helpLinkUri: "aka.ms/GeneratedComInterfaceUsage");

 /// <summary>
 /// Report diagnostic for invalid configuration for string marshalling.
 /// </summary>
Expand Down

25 changes: 23 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/Strings.resx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -875,7 +875,13 @@
 <value>[In] and [Out] attributes</value>
 </data>
 <data name="OutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 <value>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</value>
 </data>
 <data name="InAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</value>
 </data>
 <data name="InOutAttributeNotSupportedOnByValueParameters" xml:space="preserve">
 <value>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</value>
 </data>
 <data name="ComMethodReturningIntWillBeOutParameterMessage" xml:space="preserve">
 <value>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</value>
Expand All@@ -889,4 +895,19 @@
 <data name="HResultTypeWillBeTreatedAsStructTitle" xml:space="preserve">
 <value>This type will be treated as a struct in the native signature, not as a native HRESULT</value>
 </data>
</root>
 <data name="PreferExplicitInOutAttributesOnArrays" xml:space="preserve">
 <value>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</value>
 </data>
 <data name="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesTitle" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations.</value>
 </data>
 <data name="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails" xml:space="preserve">
 <value>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</value>
 </data>
</root>

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.cs.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Hostování .NET COM s EnableComHosting nepodporuje rozhraní s generatedComInterfaceAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Vrácená hodnota ve spravované definici se při volání nespravované metody COM převede na parametr out. Pokud má být návratovou hodnotou kód HRESULT vrácený nespravovanou metodou COM, použijte u metody [PreserveSig].</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Atribut [In] není podporován, pokud není použit také atribut [Out]. Blittable arrays nelze zařadit pouze jako [In].</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Poskytnuté atributy „[In]“ a „[Out]“ u tohoto parametru se na tomto parametru nepodporují.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">atributy [In] a [Out]</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Neplatné použití atributu VirtualMethodIndexAttribute</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Typ prvku ReadOnlySpan vrácený GetManagedValuesSource musí být stejný, jako typ prvku vrácený GetManagedValuesDestination.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Typ {0}určuje, že podporuje zařazování ve směru „Out“, ale neposkytuje metodu ToManaged, která vrací spravovaný typ</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">GeneratedComInterfaceAttribute a GeneratedComClassAttribute vyžadují nebezpečný kód. Projekt se musí aktualizovat na &lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;.</target>
Expand Down

39 changes: 37 additions & 2 deletions
src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/Strings.de.xlf

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -147,6 +147,16 @@
 <target state="translated">Das .NET COM-Hosting mit "EnableComHosting" unterstützt keine Schnittstellen mit "GeneratedComInterfaceAttribute".</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="ComInterfaceUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'GeneratedComInterfaceAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="ComMethodReturningIntWillBeOutParameterMessage">
 <source>The return value in the managed definition will be converted to an 'out' parameter when calling the unmanaged COM method. If the return value is intended to be the HRESULT code returned by the unmanaged COM method, use '[PreserveSig]' on the method.</source>
 <target state="translated">Der Rückgabewert in der verwalteten Definition wird beim Aufrufen der nicht verwalteten COM-Methode in einen out-Parameter konvertiert. Wenn als Rückgabewert der von der nicht verwalteten COM-Methode zurückgegebene HRESULT-Code eingesetzt werden soll, verwenden Sie "[PreserveSig]" für die Methode.</target>
Expand DownExpand Up@@ -447,6 +457,11 @@
 <target state="new">This type will be treated as a struct in the native signature, not as a native HRESULT</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</source>
 <target state="new">The '[In]' attribute is only supported on array parameters. By-value parameters are considered read-only by default.</target>
 <note />
 </trans-unit>
 <trans-unit id="InAttributeNotSupportedWithoutOutBlittableArray">
 <source>The '[In]' attribute is not supported unless the '[Out]' attribute is also used. Blittable arrays cannot be marshalled as '[In]' only.</source>
 <target state="translated">Das [In]-Attribut wird nur unterstützt, wenn auch das [Out]-Attribut verwendet wird. Blittable-Arrays können nicht nur als "[In]" gemarshallt werden.</target>
Expand All@@ -467,6 +482,11 @@
 <target state="translated">Die angegebenen Attribute \"[In]\" und \"[Out]\" für diesen Parameter werden für diesen Parameter nicht unterstützt.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributeNotSupportedOnByValueParameters">
 <source>The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</source>
 <target state="new">The '[In]' and '[Out]' attributes are only supported on array parameters. Consider using the 'ref' keyword to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="InOutAttributes">
 <source>[In] and [Out] attributes</source>
 <target state="translated">[In]- und [Out]-Attribute</target>
Expand DownExpand Up@@ -702,6 +722,16 @@
 <target state="translated">Ungültige Verwendung von "VirtualMethodIndexAttribute"</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesMessageWithDetails">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations. {0}</target>
 <note />
 </trans-unit>
 <trans-unit id="LibraryImportUsageDoesNotFollowBestPracticesTitle">
 <source>The usage of 'LibraryImportAttribute' does not follow recommendations.</source>
 <target state="new">The usage of 'LibraryImportAttribute' does not follow recommendations.</target>
 <note />
 </trans-unit>
 <trans-unit id="LinearCollectionElementTypesMustMatchDescription">
 <source>The element type of the 'ReadOnlySpan' returned by 'GetManagedValuesSource' must be the same as the element type returned by 'GetManagedValuesDestination'.</source>
 <target state="translated">Der von \"GetManagedValuesSource\" zurückgegebene Elementtyp \"ReadOnlySpan\" muss mit dem Elementtyp identisch sein, der von \"GetManagedValuesDestination\" zurückgegeben wird.</target>
Expand DownExpand Up@@ -903,8 +933,8 @@
 <note />
 </trans-unit>
 <trans-unit id="OutAttributeNotSupportedOnByValueParameters">
 <source>The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The `[Out]` attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <source>The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</source>
 <target state="new">The '[Out]' attribute is only supported on array parameters. Consider using 'out' or 'ref' keywords to make the parameter mutable.</target>
 <note />
 </trans-unit>
 <trans-unit id="OutRequiresToManagedDescription">
Expand All@@ -917,6 +947,11 @@
 <target state="translated">Der Typ \"{0}\" gibt an, dass das Marshalling in der Out-Richtung unterstützt wird. Er stellt jedoch keine ToManaged-Methode bereit, die den verwalteten Typ zurückgibt.</target>
 <note />
 </trans-unit>
 <trans-unit id="PreferExplicitInOutAttributesOnArrays">
 <source>It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</source>
 <target state="new">It is recommended to use explicit '[In]' and '[Out]' attributes on array parameters.</target>
 <note />
 </trans-unit>
 <trans-unit id="RequiresAllowUnsafeBlocksDescriptionCom">
 <source>'GeneratedComInterfaceAttribute' and 'GeneratedComClassAttribute' require unsafe code. Project must be updated with '&lt;AllowUnsafeBlocks&gt;true&lt;/AllowUnsafeBlocks&gt;'.</source>
 <target state="translated">'GeneratedComInterfaceAttribute' und 'GeneratedComClassAttribute' erfordern unsicheren Code. Das Projekt muss mit '&lt;AllowUnsafeBlocks&gt;wahr&lt;/AllowUnsafeBlocks&gt;' aktualisiert werden.</target>
Expand Down
Loading