Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 1 commit into from
Aug 30, 2023
Merged

Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent #91160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
}).ConfigureAwait(false);
});
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
public async Task DefaultHandler_FakeServer_DefaultCredentials()
{
await LoopbackServer.CreateClientAndServerAsync(
async uri =>
{
HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
requestMessage.Version = new Version(1, 1);

HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
using (var client = new HttpClient(handler))
{
HttpResponseMessage response = await client.SendAsync(requestMessage);
Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
}
},
async server =>
{
await server.AcceptConnectionAsync(async connection =>
{
var authHeader = "WWW-Authenticate: NTLM\r\n";
await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
connection.CompleteRequestProcessing();
}).ConfigureAwait(false);
});
}
}
}
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
switch (clientOptions.Package)
{
case NegotiationInfoClass.NTLM:
return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

case NegotiationInfoClass.Negotiate:
return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down
26 changes: 17 additions & 9 deletions src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
public override IIdentity RemoteIdentity => throw new InvalidOperationException();
public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
{
Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

_credential = clientOptions.Credential;
if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
{
// NTLM authentication is not possible with default credentials which are no-op
throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
}

_spn = clientOptions.TargetName;
_channelBinding = clientOptions.Binding;
_protectionLevel = clientOptions.RequiredProtectionLevel;

if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
}

public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
{
Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||

@dotMortendotMortenAug 26, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.

@filipnavarafilipnavaraAug 26, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.

@dotMortendotMortenAug 26, 2023•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.

@filipnavarafilipnavaraAug 26, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.

string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
{
// NTLM authentication is not possible with default credentials which are no-op
if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
}

return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
}

public override void Dispose()
{
// Dispose of the state
Expand Down
11 changes: 1 addition & 10 deletions src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
{
// Abandon the optimistic path and restart with a new mechanism
_optimisticMechanism?.Dispose();
_mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
{
Package = requestedPackage,
Credential = _clientOptions.Credential,
TargetName = _clientOptions.TargetName,
Binding = _clientOptions.Binding,
RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
});
_mechanism = CreateMechanismForPackage(requestedPackage);
}

_optimisticMechanism = null;
Expand Down
72 changes: 29 additions & 43 deletions src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
switch (clientOptions.Package)
{
case NegotiationInfoClass.NTLM:
return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

case NegotiationInfoClass.Negotiate:
return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
{
return new UnixNegotiateAuthenticationPal(clientOptions);
}
catch (Win32Exception)
catch (Interop.NetSecurityNative.GssApiException gex)
{
return new UnsupportedNegotiateAuthenticationPal(clientOptions);
}
catch (PlatformNotSupportedException)
{
return new UnsupportedNegotiateAuthenticationPal(clientOptions);
if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
{
statusCode = NegotiateAuthenticationStatusCode.Unsupported;
}
return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
}
catch (EntryPointNotFoundException)
{
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
{
return new UnixNegotiateAuthenticationPal(serverOptions);
}
catch (Win32Exception)
catch (Interop.NetSecurityNative.GssApiException gex)
{
return new UnsupportedNegotiateAuthenticationPal(serverOptions);
}
catch (PlatformNotSupportedException)
{
return new UnsupportedNegotiateAuthenticationPal(serverOptions);
if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
{
statusCode = NegotiateAuthenticationStatusCode.Unsupported;
}
return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
}
catch (EntryPointNotFoundException)
{
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
{
if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
_credentialsHandle = AcquireDefaultCredential();

if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
{
// NTLM authentication is not possible with default credentials which are no-op
throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
}
if (string.IsNullOrEmpty(_spn))
{
throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
}

_credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
}
else
{
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
{
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
else
{
// Native shim currently supports only NTLM, Negotiate and Kerberos
throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
}
}

private SafeGssCredHandle AcquireDefaultCredential()
{
try
{
return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
}
catch (Exception ex)
{
if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

// NOTE: We throw PlatformNotSupportedException which is caught in
// NegotiateAuthenticationPal.Create and transformed into instantiation of
// UnsupportedNegotiateAuthenticationPal.
throw new PlatformNotSupportedException(ex.Message, ex);
throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
}
}

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

return SafeGssCredHandle.Create(username, password, _packageType);
}
catch (Exception ex)
catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
{
if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

// NOTE: We throw PlatformNotSupportedException which is caught in
// NegotiateAuthenticationPal.Create and transformed into instantiation of
// UnsupportedNegotiateAuthenticationPal.
throw new PlatformNotSupportedException(ex.Message, ex);
throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
}
}

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
}

// https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
{
switch (exception.MajorStatus)
{
Expand Down
9 changes: 6 additions & 3 deletions src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
{
private string _package;
private string? _targetName;
private NegotiateAuthenticationStatusCode _statusCode;

public override bool IsAuthenticated => false;
public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
public override IIdentity RemoteIdentity => throw new InvalidOperationException();
public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
{
_package = clientOptions.Package;
_targetName = clientOptions.TargetName;
_statusCode = statusCode;
}

public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
{
_package = serverOptions.Package;
_statusCode = statusCode;
}

public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
{
statusCode = NegotiateAuthenticationStatusCode.Unsupported;
statusCode = _statusCode;
return null;
}

Expand Down
12 changes: 12 additions & 0 deletions src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
}

[Fact]
[SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
{
NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
// Assert.DoesNotThrow
NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
NegotiateAuthenticationStatusCode statusCode;
negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
}

[Fact]
public void NtlmProtocolExampleTest()
{
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent#91160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wfurt
merged 1 commit into

from

Aug 30, 2023
 Merged


Make handling of DefaultCredentials in NegotiateAuthentication/SocketsHttpHandler more consistent
#91160
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


28 changes: 28 additions & 0 deletions
src/libraries/System.Net.Http/tests/FunctionalTests/NtAuthTests.FakeServer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -139,5 +139,33 @@ await server.AcceptConnectionAsync(async connection =>
 }).ConfigureAwait(false);
 });
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Windows, "DefaultCredentials are unsupported for NTLM on Unix / Managed implementation")]
 public async Task DefaultHandler_FakeServer_DefaultCredentials()
 {
 await LoopbackServer.CreateClientAndServerAsync(
 async uri =>
 {
 HttpRequestMessage requestMessage = new HttpRequestMessage(HttpMethod.Get, uri);
 requestMessage.Version = new Version(1, 1);

 HttpMessageHandler handler = new HttpClientHandler() { Credentials = CredentialCache.DefaultCredentials };
 using (var client = new HttpClient(handler))
 {
 HttpResponseMessage response = await client.SendAsync(requestMessage);
 Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
 }
 },
 async server =>
 {
 await server.AcceptConnectionAsync(async connection =>
 {
 var authHeader = "WWW-Authenticate: NTLM\r\n";
 await connection.SendResponseAsync(HttpStatusCode.Unauthorized, authHeader).ConfigureAwait(false);
 connection.CompleteRequestProcessing();
 }).ConfigureAwait(false);
 });
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Managed.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions);
Expand Down

26 changes: 17 additions & 9 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -218,24 +218,32 @@ private unsafe struct NtChallengeResponse
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

public ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
private ManagedNtlmNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 _credential = clientOptions.Credential;
 if (string.IsNullOrWhiteSpace(_credential.UserName) || string.IsNullOrWhiteSpace(_credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 }

 _spn = clientOptions.TargetName;
 _channelBinding = clientOptions.Binding;
 _protectionLevel = clientOptions.RequiredProtectionLevel;

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"package={clientOptions.Package}, spn={_spn}, requiredProtectionLevel={_protectionLevel}");
 }

 public static new NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOptions clientOptions)
 {
 Debug.Assert(clientOptions.Package == NegotiationInfoClass.NTLM);

 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
@dotMortendotMortenAug 26, 2023

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an && between username and password.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always || in all versions on .NET. It's not like empty user name with non-empty password, or vice versa, makes any sense.
@dotMortendotMortenAug 26, 2023•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not? I've seen services that only require password with empty username.
@filipnavarafilipnavaraAug 26, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's valid in NTLM or Kerberos. It's valid in Basic authentication.
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 // NTLM authentication is not possible with default credentials which are no-op
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, SR.net_ntlm_not_possible_default_cred);
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, NegotiateAuthenticationStatusCode.UnknownCredentials);
 }

 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 }

 public override void Dispose()
 {
 // Dispose of the state
Expand Down

11 changes: 1 addition & 10 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedSpnego.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -303,16 +303,7 @@ private IEnumerable<KeyValuePair<string, string>> EnumerateMechanisms()
 {
 // Abandon the optimistic path and restart with a new mechanism
 _optimisticMechanism?.Dispose();
 _mechanism = NegotiateAuthenticationPal.Create(new NegotiateAuthenticationClientOptions
 {
 Package = requestedPackage,
 Credential = _clientOptions.Credential,
 TargetName = _clientOptions.TargetName,
 Binding = _clientOptions.Binding,
 RequiredProtectionLevel = _clientOptions.RequiredProtectionLevel,
 RequireMutualAuthentication = _clientOptions.RequireMutualAuthentication,
 AllowedImpersonationLevel = _clientOptions.AllowedImpersonationLevel,
 });
 _mechanism = CreateMechanismForPackage(requestedPackage);
 }

 _optimisticMechanism = null;
Expand Down

72 changes: 29 additions & 43 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 switch (clientOptions.Package)
 {
 case NegotiationInfoClass.NTLM:
 return new ManagedNtlmNegotiateAuthenticationPal(clientOptions);
 return ManagedNtlmNegotiateAuthenticationPal.Create(clientOptions);

 case NegotiationInfoClass.Negotiate:
 return new ManagedSpnegoNegotiateAuthenticationPal(clientOptions, supportKerberos: true);
Expand All@@ -42,13 +42,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationClientOpt
 {
 return new UnixNegotiateAuthenticationPal(clientOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(clientOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(clientOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand All@@ -63,13 +65,15 @@ public static NegotiateAuthenticationPal Create(NegotiateAuthenticationServerOpt
 {
 return new UnixNegotiateAuthenticationPal(serverOptions);
 }
 catch (Win32Exception)
 catch (Interop.NetSecurityNative.GssApiException gex)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 }
 catch (PlatformNotSupportedException)
 {
 return new UnsupportedNegotiateAuthenticationPal(serverOptions);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(null, gex);
 NegotiateAuthenticationStatusCode statusCode = UnixNegotiateAuthenticationPal.GetErrorCode(gex);
 if (statusCode <= NegotiateAuthenticationStatusCode.GenericFailure)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 }
 return new UnsupportedNegotiateAuthenticationPal(serverOptions, statusCode);
 }
 catch (EntryPointNotFoundException)
 {
Expand DownExpand Up@@ -184,22 +188,25 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clien

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (clientOptions.Credential == CredentialCache.DefaultCredentials ||
 if (clientOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(clientOptions.Credential.Password))
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, "using DefaultCredentials");
 _credentialsHandle = AcquireDefaultCredential();

 if (_packageType == Interop.NetSecurityNative.PackageType.NTLM)
 {
 // NTLM authentication is not possible with default credentials which are no-op
 throw new PlatformNotSupportedException(SR.net_ntlm_not_possible_default_cred);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_ntlm_not_possible_default_cred);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_NO_CRED, 0, SR.net_ntlm_not_possible_default_cred);
 }
 if (string.IsNullOrEmpty(_spn))
 {
 throw new PlatformNotSupportedException(SR.net_nego_not_supported_empty_target_with_defaultcreds);
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0, SR.net_nego_not_supported_empty_target_with_defaultcreds);
 }

 _credentialsHandle = SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 else
 {
Expand DownExpand Up@@ -229,7 +236,7 @@ public UnixNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serve

 if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this, $"Peer SPN-> '{_spn}'");

 if (serverOptions.Credential == CredentialCache.DefaultCredentials ||
 if (serverOptions.Credential == CredentialCache.DefaultNetworkCredentials ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.UserName) ||
 string.IsNullOrWhiteSpace(serverOptions.Credential.Password))
 {
Expand DownExpand Up@@ -462,24 +469,7 @@ private static Interop.NetSecurityNative.PackageType GetPackageType(string packa
 else
 {
 // Native shim currently supports only NTLM, Negotiate and Kerberos
 throw new PlatformNotSupportedException(SR.net_securitypackagesupport);
 }
 }

 private SafeGssCredHandle AcquireDefaultCredential()
 {
 try
 {
 return SafeGssCredHandle.Create(string.Empty, string.Empty, _packageType);
 }
 catch (Exception ex)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_UNAVAILABLE, 0);
 }
 }

Expand DownExpand Up@@ -511,14 +501,10 @@ private SafeGssCredHandle AcquireCredentialsHandle(NetworkCredential credential)

 return SafeGssCredHandle.Create(username, password, _packageType);
 }
 catch (Exception ex)
 catch (Exception ex) when (ex is not Interop.NetSecurityNative.GssApiException)
 {
 if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, ex);

 // NOTE: We throw PlatformNotSupportedException which is caught in
 // NegotiateAuthenticationPal.Create and transformed into instantiation of
 // UnsupportedNegotiateAuthenticationPal.
 throw new PlatformNotSupportedException(ex.Message, ex);
 throw new Interop.NetSecurityNative.GssApiException(Interop.NetSecurityNative.Status.GSS_S_BAD_NAME, 0);
 }
 }

Expand DownExpand Up@@ -753,7 +739,7 @@ private NegotiateAuthenticationStatusCode AcceptSecurityContext(
 }

 // https://www.gnu.org/software/gss/reference/gss.pdf (page 25)
private static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
internal static NegotiateAuthenticationStatusCode GetErrorCode(Interop.NetSecurityNative.GssApiException exception)
 {
 switch (exception.MajorStatus)
 {
Expand Down

9 changes: 6 additions & 3 deletions
src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unsupported.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 {
 private string _package;
 private string? _targetName;
 private NegotiateAuthenticationStatusCode _statusCode;

 public override bool IsAuthenticated => false;
 public override bool IsSigned => false;
Expand All@@ -25,15 +26,17 @@ internal sealed class UnsupportedNegotiateAuthenticationPal : NegotiateAuthentic
 public override IIdentity RemoteIdentity => throw new InvalidOperationException();
 public override System.Security.Principal.TokenImpersonationLevel ImpersonationLevel => System.Security.Principal.TokenImpersonationLevel.Impersonation;

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationClientOptions clientOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = clientOptions.Package;
 _targetName = clientOptions.TargetName;
 _statusCode = statusCode;
 }

 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions)
 public UnsupportedNegotiateAuthenticationPal(NegotiateAuthenticationServerOptions serverOptions, NegotiateAuthenticationStatusCode statusCode = NegotiateAuthenticationStatusCode.Unsupported)
 {
 _package = serverOptions.Package;
 _statusCode = statusCode;
 }

 public override void Dispose()
Expand All@@ -42,7 +45,7 @@ public override void Dispose()

 public override byte[]? GetOutgoingBlob(ReadOnlySpan<byte> incomingBlob, out NegotiateAuthenticationStatusCode statusCode)
 {
 statusCode = NegotiateAuthenticationStatusCode.Unsupported;
 statusCode = _statusCode;
 return null;
 }

Expand Down

12 changes: 12 additions & 0 deletions
src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,18 @@ public void Package_Unsupported_NTLM()
 Assert.Equal(NegotiateAuthenticationStatusCode.Unsupported, statusCode);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Windows, "The test is specific to GSSAPI / Managed implementations of NegotiateAuthentication")]
 public void DefaultNetworkCredentials_NTLM_DoesNotThrow()
 {
 NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = CredentialCache.DefaultNetworkCredentials, TargetName = "HTTP/foo" };
 // Assert.DoesNotThrow
 NegotiateAuthentication negotiateAuthentication = new NegotiateAuthentication(clientOptions);
 NegotiateAuthenticationStatusCode statusCode;
 negotiateAuthentication.GetOutgoingBlob((byte[]?)null, out statusCode);
 Assert.Equal(NegotiateAuthenticationStatusCode.UnknownCredentials, statusCode);
 }

 [Fact]
 public void NtlmProtocolExampleTest()
 {
Expand Down