Skip to content

[release/8.0] [mono] Enable System.IO.Hashing tests on ios and disable them on tvos - #91195

Merged
carlossanlop merged 1 commit into
release/8.0from
backport/pr-90984-to-release/8.0
Aug 28, 2023
Merged

[release/8.0] [mono] Enable System.IO.Hashing tests on ios and disable them on tvos#91195
carlossanlop merged 1 commit into
release/8.0from
backport/pr-90984-to-release/8.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

Backport of #90984 to release/8.0

/cc @ivanpovazan

Customer Impact

This change contributes towards having a green runtime-extra-platforms pipeline by keeping the same test coverage on iOS-like platforms.

Testing

This can be verified by inspecting whether System.IO.Hashing.Tests have been ran and passed as part of ios-arm64 Release AllSubsets_Mono job (e.g., https://helix.dot.net/api/jobs/a48cda4a-ca96-46e6-a3c0-43c11ea1a441/workitems?api-version=2019-06-17).
Additionally, it should be verified that the tvos-arm64 Release AllSubsets_Mono is not running the System.IO.Hashing.Tests tests

Risk

This is a CI infrastructure change with low risk.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90984 to release/8.0

/cc @ivanpovazan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90984 to release/8.0

/cc @ivanpovazan

Customer Impact

This change contributes towards having a green runtime-extra-platforms pipeline by keeping the same test coverage on iOS-like platforms.

Testing

This can be verified by inspecting whether System.IO.Hashing.Tests have been ran and passed as part of ios-arm64 Release AllSubsets_Mono job (e.g., https://helix.dot.net/api/jobs/a48cda4a-ca96-46e6-a3c0-43c11ea1a441/workitems?api-version=2019-06-17).
Additionally, it should be verified that the tvos-arm64 Release AllSubsets_Mono is not running the System.IO.Hashing.Tests tests

Risk

This is a CI infrastructure change with low risk.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

Servicing-consider, area-Infrastructure-mono

Milestone:-

@ivanpovazanivanpovazan added this to the 8.0.0 milestone Aug 28, 2023
@ivanpovazan

Copy link
Copy Markdown
Member

/azp run runtime-ioslike

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@SamMonoRT

Copy link
Copy Markdown
Member

@marek-safar@jeffschwMSFT - this one is ready as well, needs your approval. This ensures a cleaner CI on tvos, while enabling the test on iOS. No code product changes.

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. this can be merged when ready

@jeffschwMSFTjeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 28, 2023
@SamMonoRT

Copy link
Copy Markdown
Member

cc @carlossanlop - this is ready to be merged

@carlossanlop
carlossanlop merged commit 77f36e7 into release/8.0Aug 28, 2023
@carlossanlop
carlossanlop deleted the backport/pr-90984-to-release/8.0 branch August 28, 2023 18:06
@radicalradical mentioned this pull request Sep 26, 2023
@ghostghost locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ivanpovazan@SamMonoRT@jeffschwMSFT@carlossanlop