Skip to content

Bump Microsoft.Private.Intellisense package version - #91285

Merged
carlossanlop merged 1 commit into
mainfrom
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged

Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom
BumpMicrosoftPrivateIntellisense

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706

This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.

Will backport.

@carlossanlopcarlossanlop added documentation Documentation bug or enhancement, does not impact product or test code area-Infrastructure-libraries labels Aug 29, 2023
@carlossanlopcarlossanlop self-assigned this Aug 29, 2023
@ghost

ghost commented Aug 29, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706

This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.

Will backport.

Author:carlossanlop
Assignees:carlossanlop
Labels:

documentation, area-Infrastructure-libraries

Milestone:-

ViktorHofer
ViktorHofer approved these changes Aug 29, 2023
View reviewed changes

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing

@carlossanlop

carlossanlop commented Aug 29, 2023

Copy link
Copy Markdown
ContributorAuthor

The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.
Closing and reopening to trigger the CI again.

@build-analysisbuild-analysisBot mentioned this pull request Aug 30, 2023
Closed
@ViktorHofer

ViktorHofer commented Aug 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons

EDIT:
You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text

@mthalman

mthalman commented Aug 30, 2023

Copy link
Copy Markdown
Member

Be aware of this: #77004

@carlossanlop

carlossanlop commented Sep 1, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).

I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:

  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.

Does this sound good to everyone?

@carlossanlop

carlossanlop commented Sep 1, 2023

Copy link
Copy Markdown
ContributorAuthor

I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?

@carlossanlopcarlossanlop mentioned this pull request Sep 1, 2023
Merged
@ViktorHofer

ViktorHofer commented Sep 1, 2023

Copy link
Copy Markdown
Member

but I don't know what's needed to achieve this. Who can guide me through this?

One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.

@carlossanlop

carlossanlop commented Sep 1, 2023

Copy link
Copy Markdown
ContributorAuthor

We merged dotnet/source-build-assets#774 so it should be safe to merge this now.

@carlossanlop
carlossanlop merged commit 4f8badb into mainSep 1, 2023
@carlossanlop
carlossanlop deleted the BumpMicrosoftPrivateIntellisense branch September 1, 2023 21:37
@carlossanlop

carlossanlop commented Sep 1, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to release/8.0

@github-actions

github-actionsBot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982

@github-actionsgithub-actionsBot mentioned this pull request Sep 1, 2023
Closed
@ViktorHofer

ViktorHofer commented Sep 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

We merged dotnet/source-build-assets#774 so it should be safe to merge this now.

No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.

@ViktorHoferViktorHofer mentioned this pull request Sep 2, 2023
Merged
@mthalmanmthalman mentioned this pull request Sep 6, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Bump Microsoft.Private.Intellisense package version by carlossanlop · Pull Request #91285 · dotnet/runtime · GitHub
Skip to content
Bump Microsoft.Private.Intellisense package version - #91285
Merged
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Sep 1, 2023
Merged
Bump Microsoft.Private.Intellisense package version#91285
carlossanlop merged 1 commit into
mainfrom 
BumpMicrosoftPrivateIntellisense
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

Contributor
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
@carlossanlopcarlossanlop
added

documentation
Documentation bug or enhancement, does not impact product or test code
area-Infrastructure-libraries

labels
Aug 29, 2023
@carlossanlopcarlossanlop
self-assigned this
Aug 29, 2023
@ghost
ghost
commented
Aug 29, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706
This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.
Will backport.
Author:carlossanlop
Assignees:carlossanlop
Labels:
documentation, area-Infrastructure-libraries
Milestone:-
ViktorHofer
ViktorHofer
approved these changes
Aug 29, 2023
View reviewed changes
@ViktorHoferViktorHofer
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but CI is failing
@carlossanlop
carlossanlop
commented
Aug 29, 2023

Copy link


Copy Markdown

ContributorAuthor
The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.

Closing and reopening to trigger the CI again.
@build-analysisbuild-analysisBot
mentioned this pull request
Aug 30, 2023

Closed

@ViktorHofer
ViktorHofer
commented
Aug 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman@MichaelSimons
EDIT:

You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text
@mthalman
mthalman
commented
Aug 30, 2023

Copy link


Copy Markdown

Member
Be aware of this: #77004
@carlossanlop
carlossanlop
commented
Sep 1, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Thanks @ViktorHofer for the instructions, and thanks @mthalman@MichaelSimons for the warning (#77004).
I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:
  1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-assets#774)) to make sure everything works as expected and nothing breaks.
  2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.
Does this sound good to everyone?
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?
@carlossanlopcarlossanlop
mentioned this pull request
Sep 1, 2023
 Merged

@ViktorHofer
ViktorHofer
commented
Sep 1, 2023

Copy link


Copy Markdown

Member
but I don't know what's needed to achieve this. Who can guide me through this?
One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
@carlossanlop
carlossanlop
merged commit 4f8badb
into
mainSep 1, 2023
@carlossanlop
carlossanlop
deleted the

BumpMicrosoftPrivateIntellisense

branch
September 1, 2023 21:37
@carlossanlop
carlossanlop
commented
Sep 1, 2023

Copy link


Copy Markdown

ContributorAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 1, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 1, 2023
 Closed

@ViktorHofer
ViktorHofer
commented
Sep 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
We merged dotnet/source-build-assets#774 so it should be safe to merge this now.
No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.
@ViktorHoferViktorHofer
mentioned this pull request
Sep 2, 2023
 Merged

@mthalmanmthalman
mentioned this pull request
Sep 6, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Oct 2, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@ericstjericstjAwaiting requested review from ericstj

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-librariesdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ViktorHofer@mthalman