Uh oh!
There was an error while loading. Please reload this page.
Reenable consumption of PGO data - #91297
Conversation
ghost
commented
Aug 29, 2023
Tagging subscribers to this area: @hoyosjs |
db31380 to
3aa7311CompareDrewScoggins
commented
Sep 7, 2023
Sorry, this didn't get updated. We have had updated PGO data for the last three weeks. |
jeffschwMSFT
commented
Sep 7, 2023
now that runtime official build has over come an infra issue, this issue is now the top cause of build breaks. what is the ETA for getting it merged? |
3aa7311 to
55f5340CompareI think #91497 might need to be merged first. I'll cherry pick the changes from that PR into this one to see if that is the case. |
elinor-fung
commented
Sep 7, 2023
@jeffschwMSFT what build breaks is this causing? #89311 went in last week (29-AUG) and we've had successful builds since then. |
elinor-fung
commented
Sep 7, 2023
If you are talking about the |
AustinWise
commented
Sep 7, 2023
It looks like #91497 does not currently contain the updated linker flags that would allow this PR to be merged. |
55f5340 to
e84c40fCompare8fe1378 to
920646bCompare920646b to
9aa92c6Compare9aa92c6 to
5d3bbfcCompare5d3bbfc to
0af29c6CompareDrewScoggins
commented
Oct 12, 2023
Is this ready to merge? |
AustinWise
commented
Oct 12, 2023
@DrewScoggins It can be merged once the main branch contains PGO data that was produced from the main branch. Currently it appears the PGO data is being built from the 8.0 branch, which is not compatible. See #93280 for an example of PR that updates the PGO data. |
0af29c6 to
d05fceaCompared05fcea to
a248141CompareThis reverts commit 810231c.
a248141 to
e7d26c5Compareamanasifkhalid
commented
Dec 1, 2023
Hi all, #95510 was recently merged. Is this PR ready to be merged? |
jkotas
commented
Dec 1, 2023
I can be merged once the CI is green. |
AustinWise
commented
Dec 1, 2023
It is still failing with this error:
I'm guessing the PGO data is being built from the dotnet/runtime 8.0 branch, which does not have the |
AustinWise
commented
Dec 2, 2023
Closing in favor of #95540 . |
This reverts commit 810231c from #89311. Once the PGO data has been updated with the new linker flags and CI passes on this PR, this can be merged to reenable PGO.