Skip to content

[browser] Use standard xunit test runner on multithreaded runtime - #91317

Merged
maraf merged 47 commits into
dotnet:mainfrom
maraf:WasmXharnessThreads
Feb 15, 2024
Merged

[browser] Use standard xunit test runner on multithreaded runtime#91317
maraf merged 47 commits into
dotnet:mainfrom
maraf:WasmXharnessThreads

Conversation

@maraf

@marafmaraf commented Aug 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Switch between threadless and standard xunit test runner based on runtime flavor being used
  • Pass logging level into the browser through xharness
  • New MSBuild property for setting XHarness verbosity WasmXHarnessVerbosity (Trace, Debug, Information default, Warning, Error, Critical)
  • Replace usage of env var for logging xharness test start with MSBuild property XunitShowProgress
  • WIP: Experimenting with runInParallel Separate PR

Closes#88763

@marafmaraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Aug 30, 2023
@marafmaraf self-assigned this Aug 30, 2023
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 30, 2023
@ghost

ghost commented Aug 30, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:maraf
Assignees:maraf
Labels:

arch-wasm, os-browser

Milestone:-

@maraf

maraf commented Aug 30, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 30, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@marafmaraf added area-System.Runtime.InteropServices.JavaScript test-enhancement Improvements of test source code and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners area-System.Runtime.InteropServices.JavaScript labels Aug 30, 2023
@maraf

maraf commented Aug 30, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 30, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@marafmaraf added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 30, 2023
This was referenced Aug 30, 2023
Closed
Closed
Closed
@radical

radical commented Aug 30, 2023

Copy link
Copy Markdown
Member

Are the xunit bits here just for testing? They should be with the rest of the runner stuff that we have in xharness.

@maraf

maraf commented Aug 31, 2023

Copy link
Copy Markdown
MemberAuthor

Are the xunit bits here just for testing? They should be with the rest of the runner stuff that we have in xharness.

Definitely. I'm also thinking about move the entry point to xharness as well. I copied it over to just be able to run CI with changes that I needed

@maraf

maraf commented Sep 22, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Sep 22, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 22, 2023
Closed
Closed
Closed
@pavelsavara

pavelsavara commented Oct 31, 2023

Copy link
Copy Markdown
Member

What is missing here ?
Would this also work in ST build ?
Is this still using blocking .Wait ?

@maraf
Merge remote-tracking branch 'upstream/main' into WasmXharnessThreads
d355f0e
# Conflicts:
#	src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs
@maraf
Add test assembly to VFS
5e08c6b
@maraf

maraf commented Jan 30, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@maraf

maraf commented Jan 30, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@lewing

lewing commented Jan 31, 2024

Copy link
Copy Markdown
Member

CI was stuck, merged main to restart

@maraf

maraf commented Jan 31, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@maraf

maraf commented Feb 7, 2024

Copy link
Copy Markdown
MemberAuthor

Requires #97640

@maraf
Merge remote-tracking branch 'upstream/main' into WasmXharnessThreads
b01bbbe
# Conflicts:
#	eng/testing/tests.browser.targets
#	src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs
#	src/libraries/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj
#	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
#	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
#	src/libraries/System.Private.Xml/tests/System.Private.Xml.Tests.csproj
#	src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System.Runtime.InteropServices.JavaScript.Tests.csproj
#	src/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj
@maraf

maraf commented Feb 12, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@maraf

maraf commented Feb 13, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@maraf
maraf merged commit bccbf2e into dotnet:mainFeb 15, 2024
@maraf
maraf deleted the WasmXharnessThreads branch February 15, 2024 13:02
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@ilonatommyilonatommyilonatommy approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner

Assignees

@marafmaraf

Labels

arch-wasmWebAssembly architecturearea-VM-threading-monoos-browserBrowser variant of arch-wasmtest-enhancementImprovements of test source code

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

[browser][mt] Stop using ThreadlessXunitTestRunner for MT unit tests

5 participants

@maraf@radical@pavelsavara@lewing@ilonatommy