Uh oh!
There was an error while loading. Please reload this page.
Remove libraries_tests PMI collection - #91365
Merged
BruceForstall merged 1 commit intoSep 6, 2023
Merged
Conversation
With dotnet#91101 we have a SuperPMI collection of the libraries tests being run, so the existing PMI-based collection is someone duplicative: remove the PMI collection. It's arguable that the PMI collection of the libraries themselves is also duplicative, but we can decide whether to remove that one separately.
ghost
commented
Aug 31, 2023
Tagging subscribers to this area: @hoyosjs Issue DetailsWith #91101 we have a SuperPMI collection of the libraries tests being run, so the existing PMI-based collection is someone duplicative: remove the PMI collection. It's arguable that the PMI collection of the libraries themselves is also duplicative, but we can decide whether to remove that one separately.
|
BruceForstall
commented
Aug 31, 2023
ContributorAuthor
Here are the libraries_tests.run.windows.x64.Release.mchlibraries_tests_no_tiered_compilation.run.windows.x64.Release.mchlibraries_tests.pmi.windows.x64.checked.mch@dotnet/jit-contrib |
jakobbotsch
approved these changes
Aug 31, 2023
BruceForstall
marked this pull request as ready for review
September 6, 2023 00:23
JulieLeeMSFT
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #91101 we have a SuperPMI collection of the libraries tests being run, so the existing PMI-based collection is someone duplicative: remove the PMI collection.
It's arguable that the PMI collection of the libraries themselves is also duplicative, but we can decide whether to remove that one separately.