Skip to content

Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 3 commits into from
Aug 31, 2023
Merged

Add late binding lookup in VB.NET for COM objects #91399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c569869
Add late binding lookup in VB.NET for COM objects
AaronRobinsonMSFT Aug 31, 2023
821fc4e
Review feedback
AaronRobinsonMSFT Aug 31, 2023
3bba076
Feedback
AaronRobinsonMSFT Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions ...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
baseReference = New Container(Instance)
End If

If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.
End If

Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
' If the arguments are non-empty, then it isn't optional, and is treated
' as an error if there is no default action.
' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
<System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
<DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
<RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
' LateGetInvokeDefault is used to optionally invoke the default action.
' If the arguments are non-empty, then it isn't optional, and is treated
' as an error if there is no default action.
' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
<System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
<DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
<RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
' "The DLR was able to resolve o.member, but not o.member(args)"
' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
If argumentNames Is Nothing Then argumentNames = NoArgumentNames

Dim baseReference As Container = New Container(instance)
If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
End If

'An r-value expression o(a) has two possible forms:
' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
baseReference = New Container(Instance)
End If

If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
End If

Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
End If

Dim methodName As String = ""
If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
Return
End If

Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
baseReference = New Container(Instance)
End If

If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
Try
LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
If RValueBase And Type.IsValueType Then
Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
End If
Return
Catch ex As MissingMemberException When OptimisticSet
Return
End Try
End If

Dim invocationFlags As BindingFlags

' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down
6 changes: 6 additions & 0 deletions ...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
End Get
End Property

Friend ReadOnly Property IsCOMObject() As Boolean
Get
Return _type.IsCOMObject
End Get
End Property

Friend ReadOnly Property VBFriendlyName() As String
Get
Return Utils.VBFriendlyName(_type, _instance)
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add late binding lookup in VB.NET for COM objects by AaronRobinsonMSFT · Pull Request #91399 · dotnet/runtime · GitHub
Skip to content
Add late binding lookup in VB.NET for COM objects#91399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AaronRobinsonMSFT
merged 3 commits into

from

Aug 31, 2023
 Merged


Add late binding lookup in VB.NET for COM objects
#91399
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c569869

Add late binding lookup in VB.NET for COM objects


AaronRobinsonMSFT Aug 31, 2023
821fc4e

Review feedback


AaronRobinsonMSFT Aug 31, 2023
3bba076

Feedback


AaronRobinsonMSFT Aug 31, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


33 changes: 30 additions & 3 deletions
...s/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/NewLateBinding.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.InternalLateCall(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

 End If

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
 If idmop IsNot Nothing AndAlso TypeArguments Is NoTypeArguments Then
 Return IDOBinder.IDOCall(idmop, MemberName, Arguments, ArgumentNames, CopyBack, IgnoreReturn)
Expand DownExpand Up@@ -139,7 +143,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateCallInvokeDefault is used to optionally invoke the default action on a call target.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateCall.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -155,7 +159,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
 ' LateGetInvokeDefault is used to optionally invoke the default action.
 ' If the arguments are non-empty, then it isn't optional, and is treated
 ' as an error if there is no default action.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 ' Currently we can get here only in the process of execution of NewLateBinding.LateGet.
 <System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)>
 <DebuggerHiddenAttribute()> <DebuggerStepThroughAttribute()>
 <RequiresUnreferencedCode(LateBindingTrimMessage)>
Expand All@@ -167,7 +171,7 @@ Namespace Microsoft.VisualBasic.CompilerServices

 ' According to a comment in VBGetBinder.FallbackInvoke, this function is called when
 ' "The DLR was able to resolve o.member, but not o.member(args)"
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' When NewLateBinding.LateGet is evaluating similar expression itself, it never tries to invoke default action
 ' if arguments are not empty. It simply returns result of evaluating o.member. I believe, it makes sense
 ' to follow the same logic here. I.e., if there are no arguments, simply return the instance unless it is an IDO.

Expand DownExpand Up@@ -278,6 +282,9 @@ Namespace Microsoft.VisualBasic.CompilerServices
 If argumentNames Is Nothing Then argumentNames = NoArgumentNames

 Dim baseReference As Container = New Container(instance)
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateIndexGet(instance, arguments, argumentNames)
 End If

 'An r-value expression o(a) has two possible forms:
 ' 1: o(a) array lookup--where o is an array object and a is a set of indices
Expand DownExpand Up@@ -372,6 +379,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Return LateBinding.LateGet(Instance, Type, MemberName, Arguments, ArgumentNames, CopyBack)
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsInvokeMethod Or BindingFlagsGetProperty

 Dim idmop As IDynamicMetaObjectProvider = IDOUtils.TryCastToIDMOP(Instance)
Expand DownExpand Up@@ -653,6 +664,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End If

 Dim methodName As String = ""
 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 LateBinding.LateIndexSetComplex(instance, arguments, argumentNames, optimisticSet, rValueBase)
 Return
 End If

 Dim invocationFlags As BindingFlags = BindingFlagsSetProperty

Expand DownExpand Up@@ -927,6 +942,18 @@ Namespace Microsoft.VisualBasic.CompilerServices
 baseReference = New Container(Instance)
 End If

 If baseReference.IsCOMObject AndAlso Not baseReference.IsWindowsRuntimeObject Then
 Try
 LateBinding.InternalLateSet(Instance, Type, MemberName, Arguments, ArgumentNames, OptimisticSet, CallType)
 If RValueBase And Type.IsValueType Then
 Throw New Exception(Utils.GetResourceString(SR.RValueBaseForValueType, baseReference.VBFriendlyName, baseReference.VBFriendlyName))
 End If
 Return
 Catch ex As MissingMemberException When OptimisticSet
 Return
 End Try
 End If

 Dim invocationFlags As BindingFlags

 ' If we have a IDO that implements TryGetMember for a property but not TrySetMember then we could land up
Expand Down

6 changes: 6 additions & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -823,6 +823,12 @@ Namespace Microsoft.VisualBasic.CompilerServices
 End Get
 End Property

 Friend ReadOnly Property IsCOMObject() As Boolean
 Get
 Return _type.IsCOMObject
 End Get
 End Property

 Friend ReadOnly Property VBFriendlyName() As String
 Get
 Return Utils.VBFriendlyName(_type, _instance)
Expand Down