Uh oh!
There was an error while loading. Please reload this page.
[release/8.0] Fix LDTOKEN of methods that have modifiers - #91439
Merged
Conversation
When we started generating custom modifiers into metadata format to support new function pointer APIs in #85504, we should have also added it to native layout format. We currently have a mismatch. This is a low risk bugfix to ignore modifiers on the metadata side. We'll want to do a full fix to actually emit and compare this. Tracked in a .NET 9 bug at #91381. No regression test because I spent too much time being puzzled at why https://github.com/Handlebars-Net/Handlebars.Net/blob/50614fd844e5360eb10e76154aa74da4d7bf12ce/source/Handlebars/Helpers/IHelperDescriptor.cs#L13 is generated as a custom modifier (`[in] !TOptions& modreq([netstandard]System.Runtime.InteropServices.InAttribute) options`) whereas if I do it, I get `[in] !T& 'value'` with a custom attribute. We'll want to write a proper set of tests with ambiguities for the bug I opened anyway.
ghost
commented
Sep 1, 2023
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #91382 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jkotas
approved these changes
Sep 1, 2023
jeffschwMSFT
approved these changes
Sep 1, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. once ready this can be merged
carlossanlop
commented
Sep 1, 2023
Contributor
Failure is #90434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #91382 to release/8.0
/cc @MichalStrehovsky
Customer Impact
This was a customer reported regression from 7.0 reported at #91065. LINQ expression trees referencing methods that have custom modifiers in the signature would not work.
Testing
All of our NativeAOT testing. Verified the customer app is fixed with this.
Risk
Low, this is a low risk fix specifically for 8.0 (ignore custom modifiers to restore 7.0 behavior).
We'll need a more comprehensive fix to be able to distinguish corner cases (that were already broken in 7.0 but people are very unlikely to hit because they'd need a class with two methods where the signature of the methods only differ in modifiers - AFAIK this is only reachable with C# if one has two methods that take function pointers as parameters and they differ only in calling conventions).
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.