[iOS] Fix trimming warnings in HttpClientHandler.AnyMobile by simonrozsival · Pull Request #91520 · dotnet/runtime

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

simonrozsival · 2023-09-03T15:49:19Z

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

This PR fixes the warning.

…ndlerMethod

ghost · 2023-09-03T15:49:29Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	-
Labels:	`area-System.Net.Http`, `os-ios`
Milestone:	-

simonrozsival · 2023-09-03T15:51:50Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-03T15:51:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…ient-handler-anymobile-suppress-ilc-warning

simonrozsival · 2023-09-07T07:49:34Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-09-07T07:49:47Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2023-09-07T09:02:02Z

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

While testing NativeAOT on iOS, I started noticed this warning from ILC:

ILC : Trim analysis warning IL2075: System.Net.Http.HttpClientHandler.InvokeNativeHandlerMethod(String,Object[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String)'. The return value of method 'System.Object.GetType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

All the methods which call InvokeNativeHandlerMethod are annotated with DynamicDependency attributes and so the warning we get from ILC can be suppressed.

Author:	simonrozsival
Assignees:	simonrozsival
Labels:	`area-System.Net.Http`, `linkable-framework`, `os-ios`
Milestone:	-

MichalStrehovsky · 2023-09-07T09:03:01Z

We typically write targeted trimming tests if there is a suppression. Suppressions are not great because someone could add a new callsite and forget to add DynamicDependency (or DynamicDependency the wrong thing).

I think this can be rewritten to be correct by construction. All the text strings are there, they're just too far apart for analysis to figure them out.

Basically, I'd do this:

Delete all the DynamicDependency stuff.
Replace _nativeHandler!.GetType()!.GetMethod(name); in InvokeNativeHandlerMethod with Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name);. The C# compiler will concatenate these strings because they're all consts.
This is already enough to make everything work. Trimming will keep all public methods on the type and there will be no warning. This is because the name of the type is visible within the InvokeNativeHandlerMethod method.
If there is a size concern (we don't want to keep all the public methods on this type), we could hoist the Type.GetType(NativeHandlerType + ", " + AssemblyName)!.GetMethod(name); part into a delegate (add an Action<MethodInfo> delegate parameter to InvokeNativeHandlerMethod and provide the right implementation at each callsite as a lambda). This should result in comparable size to what was achieved with DynamicDependency (the attributes are not cheap, size-wise - it's a lot of characters and none of them can be shared even though they're identical because custom attributes are encoded that way).

simonrozsival · 2023-09-07T12:10:16Z

@MichalStrehovsky thanks for the suggestion!

simonrozsival · 2023-09-07T16:53:54Z

/azp run runtime-ioslike

azure-pipelines · 2023-09-07T16:54:02Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky

Looks great! (Reviewing from the trimmability perspective only.)

Cc @AaronRobinsonMSFT - I think this is a nice candidate for #90081. We'll be able to simplify all of this and get rid of the reflection.

simonrozsival · 2023-09-08T07:44:01Z

/azp run runtime-android

azure-pipelines · 2023-09-08T07:44:13Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2023-09-09T10:34:11Z

/backport to release/8.0-rc1

github-actions · 2023-09-09T10:34:22Z

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/6130417198

stephentoub · 2023-09-09T14:42:44Z

Was release/8.0-rc1 correct or should it have been release/8.0 instead?

simonrozsival · 2023-09-09T15:24:08Z

@stephentoub you're right, it shouldn't be RC1. I'll open a new backport.

simonrozsival · 2023-09-11T11:33:00Z

/backport to release/8.0

github-actions · 2023-09-11T11:33:14Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6145796878

marek-safar · 2023-09-12T17:04:00Z

+ InvokeNativeHandlerMethod(getMethod, parameters: new object?[] { value }, cachingKey!);
+ }
+
+ private object InvokeNativeHandlerMethod(Func<MethodInfo> getMethod, object?[]? parameters, string cachingKey)


Why is it not static?

marek-safar · 2023-09-12T17:04:23Z

+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)
+ {
+ return InvokeNativeHandlerMethod(getMethod, parameters: null, cachingKey!);


Please add Debug.Assert instead of only !

marek-safar · 2023-09-12T17:07:13Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


Perhaps Type.GetType(NativeHandlerType) could come as an argument to the lambda and you could cache it too.

As far as I understand it, by keeping the GetType and GetMethod calls together with constant arguments will give the trimmer enough information to keep only the methods that are actually used. If we cached the type, I think it wouldn't be trimmable anymore.

That's true. We don't have a way to do this with caching the Type (without suppressing some warnings).
Once we have UnsafeAccessorType then this can be rewritten to use that and it will not use any reflection and be faster.

marek-safar · 2023-09-12T17:08:55Z

-[DynamicDependency("set_Credentials", NativeHandlerType, AssemblyName)]
-private void SetCredentials(ICredentials? value) => InvokeNativeHandlerMethod("set_Credentials", value);
+private void SetCredentials(ICredentials? value)
+ => InvokeNativeHandlerSetter(() => Type.GetType(NativeHandlerType)!.GetMethod("set_Credentials")!, value);


All the lambdas should be static (not sure why the analyzer does not complain).

marek-safar · 2023-09-12T17:14:29Z

 return (HttpMessageHandler)_nativeHandlerMethod!.Invoke(null, null)!;
 }
+
+ private object InvokeNativeHandlerGetter(Func<MethodInfo> getMethod, [CallerMemberName] string? cachingKey = null)


Perhaps we could use CallerLineNumberAttribute or some other key which is not a next string in the assembly

Unconditionally supress trimming warnings when calling InvokeNativeHa…
13bb014
…ndlerMethod

simonrozsival added area-System.Net.Http os-ios Apple iOS labels Sep 3, 2023

simonrozsival requested a review from steveisok September 3, 2023 15:49

ghost assigned simonrozsival Sep 3, 2023

This comment was marked as outdated.
Sign in to view

This was referenced Sep 3, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed
Tracking issue for "WORKLOAD TIMED OUT" #90309
Closed

simonrozsival mentioned this pull request Sep 4, 2023
[iOS][tvOS] Building tests fails with "Trimming assemblies requires .NET Core 3.0 or higher" #91535
Closed

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto http-cl…
6f1d76d
…ient-handler-anymobile-suppress-ilc-warning

MichalStrehovsky added the linkable-framework Issues associated with delivering a linker friendly framework label Sep 7, 2023

simonrozsival marked this pull request as draft September 7, 2023 13:46

eerhardt reviewed Sep 7, 2023
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.AnyMobile.cs Outdated

Update HttpClientHandler
1a0877a

MichalStrehovsky reviewed Sep 8, 2023
View reviewed changes

simonrozsival changed the title ~~[iOS] Unconditionally suppress trimming warnings in HttpClientHandler~~[iOS] Fix trimming warnings in HttpClientHandler.AnyMobileSep 8, 2023

simonrozsival mentioned this pull request Sep 8, 2023
[Android][arm64] Use of undeclared identifier 'ICALL_SIG_TYPE__Bool' #91779
Closed

simonrozsival marked this pull request as ready for review September 8, 2023 08:46

akoeplinger approved these changes Sep 8, 2023
View reviewed changes

simonrozsival merged commit 7f06d1c into dotnet:mainSep 8, 2023

simonrozsival deleted the http-client-handler-anymobile-suppress-ilc-warning branch September 8, 2023 19:07

github-actionsBot mentioned this pull request Sep 9, 2023
[release/8.0-rc1] [iOS] Fix trimming warnings in HttpClientHandler.AnyMobile #91835
Closed

github-actionsBot mentioned this pull request Sep 11, 2023
[release/8.0] [iOS] Fix trimming warnings in HttpClientHandler.AnyMobile #91877
Merged

marek-safar reviewed Sep 12, 2023
View reviewed changes

simonrozsival mentioned this pull request Sep 14, 2023
[iOS][Android] Refactor invoking native handler in HttpClientHandler #92051
Closed

karelz added this to the 9.0.0 milestone Sep 14, 2023

ghost locked as resolved and limited conversation to collaborators Oct 14, 2023