Skip to content

JIT: Fix invalid zero-init suppression for untracked variables - #91580

Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:fix-91576
Sep 9, 2023
Merged

JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:fix-91576

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Sep 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.

Fix#91576

Also makes the handling for potential implicit control flow more precise, to counteract regressions.

@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 5, 2023
@ghostghost assigned jakobbotschSep 5, 2023
@ghost

ghost commented Sep 5, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.

Fix #91576

Author:jakobbotsch
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotschjakobbotsch changed the title JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch added this to the 8.0.0 milestone Sep 5, 2023
@jakobbotsch

jakobbotsch commented Sep 5, 2023

Copy link
Copy Markdown
MemberAuthor

This sadly has some quite significant regressions, will see if I can address some of these.

@jakobbotsch
jakobbotsch marked this pull request as draft September 5, 2023 13:57
@build-analysisbuild-analysisBot mentioned this pull request Sep 5, 2023
Closed
@jakobbotsch
jakobbotsch marked this pull request as ready for review September 5, 2023 17:17
@jakobbotsch

jakobbotsch commented Sep 5, 2023

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Diffs where we now need to zero init in some cases again.

AndyAyersMS
AndyAyersMS approved these changes Sep 5, 2023
View reviewed changes

@AndyAyersMSAndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?

@jakobbotsch

jakobbotsch commented Sep 5, 2023

Copy link
Copy Markdown
MemberAuthor

Are the handful cases where we now do less zero init ones where there were no eh successors?

Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.

It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.

@jakobbotsch

jakobbotsch commented Sep 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines

azure-pipelinesBot commented Sep 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch

jakobbotsch commented Sep 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines

azure-pipelinesBot commented Sep 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch

jakobbotsch commented Sep 7, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn

@azure-pipelines

azure-pipelinesBot commented Sep 7, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Sep 7, 2023
Closed
@jakobbotsch

jakobbotsch commented Sep 9, 2023

Copy link
Copy Markdown
MemberAuthor

Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.

@jakobbotsch
jakobbotsch merged commit 671d42c into dotnet:mainSep 9, 2023
@jakobbotsch

jakobbotsch commented Sep 9, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0

@github-actions

github-actionsBot commented Sep 9, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931

@github-actionsgithub-actionsBot mentioned this pull request Sep 9, 2023
Merged
@jakobbotsch
jakobbotsch deleted the fix-91576 branch September 9, 2023 15:20
@ghostghost locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch

@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally

2 participants

@jakobbotsch@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
JIT: Fix invalid zero-init suppression for untracked variables by jakobbotsch · Pull Request #91580 · dotnet/runtime · GitHub
Skip to content
JIT: Fix invalid zero-init suppression for untracked variables - #91580
Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Sep 9, 2023
Merged
JIT: Fix invalid zero-init suppression for untracked variables#91580
jakobbotsch merged 2 commits into
dotnet:mainfrom 
jakobbotsch:fix-91576
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Sep 5, 2023•

edited

Loading

Copy link


Copy Markdown

Member
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix#91576
Also makes the handling for potential implicit control flow more precise, to counteract regressions.
@jakobbotsch
JIT: Fix invalid zero-init supression for untracked variables
f803650
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.
Fixdotnet#91576
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 5, 2023
@ghostghost
assigned jakobbotschSep 5, 2023
@ghost
ghost
commented
Sep 5, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
optRemoveRedundantZeroInits has logic to remove unnecessary zero inits if we can determine that the local will be zeroed in the prolog. In addition, it also has logic to suppress the prolog zero init if there is a dominating initialization already. The latter logic was trying to reason about liveness for untracked locals, which does not make sense.
Fix #91576
Author:jakobbotsch
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@jakobbotschjakobbotsch
changed the title
JIT: Fix invalid zero-init supression for untracked variablesJIT: Fix invalid zero-init suppression for untracked variablesSep 5, 2023
@jakobbotschjakobbotsch
added this to the 8.0.0 milestone
Sep 5, 2023
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
This sadly has some quite significant regressions, will see if I can address some of these.
@jakobbotsch
jakobbotsch
marked this pull request as draft
September 5, 2023 13:57
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 5, 2023

Closed

@jakobbotsch
jakobbotsch
marked this pull request as ready for review
September 5, 2023 17:17
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS
Diffs where we now need to zero init in some cases again.
AndyAyersMS
AndyAyersMS
approved these changes
Sep 5, 2023
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the handful cases where we now do less zero init ones where there were no eh successors?
@jakobbotsch
jakobbotsch
commented
Sep 5, 2023

Copy link


Copy Markdown

MemberAuthor
Are the handful cases where we now do less zero init ones where there were no eh successors?
Yep, for example in https://github.com/dotnet/runtime/blob/cf65ea21bfcb4f53a416506d43d79900413e5b1b/src/tests/JIT/Regression/JitBlue/Runtime_85892/Runtime_85892.csvr4 no longer needs zero initing because we now realize that even though it is handler live, the handler is not reachable before the location where it is initialized.
It seems like we could be even more precise by tracking the set of locals that are actually live to handlers we have seen and only disqualifying those in this optimization, though I doubt it would be significantly better than what we have with this PR.
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 6, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr superpmi-diffs
@azure-pipelines
azure-pipelinesBot
commented
Sep 6, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@jakobbotsch
jakobbotsch
commented
Sep 7, 2023

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn
@azure-pipelines
azure-pipelinesBot
commented
Sep 7, 2023

Copy link


Copy Markdown


Azure Pipelines successfully started running 3 pipeline(s).
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 7, 2023

Closed

@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
Opened #91839 for the Fuzzlyn failures. The jitstress failure is #91705. The superpmi-diffs failure was the "No space left on device" due to some machines in a bad state.
@jakobbotsch
jakobbotsch
merged commit 671d42c
into
dotnet:mainSep 9, 2023
@jakobbotsch
jakobbotsch
commented
Sep 9, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@github-actions
github-actionsBot
commented
Sep 9, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6131654931
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 9, 2023
 Merged

@jakobbotsch
jakobbotsch
deleted the

fix-91576

branch
September 9, 2023 15:20
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 9, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@jakobbotschjakobbotsch
@AndyAyersMSAndyAyersMS

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Bad codegen with try/finally


2 participants

@jakobbotsch@AndyAyersMS