[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 1 commit into from
Sep 6, 2023
Merged

[release/8.0] Enable output compilation validation in binder gen unit tests #91602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
}
}

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
{
int count = 0;
Project result = project;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
{
foreach (InterceptorLocationInfo info in infoList)
{
_writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
_writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
}
}

Expand Down
5 changes: 4 additions & 1 deletion ...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
{
RegisterTypeForBindCoreMainGen(typeSpec);

_sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
_sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
RegisterTypeForBindCoreMainGen(typeSpec);
// Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
_sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
[InterceptsLocation(@"src-0.cs", 12, 17)]
public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
#endregion IConfiguration extensions.

Expand Down
6 changes: 3 additions & 3 deletions ...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
[InterceptsLocation(@"src-0.cs", 12, 14)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
{
if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
}

/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
[InterceptsLocation(@"src-0.cs", 13, 20)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
{
if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
}

/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
[InterceptsLocation(@"src-0.cs", 14, 20)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
{
if (configuration is null)
Expand Down
2 changes: 1 addition & 1 deletion ...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
[InterceptsLocation(@"src-0.cs", 12, 20)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
{
if (configuration is null)
Expand Down
2 changes: 1 addition & 1 deletion ...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
[InterceptsLocation(@"src-0.cs", 12, 20)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
{
if (configuration is null)
Expand Down
2 changes: 1 addition & 1 deletion ...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
[InterceptsLocation(@"src-0.cs", 12, 20)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
{
if (configuration is null)
Expand Down
8 changes: 4 additions & 4 deletions ...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
[InterceptsLocation(@"src-0.cs", 12, 38)]
public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
[InterceptsLocation(@"src-0.cs", 14, 36)]
public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
[InterceptsLocation(@"src-0.cs", 13, 56)]
public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
[InterceptsLocation(@"src-0.cs", 15, 47)]
public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
#endregion IConfiguration extensions.

Expand Down
8 changes: 4 additions & 4 deletions ...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
[InterceptsLocation(@"src-0.cs", 13, 18)]
public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
[InterceptsLocation(@"src-0.cs", 16, 24)]
public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
[InterceptsLocation(@"src-0.cs", 14, 24)]
public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
[InterceptsLocation(@"src-0.cs", 17, 24)]
public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
[InterceptsLocation(@"src-0.cs", 10, 20)]
public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
[InterceptsLocation(@"src-0.cs", 12, 20)]
public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
[InterceptsLocation(@"src-0.cs", 10, 20)]
public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
[InterceptsLocation(@"src-0.cs", 11, 20)]
public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
[InterceptsLocation(@"src-0.cs", 11, 40)]
public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
[InterceptsLocation(@"src-0.cs", 11, 40)]
public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
[InterceptsLocation(@"src-0.cs", 11, 51)]
public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
[InterceptsLocation(@"src-0.cs", 11, 20)]
public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
#endregion IConfiguration extensions.

Expand Down
2 changes: 1 addition & 1 deletion ...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region OptionsBuilder<TOptions> extensions.
/// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
[InterceptsLocation(@"src-0.cs", 12, 24)]
public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
{
if (optionsBuilder is null)
Expand Down
2 changes: 1 addition & 1 deletion ...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region OptionsBuilder<TOptions> extensions.
/// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
[InterceptsLocation(@"src-0.cs", 15, 24)]
public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
{
return Bind(optionsBuilder, config, configureBinder: null);
Expand Down
2 changes: 1 addition & 1 deletion ...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region OptionsBuilder<TOptions> extensions.
/// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
[InterceptsLocation(@"src-0.cs", 15, 24)]
public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
{
if (optionsBuilder is null)
Expand Down
25 changes: 20 additions & 5 deletions ...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IConfiguration extensions.
/// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
[InterceptsLocation(@"src-0.cs", 13, 16)]
public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
{
if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
#endregion IConfiguration extensions.

#region Core binding extensions.
private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
{
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

if (configuration["Prop23"] is string value18)
{
instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
}

if (configuration["Prop24"] is string value19)
{
instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
}

if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

if (configuration["Prop22"] is string value27)
{
instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
}

if (configuration["Prop28"] is string value28)
{
instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
}

if (configuration["Prop29"] is string value29)
{
instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
}

if (configuration["Prop30"] is string value30)
{
instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
}
}

Expand Down
3 changes: 2 additions & 1 deletion ....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
using System;
using System.CodeDom.Compiler;
using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
#region IServiceCollection extensions.
/// <summary>Registers a configuration instance which TOptions will bind against.</summary>
[InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
[InterceptsLocation(@"src-0.cs", 14, 18)]
public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
{
return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/8.0] Enable output compilation validation in binder gen unit tests#91602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ericstj
merged 1 commit into

from

Sep 6, 2023
 Merged


[release/8.0] Enable output compilation validation in binder gen unit tests
#91602
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/SourceGenerators/RoslynTestUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ public static async Task AssertNoDiagnostic(this Project proj, params string[] i
 }
 }

private static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
public static Project WithDocuments(this Project project, IEnumerable<string> sources, IEnumerable<string>? sourceNames = null)
 {
 int count = 0;
 Project result = project;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/Helpers.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ private void EmitInterceptsLocationAnnotations(List<InterceptorLocationInfo> inf
 {
 foreach (InterceptorLocationInfo info in infoList)
 {
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}Attribute(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 _writer.WriteLine($@"[{Identifier.InterceptsLocation}(@""{info.FilePath}"", {info.LineNumber}, {info.CharacterNumber})]");
 }
 }

Expand Down

5 changes: 4 additions & 1 deletion
...onfiguration.Binder/gen/Helpers/Parser/OptionsConfigurationServiceCollectionExtensions.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,9 +85,12 @@ @params[1].Type.SpecialType is SpecialType.System_String &&

 private void RegisterTypeForMethodGen(MethodsToGen_Extensions_ServiceCollection overload, TypeSpec typeSpec)
 {
 RegisterTypeForBindCoreMainGen(typeSpec);

 _sourceGenSpec.MethodsToGen_ServiceCollectionExt |= overload;
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.DependencyInjection");
 RegisterTypeForBindCoreMainGen(typeSpec);
 // Emitting refs to IOptionsChangeTokenSource, ConfigurationChangeTokenSource, IConfigureOptions<>, ConfigureNamedOptions<>.
 _sourceGenSpec.Namespaces.Add("Microsoft.Extensions.Options");
Comment thread
layomia marked this conversation as resolved.

 }
 }
 }
Expand Down

2 changes: 1 addition & 1 deletion
...ions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Collections.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 17)]
 [InterceptsLocation(@"src-0.cs", 12, 17)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

6 changes: 3 additions & 3 deletions
...ation.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 12, 14)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -49,7 +49,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 13, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand All@@ -67,7 +67,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 }

 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...der/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/Bind_Instance_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance, Action<BinderOptions>? configureOptions)
 {
 if (configuration is null)
Expand Down

2 changes: 1 addition & 1 deletion
...tests/SourceGenerationTests/Baselines/ConfigurationBinder/Bind_Key_Instance.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, string key, object? instance)
 {
 if (configuration is null)
Expand Down

8 changes: 4 additions & 4 deletions
...ration.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,19 +31,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 38)]
 [InterceptsLocation(@"src-0.cs", 12, 38)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 36)]
 [InterceptsLocation(@"src-0.cs", 14, 36)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 36)]
 [InterceptsLocation(@"src-0.cs", 13, 56)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);

 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 36)]
 [InterceptsLocation(@"src-0.cs", 15, 47)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

8 changes: 4 additions & 4 deletions
...n.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,19 +30,19 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 18)]
 [InterceptsLocation(@"src-0.cs", 13, 18)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 16, 24)]
 [InterceptsLocation(@"src-0.cs", 16, 24)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 24)]
 [InterceptsLocation(@"src-0.cs", 14, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);

 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 17, 24)]
 [InterceptsLocation(@"src-0.cs", 17, 24)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...er/tests/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ceGenerationTests/Baselines/ConfigurationBinder/GetValue_T_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 20)]
 [InterceptsLocation(@"src-0.cs", 12, 20)]
 public static T? GetValue<T>(this IConfiguration configuration, string key, T defaultValue) => (T?)(BindingExtensions.GetValueCore(configuration, typeof(T), key) ?? defaultValue);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 10, 20)]
 [InterceptsLocation(@"src-0.cs", 10, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key) => BindingExtensions.GetValueCore(configuration, type, key);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...erationTests/Baselines/ConfigurationBinder/GetValue_TypeOf_Key_DefaultValue.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Extracts the value with the specified key and converts it to the specified type.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? GetValue(this IConfiguration configuration, Type type, string key, object? defaultValue) => BindingExtensions.GetValueCore(configuration, type, key) ?? defaultValue;
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...tion.Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration) => (T?)(GetCore(configuration, typeof(T), configureOptions: null) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...sts/SourceGenerationTests/Baselines/ConfigurationBinder/Get_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 40)]
 public static T? Get<T>(this IConfiguration configuration, Action<BinderOptions>? configureOptions) => (T?)(GetCore(configuration, typeof(T), configureOptions) ?? default(T));
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...Binder/tests/SourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 40)]
 [InterceptsLocation(@"src-0.cs", 11, 51)]
 public static object? Get(this IConfiguration configuration, Type type) => GetCore(configuration, type, configureOptions: null);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...ourceGenerationTests/Baselines/ConfigurationBinder/Get_TypeOf_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the configuration instance to a new instance of type T.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 11, 20)]
 [InterceptsLocation(@"src-0.cs", 11, 20)]
 public static object? Get(this IConfiguration configuration, Type type, Action<BinderOptions>? configureOptions) => GetCore(configuration, type, configureOptions);
 #endregion IConfiguration extensions.

Expand Down

2 changes: 1 addition & 1 deletion
...nder/tests/SourceGenerationTests/Baselines/OptionsBuilder/BindConfiguration.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers the dependency injection container to bind <typeparamref name="TOptions"/> against the <see cref="IConfiguration"/> obtained from the DI service provider.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 12, 24)]
 [InterceptsLocation(@"src-0.cs", 12, 24)]
 public static OptionsBuilder<TOptions> BindConfiguration<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, string configSectionPath, Action<BinderOptions>? configureBinder = null) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

2 changes: 1 addition & 1 deletion
...guration.Binder/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config) where TOptions : class
 {
 return Bind(optionsBuilder, config, configureBinder: null);
Expand Down

2 changes: 1 addition & 1 deletion
...r/tests/SourceGenerationTests/Baselines/OptionsBuilder/Bind_T_BinderOptions.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region OptionsBuilder<TOptions> extensions.
 /// <summary>Registers a configuration instance which <typeparamref name="TOptions"/> will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 15, 24)]
 [InterceptsLocation(@"src-0.cs", 15, 24)]
 public static OptionsBuilder<TOptions> Bind<TOptions>(this OptionsBuilder<TOptions> optionsBuilder, IConfiguration config, Action<BinderOptions>? configureBinder) where TOptions : class
 {
 if (optionsBuilder is null)
Expand Down

25 changes: 20 additions & 5 deletions
...sions.Configuration.Binder/tests/SourceGenerationTests/Baselines/Primitives.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IConfiguration extensions.
 /// <summary>Attempts to bind the given object instance to configuration values by matching property names against configuration keys recursively.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 13, 16)]
 [InterceptsLocation(@"src-0.cs", 13, 16)]
 public static void Bind_ProgramMyClass(this IConfiguration configuration, object? instance)
 {
 if (configuration is null)
Expand All@@ -50,7 +50,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 #endregion IConfiguration extensions.

 #region Core binding extensions.
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22" });
 private readonly static Lazy<HashSet<string>> s_configKeys_ProgramMyClass = new(() => new HashSet<string>(StringComparer.OrdinalIgnoreCase) { "Prop0", "Prop1", "Prop2", "Prop3", "Prop4", "Prop5", "Prop6", "Prop8", "Prop9", "Prop10", "Prop13", "Prop14", "Prop15", "Prop16", "Prop17", "Prop19", "Prop20", "Prop21", "Prop23", "Prop24", "Prop25", "Prop26", "Prop27", "Prop7", "Prop11", "Prop12", "Prop18", "Prop22", "Prop28", "Prop29", "Prop30" });

 public static void BindCore(IConfiguration configuration, ref Program.MyClass instance, BinderOptions? binderOptions)
 {
Expand DownExpand Up@@ -142,12 +142,12 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop23"] is string value18)
 {
 instance.Prop23 = ParseInt(value18, () => configuration.GetSection("Prop23").Path);
 instance.Prop23 = ParseTimeSpan(value18, () => configuration.GetSection("Prop23").Path);
 }

 if (configuration["Prop24"] is string value19)
 {
 instance.Prop24 = ParseDateTime(value19, () => configuration.GetSection("Prop24").Path);
 instance.Prop24 = ParseGuid(value19, () => configuration.GetSection("Prop24").Path);
 }

 if (configuration["Prop25"] is string value20)
Expand DownExpand Up@@ -187,7 +187,22 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration

 if (configuration["Prop22"] is string value27)
 {
 instance.Prop22 = ParseByteArray(value27, () => configuration.GetSection("Prop22").Path);
 instance.Prop22 = ParseTimeOnly(value27, () => configuration.GetSection("Prop22").Path);
 }

 if (configuration["Prop28"] is string value28)
 {
 instance.Prop28 = ParseByteArray(value28, () => configuration.GetSection("Prop28").Path);
 }

 if (configuration["Prop29"] is string value29)
 {
 instance.Prop29 = ParseInt(value29, () => configuration.GetSection("Prop29").Path);
 }

 if (configuration["Prop30"] is string value30)
 {
 instance.Prop30 = ParseDateTime(value30, () => configuration.GetSection("Prop30").Path);
 }
 }

Expand Down

3 changes: 2 additions & 1 deletion
....Binder/tests/SourceGenerationTests/Baselines/ServiceCollection/Configure_T.generated.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
{
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using System;
 using System.CodeDom.Compiler;
 using System.Collections.Generic;
Expand All@@ -32,7 +33,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration
 {
 #region IServiceCollection extensions.
 /// <summary>Registers a configuration instance which TOptions will bind against.</summary>
 [InterceptsLocationAttribute(@"src-0.cs", 14, 18)]
 [InterceptsLocation(@"src-0.cs", 14, 18)]
 public static IServiceCollection Configure<TOptions>(this IServiceCollection services, IConfiguration config) where TOptions : class
 {
 return Configure<TOptions>(services, string.Empty, config, configureOptions: null);
Expand Down
Loading