Uh oh!
There was an error while loading. Please reload this page.
Don't shut down event pipe in DLLs on Windows - #91715
Conversation
ghost
commented
Sep 7, 2023
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsWorks around #89346. We blocked event pipe completely in shared libraries in #90811 but:
I validated the shared library scenario no longer hangs at shutdown with this. #89346 still tracks if we can do better here. Cc @dotnet/ilc-contrib
|
agocke
commented
Sep 7, 2023
Does it actually work though? Can you load two libraries into the same process, enable event support, and the use dotnet-monitor or similar to retrieve events from both libraries? I'd rather disable this completely until we're confident the scenario is working as we want it to. |
What about allowing a bypass? So blocked by default because of the multiple runtime questions, but still let people explicitly enable it as a 'I understand the limitations - I will only have one library/runtime and I want to be able to trace it'. I think that was actually @MichalStrehovsky's original suggestion. |
agocke
commented
Sep 7, 2023
Yup, bypass sounds great, just like we did with WPF. |
Uh oh!
There was an error while loading. Please reload this page.
…e.Publish.targets Co-authored-by: Elinor Fung <elfung@microsoft.com>
MichalStrehovsky
left a comment
There was a problem hiding this comment.
This is what I had in mind if we really insist on blocking this.
This is different from the WPF block because that one doesn't work at all. This works, for a large majority of users.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
agocke
commented
Sep 7, 2023
That's what I was asking, though. Does it? Loading two CoreCLR instances in the same process is unsupported. Loading two Native AOT binaries in the same process is fully supported. If this is fully supported, I would expect it to be fully supported across all our supported configurations. |
MichalStrehovsky
commented
Sep 7, 2023
Yes, but so is EventSourceSupport in Native AOT exe files, and CoreCLR hosting APIs. Still if you use all of these in a single process, it will likely hit the same issue as two NativeAOT dlls. I think the right course of action is not in blocking (because we can't block that one), but in defining a failure mode. |
MichalStrehovsky
commented
Sep 8, 2023
@agcoke the last commit downgrades the error to a suppressible warning with a link to the issue. I considered making a fwlink for it but maybe that's an overkill. |
agocke
left a comment
There was a problem hiding this comment.
LGTM, minor wording change suggested, and replaced link with a link to our official docs. I figure we can add a line in here to fully explain the situation.
Uh oh!
There was an error while loading. Please reload this page.
…e.Publish.targets Co-authored-by: Andy Gocke <andy@commentout.net>
Uh oh!
There was an error while loading. Please reload this page.
MichalStrehovsky
commented
Sep 14, 2023
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6181325936 |
Works around #89346.
We blocked event pipe completely in shared libraries in #90811 but:
I validated the shared library scenario no longer hangs at shutdown with this.
#89346 still tracks if we can do better here.
Cc @dotnet/ilc-contrib