Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Merge CoreMangLib, Exceptions and Interop folders - #91901

Merged
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop
Oct 12, 2023
Merged

Merge CoreMangLib, Exceptions and Interop folders#91901
trylek merged 16 commits into
dotnet:mainfrom
trylek:MergeCoreMangLibExceptionsInterop

Conversation

@trylek

@trylektrylek commented Sep 11, 2023

Copy link
Copy Markdown
Member

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Sep 11, 2023
@trylektrylek added this to the 9.0.0 milestone Sep 11, 2023
@ghostghost assigned trylekSep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This change converts tests in the CoreMangLib, Exceptions and Interop to the merged model. As next step I plan to work on review feedback to my previous PR merging baseservices and on merging the remaining tests.

Thanks

Tomas

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:9.0.0

@trylek

trylek commented Sep 11, 2023

Copy link
Copy Markdown
MemberAuthor

/cc @ivsiazsa @dotnet/runtime-infrastructure

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.csproj Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lowercase 'exe' slipped through the scan.

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though, now that I think about it, I guess that's where ReqProcIso ends up anyway, though I think we automatically set it (kind of hacky in Dir.B.targets since it is after the SDK has had a look at it))

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we shouldn't keep obsolete OutputType=exe properties on most tests except the tiny subset opting out of the merged wrappers for special reasons like the half a dozen tests under baseservices that do weird things. I have experimentally removed all these annotations from the interop tests and I'm retesting the change locally, I'll be happy to update the PR by removing those if it turns out to be working.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/MonoAPI/MonoMono/InstallEHCallback.cs Outdated

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this (and the others) end up being fine (mono test, int equality), but I don't know for sure that these don't end up being run in some configuration that breaks. But hopefully outerloop (and extra platforms?) is good enough to check that?

@trylektrylekSep 11, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say to this now is that in general Mono tests are supported by the merged test infrastructure, @jkoritzinsky went to great lengths to make that fully functional and IIRC Mono people were happy about his implementation in terms of efficiency and cleanness.

@markplesmarkplesSep 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear. I just don't know if this test will end up running in some other configuration (from a quick look, I don't see it being excluded from other runtimes). However, I meant it more as a "heads up" in case something breaks, not an objection to the PR.

@jkoritzinskyjkoritzinskySep 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have concerns, we can use the SkipOnCoreClrAttribute on the test and it will automatically be skipped on non-Mono platforms. Tbh I think that's a better solution than suppressing the test in issues.targets.

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Array/MarshalArrayAsParam/AsDefault/AsDefaultTest.cs Outdated
markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/BestFitMapping/Program.cs Outdated
Comment on lines 36 to 40

@markplesmarkplesSep 11, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this cleanup that we get!

markples
markples reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 51753b7 to ef78e29CompareSeptember 12, 2023 15:08
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from ef78e29 to c0620faCompareOctober 5, 2023 13:44
@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 3102df5 to 7e50880CompareOctober 7, 2023 19:03
@build-analysisbuild-analysisBot mentioned this pull request Oct 7, 2023
Open
@trylek
Manually convert 6 Interop tests overlooked by ILTransform
d6612a6
@trylek
Fix the Interop/MonoAPI/MonoMono/Thunks test
5200e60
@trylek
Mark out of process tests with Private="False"
fe9e959
This is needed so that they don't copy their outputs to the merged
wrapper folder, triggering errors in Mono builds because some output
file names overlap.
Thanks
Tomas
@trylek
Fix a new test, block copying custom System.Private.CoreLib to output
f930ffd
@trylek
trylekforce-pushed the MergeCoreMangLibExceptionsInterop branch from 011550e to f930ffdCompareOctober 11, 2023 21:16
@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@trylek

trylek commented Oct 11, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Oct 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 12, 2023
Closed
Closed
@trylek
trylek merged commit 5280006 into dotnet:mainOct 12, 2023
@trylek
trylek deleted the MergeCoreMangLibExceptionsInterop branch October 12, 2023 01:19
This was referenced Oct 16, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
1 more reviewer
@markplesmarkplesmarkples approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@jkoritzinsky@markples