Skip to content

Fix downlevel build break in TensorPrimitives - #92269

Merged
ericstj merged 4 commits into
dotnet:mainfrom
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged

Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom
stephentoub:fixdownleveltensor

Conversation

@stephentoub

@stephentoubstephentoub commented Sep 19, 2023

Copy link
Copy Markdown
Member

No description provided.

@stephentoub

stephentoub commented Sep 19, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to release/8.0

@ghost

ghost commented Sep 19, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:stephentoub
Assignees:-
Labels:

area-System.Numerics

Milestone:-

@github-actions

github-actionsBot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540

@github-actionsgithub-actionsBot mentioned this pull request Sep 19, 2023
Merged
@stephentoubstephentoub mentioned this pull request Sep 19, 2023
Merged
@steveisok
steveisok self-requested a review September 19, 2023 14:24
@ericstj

ericstj commented Sep 19, 2023

Copy link
Copy Markdown
Member

This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.

@build-analysisbuild-analysisBot mentioned this pull request Sep 19, 2023
Open
5 tasks
This was referenced Sep 19, 2023
Closed
Closed
@ericstj

ericstj commented Sep 19, 2023

Copy link
Copy Markdown
Member

Hmm, this seems to have added prebuilts.

error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9

Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?

@ericstj

ericstj commented Sep 19, 2023

Copy link
Copy Markdown
Member

I see, here's what we do for the other frameworks;

runtime/Directory.Build.props

Lines 93 to 98 in d3da653

<NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious>
<!-- The minimum supported .NET version. -->
<NetCoreAppMinimum>net6.0</NetCoreAppMinimum>
<NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum>

I'll condition out the 6.0 and 7.0 so they aren't there for source build.

@ericstj
ericstj merged commit 32c3355 into dotnet:mainSep 20, 2023
@stephentoub
stephentoub deleted the fixdownleveltensor branch September 20, 2023 13:43
@stephentoub

stephentoub commented Sep 20, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks for the additional tweaks, @ericstj.

ViktorHofer
ViktorHofer reviewed Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

<PropertyGroup>
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>

@ViktorHoferViktorHoferOct 20, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?

.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.

Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15

System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.

@ericstjericstj mentioned this pull request Oct 24, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix downlevel build break in TensorPrimitives by stephentoub · Pull Request #92269 · dotnet/runtime · GitHub
Skip to content
Fix downlevel build break in TensorPrimitives - #92269
Merged
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged
Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Conversation
@stephentoub
@stephentoubstephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@stephentoub
stephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:stephentoub
Assignees:-
Labels:
area-System.Numerics
Milestone:-
@github-actions
github-actionsBot
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 19, 2023
 Merged

@stephentoubstephentoub
mentioned this pull request
Sep 19, 2023
 Merged

@steveisok
steveisok
self-requested a review
September 19, 2023 14:24
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Open

5 tasks

This was referenced Sep 19, 2023

Closed


Closed

@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
Hmm, this seems to have added prebuilts.
error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
I see, here's what we do for the other frameworks; 
runtime/Directory.Build.props

Lines 93 to 98
in
d3da653
 <NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious> 
<!-- The minimum supported .NET version. -->
 <NetCoreAppMinimum>net6.0</NetCoreAppMinimum> 
 <NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum> 
I'll condition out the 6.0 and 7.0 so they aren't there for source build.
@ericstj
ericstj
merged commit 32c3355
into
dotnet:mainSep 20, 2023
@stephentoub
stephentoub
deleted the

fixdownleveltensor

branch
September 20, 2023 13:43
@stephentoub
stephentoub
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
Thanks for the additional tweaks, @ericstj.
ViktorHofer
ViktorHofer
reviewed
Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

 <PropertyGroup>
 <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
 <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
@ViktorHoferViktorHoferOct 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
@ericstjericstj
mentioned this pull request
Oct 24, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix downlevel build break in TensorPrimitives by stephentoub · Pull Request #92269 · dotnet/runtime · GitHub
Skip to content
Fix downlevel build break in TensorPrimitives - #92269
Merged
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged
Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Conversation
@stephentoub
@stephentoubstephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@stephentoub
stephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:stephentoub
Assignees:-
Labels:
area-System.Numerics
Milestone:-
@github-actions
github-actionsBot
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 19, 2023
 Merged

@stephentoubstephentoub
mentioned this pull request
Sep 19, 2023
 Merged

@steveisok
steveisok
self-requested a review
September 19, 2023 14:24
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Open

5 tasks

This was referenced Sep 19, 2023

Closed


Closed

@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
Hmm, this seems to have added prebuilts.
error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
I see, here's what we do for the other frameworks; 
runtime/Directory.Build.props

Lines 93 to 98
in
d3da653
 <NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious> 
<!-- The minimum supported .NET version. -->
 <NetCoreAppMinimum>net6.0</NetCoreAppMinimum> 
 <NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum> 
I'll condition out the 6.0 and 7.0 so they aren't there for source build.
@ericstj
ericstj
merged commit 32c3355
into
dotnet:mainSep 20, 2023
@stephentoub
stephentoub
deleted the

fixdownleveltensor

branch
September 20, 2023 13:43
@stephentoub
stephentoub
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
Thanks for the additional tweaks, @ericstj.
ViktorHofer
ViktorHofer
reviewed
Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

 <PropertyGroup>
 <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
 <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
@ViktorHoferViktorHoferOct 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
@ericstjericstj
mentioned this pull request
Oct 24, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix downlevel build break in TensorPrimitives by stephentoub · Pull Request #92269 · dotnet/runtime · GitHub
Skip to content
Fix downlevel build break in TensorPrimitives - #92269
Merged
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged
Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Conversation
@stephentoub
@stephentoubstephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@stephentoub
stephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:stephentoub
Assignees:-
Labels:
area-System.Numerics
Milestone:-
@github-actions
github-actionsBot
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 19, 2023
 Merged

@stephentoubstephentoub
mentioned this pull request
Sep 19, 2023
 Merged

@steveisok
steveisok
self-requested a review
September 19, 2023 14:24
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Open

5 tasks

This was referenced Sep 19, 2023

Closed


Closed

@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
Hmm, this seems to have added prebuilts.
error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
I see, here's what we do for the other frameworks; 
runtime/Directory.Build.props

Lines 93 to 98
in
d3da653
 <NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious> 
<!-- The minimum supported .NET version. -->
 <NetCoreAppMinimum>net6.0</NetCoreAppMinimum> 
 <NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum> 
I'll condition out the 6.0 and 7.0 so they aren't there for source build.
@ericstj
ericstj
merged commit 32c3355
into
dotnet:mainSep 20, 2023
@stephentoub
stephentoub
deleted the

fixdownleveltensor

branch
September 20, 2023 13:43
@stephentoub
stephentoub
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
Thanks for the additional tweaks, @ericstj.
ViktorHofer
ViktorHofer
reviewed
Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

 <PropertyGroup>
 <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
 <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
@ViktorHoferViktorHoferOct 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
@ericstjericstj
mentioned this pull request
Oct 24, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix downlevel build break in TensorPrimitives by stephentoub · Pull Request #92269 · dotnet/runtime · GitHub
Skip to content
Fix downlevel build break in TensorPrimitives - #92269
Merged
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged
Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Conversation
@stephentoub
@stephentoubstephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@stephentoub
stephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:stephentoub
Assignees:-
Labels:
area-System.Numerics
Milestone:-
@github-actions
github-actionsBot
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 19, 2023
 Merged

@stephentoubstephentoub
mentioned this pull request
Sep 19, 2023
 Merged

@steveisok
steveisok
self-requested a review
September 19, 2023 14:24
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Open

5 tasks

This was referenced Sep 19, 2023

Closed


Closed

@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
Hmm, this seems to have added prebuilts.
error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
I see, here's what we do for the other frameworks; 
runtime/Directory.Build.props

Lines 93 to 98
in
d3da653
 <NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious> 
<!-- The minimum supported .NET version. -->
 <NetCoreAppMinimum>net6.0</NetCoreAppMinimum> 
 <NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum> 
I'll condition out the 6.0 and 7.0 so they aren't there for source build.
@ericstj
ericstj
merged commit 32c3355
into
dotnet:mainSep 20, 2023
@stephentoub
stephentoub
deleted the

fixdownleveltensor

branch
September 20, 2023 13:43
@stephentoub
stephentoub
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
Thanks for the additional tweaks, @ericstj.
ViktorHofer
ViktorHofer
reviewed
Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

 <PropertyGroup>
 <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
 <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
@ViktorHoferViktorHoferOct 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
@ericstjericstj
mentioned this pull request
Oct 24, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix downlevel build break in TensorPrimitives by stephentoub · Pull Request #92269 · dotnet/runtime · GitHub
Skip to content
Fix downlevel build break in TensorPrimitives - #92269
Merged
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged
Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Conversation
@stephentoub
@stephentoubstephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@stephentoub
stephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:stephentoub
Assignees:-
Labels:
area-System.Numerics
Milestone:-
@github-actions
github-actionsBot
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 19, 2023
 Merged

@stephentoubstephentoub
mentioned this pull request
Sep 19, 2023
 Merged

@steveisok
steveisok
self-requested a review
September 19, 2023 14:24
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Open

5 tasks

This was referenced Sep 19, 2023

Closed


Closed

@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
Hmm, this seems to have added prebuilts.
error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
I see, here's what we do for the other frameworks; 
runtime/Directory.Build.props

Lines 93 to 98
in
d3da653
 <NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious> 
<!-- The minimum supported .NET version. -->
 <NetCoreAppMinimum>net6.0</NetCoreAppMinimum> 
 <NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum> 
I'll condition out the 6.0 and 7.0 so they aren't there for source build.
@ericstj
ericstj
merged commit 32c3355
into
dotnet:mainSep 20, 2023
@stephentoub
stephentoub
deleted the

fixdownleveltensor

branch
September 20, 2023 13:43
@stephentoub
stephentoub
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
Thanks for the additional tweaks, @ericstj.
ViktorHofer
ViktorHofer
reviewed
Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

 <PropertyGroup>
 <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
 <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
@ViktorHoferViktorHoferOct 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
@ericstjericstj
mentioned this pull request
Oct 24, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Fix downlevel build break in TensorPrimitives by stephentoub · Pull Request #92269 · dotnet/runtime · GitHub
Skip to content
Fix downlevel build break in TensorPrimitives - #92269
Merged
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Sep 20, 2023
Merged
Fix downlevel build break in TensorPrimitives#92269
ericstj merged 4 commits into
dotnet:mainfrom 
stephentoub:fixdownleveltensor
Conversation
@stephentoub
@stephentoubstephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
@stephentoub
stephentoub
commented
Sep 19, 2023

Copy link


Copy Markdown

MemberAuthor
/backport to release/8.0
@ghost
ghost
commented
Sep 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:stephentoub
Assignees:-
Labels:
area-System.Numerics
Milestone:-
@github-actions
github-actionsBot
commented
Sep 19, 2023

Copy link


Copy Markdown

Contributor
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540
@github-actionsgithub-actionsBot
mentioned this pull request
Sep 19, 2023
 Merged

@stephentoubstephentoub
mentioned this pull request
Sep 19, 2023
 Merged

@steveisok
steveisok
self-requested a review
September 19, 2023 14:24
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 19, 2023

Open

5 tasks

This was referenced Sep 19, 2023

Closed


Closed

@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
Hmm, this seems to have added prebuilts.
error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?
@ericstj
ericstj
commented
Sep 19, 2023

Copy link


Copy Markdown

Member
I see, here's what we do for the other frameworks; 
runtime/Directory.Build.props

Lines 93 to 98
in
d3da653
 <NetCoreAppPreviousCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious> 
<!-- The minimum supported .NET version. -->
 <NetCoreAppMinimum>net6.0</NetCoreAppMinimum> 
 <NetCoreAppMinimumCondition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum> 
I'll condition out the 6.0 and 7.0 so they aren't there for source build.
@ericstj
ericstj
merged commit 32c3355
into
dotnet:mainSep 20, 2023
@stephentoub
stephentoub
deleted the

fixdownleveltensor

branch
September 20, 2023 13:43
@stephentoub
stephentoub
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
Thanks for the additional tweaks, @ericstj.
ViktorHofer
ViktorHofer
reviewed
Oct 20, 2023
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

 <PropertyGroup>
 <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
 <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
@ViktorHoferViktorHoferOct 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
@ericstjericstj
mentioned this pull request
Oct 24, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 19, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@steveisoksteveisoksteveisok approved these changes
@ericstjericstjericstj approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@michaelgsharpmichaelgsharpAwaiting requested review from michaelgsharp

Assignees

@stephentoubstephentoub

Labels

area-System.Numerics

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@ericstj@steveisok@ViktorHofer