[wasm][debugger] Support indexing of valuetype scheme by ilonatommy · Pull Request #92637 · dotnet/runtime

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy · 2023-09-26T11:54:54Z

Follow-up for #92630.

Changes in tests:

We will be using similar mechanisms for struct like we do for class - refactored TestEvaluate class into CommonCollections, ClassWithIndexers and StructWithIndexers to avoid code duplication. f was an ambiguous name, now we have c for class and s for struct.
We need a test case with both: indexers and inline arrays on the same object, so inline arrays from array tests got exposed and added to class/struct indexers.
Added a check for invoking methods on inline arrays - works fine.
Multidimensional indexing of value types.

Changes in logic:

Added checking LiteralExpressionSyntax arguments for compatibility - this revealed a small overlooking in CheckParameterCompatibility switch case - when the method expects ElementType.Boolean we cannot send string or char type as a param, it's not compatible.
Unified indexing resolving mechanism for objects and value types, now both use get_Items method (InvokeGetItemOnJObject).
Added receiving inline arrays on value types in the runtime, we used to read their sizes but then ignore reading the contents.

ghost · 2023-09-26T11:55:07Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up for #92630. After merging this PR we will be able to fix multidimensional indexing of valuetypes.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	`arch-wasm`, `area-Debugger-mono`
Milestone:	-

radical · 2023-10-05T05:20:13Z

+ throw new InvalidOperationException($"Type '{rootObject?["className"]?.Value<string>()}' cannot be indexed.");
+ var type = rootObject?["type"]?.Value<string>();
+
+ // ToDo: optimize the loop by choosing the right method at once without trying out them all


What is needed, or missing to do this?

Your idea here is the better approach.

Reason why it might be not possible:
If the parameter is required (as opposed to default) then we don't have information about its type. Even though we know what types were passed to the method, we cannot tell if this method will work well with them till we ask the runtime to CMD_VM_INVOKE_METHOD and it will throw / return a result.
Sometimes we even are not sure what type was passed to the method, see [wasm][debugger] Evaluate methods with short arguments #93057.
It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
void foo(Class1 c); void foo(Class2 c);
When we ask for GetMethodIdsByName for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get is ElementType.Class which does not tell us enough.

radical · 2023-10-05T05:26:10Z

-
- public double this[int key1, double key2] => key1 + key2;
- public string this[char key1, string key2, string key3] => $"{key1}-{key2}-{key3}";
+ public Dictionary<string, bool> indexedByStr = new Dictionary<string, bool>() { { "1", true }, { "111", false }, { "true", true} };


note: be careful with changing existing test code, as it can be easy to break tests even when we think we changed the line numbers correctly, especially if they end up affecting line numbers used for breakpoints for instance. Such a change might not break a test immediately, but it might now be stopping on the incorrect line opening a potential for the test not doing the intended checks.

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

ilonatommy added 4 commits September 26, 2023 10:29

Prepare test cases for signle dim.
6d988af

Fixed for constant indices.
8c99fd3

More tests + fix.
116200b

Unblock, working after rebuild.
ec15434

ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 26, 2023

ilonatommy self-assigned this Sep 26, 2023

ilonatommy requested review from radical and thaystg as code owners September 26, 2023 11:54

ilonatommy mentioned this pull request Sep 26, 2023
[wasm][debugger] Support multidimensional indexing of object scheme #92630
Merged

ilonatommy marked this pull request as draft September 26, 2023 12:45

ilonatommy added 2 commits September 27, 2023 07:25

Merge branch 'main' into index-a-struct
c5e8792

Initial inlined arrays cleanup.
4b3e6c1

ilonatommy marked this pull request as ready for review September 27, 2023 09:06

ilonatommy added 2 commits September 27, 2023 11:23

Lines are shifted again.
21841f7

@thaystg's fix for inline arrays
a8a2ee4

ilonatommy requested a review from marek-safar as a code owner September 28, 2023 06:34

ilonatommy added 2 commits September 28, 2023 06:55

Added test for method on inline array.
52dd1f8

Multi-dim works as well.
6781416

ilonatommy mentioned this pull request Sep 28, 2023
[release/8.0][wasm][debugger] Support multidimensional indexing of object scheme #92753
Merged

fix
c4595c4

thaystg approved these changes Sep 28, 2023
View reviewed changes

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

radical reviewed Sep 29, 2023
View reviewed changes

Comment threadsrc/mono/mono/component/debugger-agent.c Outdated

ilonatommy added 2 commits September 29, 2023 07:11

Tentative fix from feedback.
39ace3a

0th element is decoded before the loop.
98c6db3

ilonatommy requested a review from radical October 3, 2023 06:52

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated

radical reviewed Oct 5, 2023
View reviewed changes

Feedback part 1.
5d41e6a

ilonatommy requested a review from radical October 6, 2023 08:12

ilonatommy merged commit 121530f into dotnet:mainOct 12, 2023

ghost locked as resolved and limited conversation to collaborators Nov 11, 2023

Uh oh!

Conversation

ilonatommy commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ilonatommyOct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ilonatommy commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ilonatommyOct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ilonatommy commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ilonatommyOct 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

ilonatommy commented Sep 26, 2023•
edited
Loading

ilonatommyOct 5, 2023•
edited
Loading

ilonatommy commented Sep 26, 2023•
edited
Loading

ilonatommyOct 5, 2023•
edited
Loading

ilonatommy commented Sep 26, 2023•
edited
Loading

ilonatommyOct 5, 2023•
edited
Loading

ilonatommy commented Sep 26, 2023•
edited
Loading

ilonatommyOct 5, 2023•
edited
Loading