Avoid large table as part of TensorPrimitives remainder mask by stephentoub · Pull Request #92765 · dotnet/runtime

stephentoub · 2023-09-28T13:45:08Z

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

stephentoub · 2023-09-28T13:45:08Z

As discussed in #92672 (review)

ghost · 2023-09-28T13:45:29Z

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #92672 (review)

Author:	stephentoub
Assignees:	stephentoub
Labels:	`area-System.Numerics`
Milestone:	-

EgorBo · 2023-09-28T14:01:32Z

- Vector512.LoadUnsafe(
- ref Unsafe.As<uint, float>(ref MemoryMarshal.GetReference(RemainderUInt32Mask_16x16)),
- (uint)(validItems * 16)); // all sixteen floats in the row
+ Vector512.ConditionalSelect(


So for AVX512 it'd looked like
varmmask16 mask =(1<<n)-1;varmaskedAnd=Avx512.And(vec1,vec2,mask);
but we decided not to expose mask registers so if we expose these as a public API, we can intrinsify at leas the AVX512 version to be cheap 🙂 if it matters, presumably, performance of handling of trailing elements is not that much important esp for large data.

tannergooding · 2023-09-28T15:38:17Z

+ Vector128.ConditionalSelect(
+ Vector128.LessThan(Vector128.Create(3, 2, 1, 0), Vector128.Create(validItems)).AsSingle(),
+ Vector128<float>.AllBitsSet,
+ Vector128<float>.Zero);


This is going to be slower and result in a 128-bit constant (or more for other sizes) emitted at runtime per method this gets inlined into.
I think the table is ultimately better and we can get rid of it longer term using a proper JIT intrinsic.
If we really don't want the table, then achieving this with just a broadcast + comparison should be sufficient, since LessThan already produces a per-element mask of AllBitsSet (true) and Zero (false). You can use GreaterThanOrEqual if you need the mask inverted

Ok, I'll stick with the table. I was on the fence anyway. Just don't like its bulkiness.

That is, since TrailingMask wants to handle only trailing elements, it will skip processing the first n items that have already been processed.
So if 2 items remain, you have 3 < 2, 2 < 2, 1 < 2, 0 < 2 which produces Zero, Zero, AllBitsSet, AllBitsSet already

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Avoid large table as part of TensorPrimitives remainder mask
6f6b7ee

stephentoub requested review from EgorBo and tannergooding September 28, 2023 13:45

ghost assigned stephentoub Sep 28, 2023

ghost added the area-System.Numerics label Sep 28, 2023

EgorBo reviewed Sep 28, 2023
View reviewed changes

Comment thread...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs

EgorBo approved these changes Sep 28, 2023
View reviewed changes

EgorBo reviewed Sep 28, 2023
View reviewed changes

tannergooding reviewed Sep 28, 2023
View reviewed changes

stephentoub closed this Sep 28, 2023

ghost locked as resolved and limited conversation to collaborators Oct 28, 2023

stephentoub deleted the replaceremaindertable branch December 12, 2025 23:00

Uh oh!

Conversation

stephentoub commented Sep 28, 2023

Uh oh!

ghost commented Sep 28, 2023

Uh oh!

Uh oh!

EgorBoSep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tannergoodingSep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stephentoub commented Sep 28, 2023

Uh oh!

ghost commented Sep 28, 2023

Uh oh!

Uh oh!

EgorBoSep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tannergoodingSep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stephentoub commented Sep 28, 2023

Uh oh!

ghost commented Sep 28, 2023

Uh oh!

Uh oh!

EgorBoSep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tannergoodingSep 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

EgorBoSep 28, 2023•
edited
Loading

tannergoodingSep 28, 2023•
edited
Loading

EgorBoSep 28, 2023•
edited
Loading

tannergoodingSep 28, 2023•
edited
Loading

EgorBoSep 28, 2023•
edited
Loading

tannergoodingSep 28, 2023•
edited
Loading

EgorBoSep 28, 2023•
edited
Loading

tannergoodingSep 28, 2023•
edited
Loading

EgorBoSep 28, 2023•
edited
Loading