[release/8.0] Manually update release/8.0 arcade to latest - #92778

Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from
lewing:update-arcade-r8
Oct 6, 2023
Merged

[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from
lewing:update-arcade-r8

Conversation

@lewing

@lewinglewing commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.

cc @ViktorHofer@mmitche

@ghostghost assigned lewingSep 28, 2023
@ghost

ghost commented Sep 28, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.

cc @ViktorHofer

Author:lewing
Assignees:lewing
Labels:

area-Infrastructure-libraries

Milestone:-

@lewinglewing added area-codeflow for labeling automated codeflow and removed area-Infrastructure-libraries labels Sep 28, 2023
@lewinglewing mentioned this pull request Sep 28, 2023
Merged
@lewing

lewing commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

cc @ericstj

@lewing

lewing commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

@sbomer I assume this is fixed via dotnet/sdk#35767 ?

@build-analysisbuild-analysisBot mentioned this pull request Sep 28, 2023
Open
5 tasks
@sbomer

sbomer commented Sep 28, 2023

Copy link
Copy Markdown
Member

No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.

@sbomer

sbomer commented Sep 28, 2023

Copy link
Copy Markdown
Member

Now seeing errors like

##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost

ghost commented Sep 28, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.

cc @ViktorHofer@mmitche

Author:lewing
Assignees:lewing
Labels:

blocking-release, area-Host, area-codeflow

Milestone:-

@lewing

lewing commented Sep 28, 2023

Copy link
Copy Markdown
MemberAuthor

@elinor-fung are the host failures here rid related?

carlossanlop
carlossanlop reviewed Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
"sdk": {
"version": "8.0.100-preview.7.23376.3",
"version": "8.0.100-rc.1.23455.8",

@carlossanlopcarlossanlopSep 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.

@carlossanlopcarlossanlopSep 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.

@ericstjericstjSep 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.

@lewinglewingSep 28, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow

@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Sep 28, 2023
@ericstj

ericstj commented Sep 28, 2023

Copy link
Copy Markdown
Member

I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.

@agocke

agocke commented Sep 28, 2023

Copy link
Copy Markdown
Member

The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.

@elinor-fung

elinor-fung commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown
Member

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.

This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)

@ericstj

ericstj commented Sep 28, 2023

Copy link
Copy Markdown
Member

We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12

ViktorHofer
ViktorHofer reviewed Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props Outdated
@ViktorHofer

ViktorHofer commented Sep 29, 2023

Copy link
Copy Markdown
Member

The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.

AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.

@lewing

lewing commented Sep 29, 2023

Copy link
Copy Markdown
MemberAuthor

So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023
Closed
Closed
@lewinglewing mentioned this pull request Oct 4, 2023
Closed
@carlossanlop

carlossanlop commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?

@ViktorHofer

ViktorHofer commented Oct 4, 2023

Copy link
Copy Markdown
Member

Need to be addressed here. Those are real failures.

@build-analysisbuild-analysisBot mentioned this pull request Oct 5, 2023
Closed
3 tasks
@elinor-fung

elinor-fung commented Oct 5, 2023

Copy link
Copy Markdown
Member

_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63

Last commit ports over the below from main:

runtime/eng/Analyzers.targets

Lines 2 to 8 in 9dfbb61

<PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
'$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
'$(MSBuildProjectExtension)' == '.pkgproj' or
'$(UsingMicrosoftTraversalSdk)' == 'true'">
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>

carlossanlop
carlossanlop approved these changes Oct 6, 2023
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.

@carlossanlop
carlossanlop merged commit 0c2796c into dotnet:release/8.0Oct 6, 2023
@lewing

lewing commented Oct 6, 2023

Copy link
Copy Markdown
MemberAuthor

_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63

Last commit ports over the below from main:

runtime/eng/Analyzers.targets

Lines 2 to 8 in 9dfbb61

<PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
'$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
'$(MSBuildProjectExtension)' == '.pkgproj' or
'$(UsingMicrosoftTraversalSdk)' == 'true'">
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
<RunAnalyzers>false</RunAnalyzers>
</PropertyGroup>

Many thanks for resolving that.

@lewing
lewing deleted the update-arcade-r8 branch October 6, 2023 19:03
@ghostghost locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/8.0] Manually update release/8.0 arcade to latest - #92778
Merged
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Oct 6, 2023
Merged
[release/8.0] Manually update release/8.0 arcade to latest#92778
carlossanlop merged 8 commits into
dotnet:release/8.0from 
lewing:update-arcade-r8
Conversation
@lewing
@lewinglewing
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
@ghostghost
assigned lewingSep 28, 2023
@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer
Author:lewing
Assignees:lewing
Labels:
area-Infrastructure-libraries
Milestone:-
@lewinglewing
added

area-codeflow
for labeling automated codeflow
and removed

area-Infrastructure-libraries

labels
Sep 28, 2023
@lewinglewing
mentioned this pull request
Sep 28, 2023
 Merged

@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
cc @ericstj
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@sbomer I assume this is fixed via dotnet/sdk#35767 ?
@build-analysisbuild-analysisBot
mentioned this pull request
Sep 28, 2023

Open

5 tasks
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.
@sbomer
sbomer
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
Now seeing errors like
##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

@ghost
ghost
commented
Sep 28, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov

See info in area-owners.md if you want to be subscribed.
Issue Details
Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.
cc @ViktorHofer@mmitche
Author:lewing
Assignees:lewing
Labels:
blocking-release, area-Host, area-codeflow
Milestone:-
@lewing
lewing
commented
Sep 28, 2023

Copy link


Copy Markdown

MemberAuthor
@elinor-fung are the host failures here rid related?
carlossanlop
carlossanlop
reviewed
Sep 28, 2023
View reviewed changes
Comment threadglobal.json
{
 "sdk": {
 "version": "8.0.100-preview.7.23376.3",
 "version": "8.0.100-rc.1.23455.8",
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing Should this be rtm? Also the one below.
@carlossanlopcarlossanlopSep 28, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.
@ericstjericstjSep 28, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.
@lewinglewingSep 28, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Sep 28, 2023
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.
@agocke
agocke
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
@elinor-fung
elinor-fung
commented
Sep 28, 2023•

edited

Loading

Copy link


Copy Markdown

Member
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)
@ericstj
ericstj
commented
Sep 28, 2023

Copy link


Copy Markdown

Member
We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12
ViktorHofer
ViktorHofer
reviewed
Sep 29, 2023
View reviewed changes
Comment threadsrc/coreclr/tools/aot/Directory.Build.props
Outdated

@ViktorHofer
ViktorHofer
commented
Sep 29, 2023

Copy link


Copy Markdown

Member
The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.
AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.
@lewing
lewing
commented
Sep 29, 2023

Copy link


Copy Markdown

MemberAuthor
So installer rid resolution failures left (other than CI noise)?

This was referenced Sep 29, 2023

Closed


Closed

@lewinglewing
mentioned this pull request
Oct 4, 2023

Closed

@carlossanlop
carlossanlop
commented
Oct 4, 2023

Copy link


Copy Markdown

Contributor
@lewing@ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?
@ViktorHofer
ViktorHofer
commented
Oct 4, 2023

Copy link


Copy Markdown

Member
Need to be addressed here. Those are real failures.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 5, 2023

Closed

3 tasks
@elinor-fung
elinor-fung
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
carlossanlop
carlossanlop
approved these changes
Oct 6, 2023
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.
@carlossanlop
carlossanlop
merged commit 0c2796c
into
dotnet:release/8.0Oct 6, 2023
@lewing
lewing
commented
Oct 6, 2023

Copy link


Copy Markdown

MemberAuthor
_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63
Last commit ports over the below from main:
runtime/eng/Analyzers.targets

Lines 2 to 8
in
9dfbb61
 <PropertyGroupCondition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or
 '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or
 '$(MSBuildProjectExtension)' == '.pkgproj' or
 '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
<!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. -->
 <RunAnalyzers>false</RunAnalyzers> 
 </PropertyGroup> 
Many thanks for resolving that.
@lewing
lewing
deleted the

update-arcade-r8

branch
October 6, 2023 19:03
@ghostghost
locked as resolved and limited conversation to collaborators
Nov 6, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj left review comments
@mmitchemmitcheAwaiting requested review from mmitche
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@agockeagockeAwaiting requested review from agocke
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lewinglewing

Labels

area-codeflowfor labeling automated codeflowarea-Infrastructure-installerblocking-releaseServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@lewing@sbomer@ericstj@agocke@elinor-fung@ViktorHofer@carlossanlop@marek-safar