[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

[main] Update dependencies from 10 repositories - #92881

Merged
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8
Oct 18, 2023
Merged

[main] Update dependencies from 10 repositories#92881
radical merged 99 commits into
mainfrom
darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20231002.1
  • Date Produced: October 2, 2023 9:19:28 AM UTC
  • Commit: 3b91a0e7b0284777a4a95a89c76c03074050eb41
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20231008.5
  • Date Produced: October 9, 2023 2:45:13 AM UTC
  • Commit: 26a809a
  • Branch: refs/heads/main

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: d13ab629-d631-44c4-e9ce-08db9342e1a4
  • Build: 20231002.1
  • Date Produced: October 2, 2023 1:46:06 PM UTC
  • Commit: 05ffbf9df6c1dc621665ee1864874c4fe6de874c
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20231009.1
  • Date Produced: October 9, 2023 3:09:18 PM UTC
  • Commit: 0808f735fcb35276120b2e1221d6c3395d5543d6
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20231009.2
  • Date Produced: October 9, 2023 5:03:54 PM UTC
  • Commit: 45dd3a73dd5b64b010c4251303b3664bb30df029
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20231010.2
  • Date Produced: October 10, 2023 1:24:54 PM UTC
  • Commit: f3143488131043ba6788f72044b7b28bbcc462dd
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20231010.1
  • Date Produced: October 10, 2023 8:15:11 AM UTC
  • Commit: 3e1ba969512d5dc45f0885bab7338fe7f14d9689
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20231006.1
  • Date Produced: October 6, 2023 9:25:09 PM UTC
  • Commit: f00000635eed921fa55284c6d8f6c3d38797fa59
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20231005.1
  • Date Produced: October 5, 2023 9:08:24 PM UTC
  • Commit: 0672f8ce90040d589f29edc37d9e817d67cd4533
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20231009.3
  • Date Produced: October 9, 2023 8:00:56 PM UTC
  • Commit: 5ab31f65fe3cb8282eb8e19ca4844a2f6d5bf87b
  • Branch: refs/heads/dotnet/main

…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@ghostghost added the area-codeflow for labeling automated codeflow label Oct 2, 2023
…1002.2
Microsoft.DotNet.ILCompiler , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 9.0.0-alpha.1.23470.17 -> To Version 9.0.0-alpha.1.23502.2
…ence-packages build 20230925.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23472.1 -> To Version 9.0.0-alpha.1.23475.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets[main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packagesOct 2, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime-assets dotnet/runtime dotnet/source-build-reference-packages[main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assetsOct 3, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23502.8
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from dotnet/runtime dotnet/source-build-reference-packages dotnet/runtime-assets[main] Update dependencies from 6 repositoriesOct 3, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23503.9
@radicalradical closed this Oct 4, 2023
@radicalradical reopened this Oct 4, 2023
…004.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 6 repositories[main] Update dependencies from 7 repositoriesOct 5, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
…04.5
Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
From Version 9.0.0-alpha.1.23478.1 -> To Version 9.0.0-alpha.1.23504.5
Dependency coherency updates
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 16.0.5-alpha.1.23472.1 -> To Version 16.0.5-alpha.1.23477.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 7 repositories[main] Update dependencies from 8 repositoriesOct 5, 2023
…ild 20231002.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23475.1 -> To Version 8.0.0-alpha.0.23502.1
…02.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23476.1 -> To Version 0.11.4-alpha.23502.1
Microsoft.DotNet.ApiCompat.Task
From Version 9.0.100-alpha.1.23480.1 -> To Version 9.0.100-alpha.1.23504.15
…006.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Helix.Sdk
…31005.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 8.0.0-prerelease.23477.1 -> To Version 8.0.0-prerelease.23505.1
@dotnet-maestrodotnet-maestroBot changed the title [main] Update dependencies from 8 repositories[main] Update dependencies from 9 repositoriesOct 6, 2023
…ld 20231002.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23456.1 -> To Version 8.0.0-beta.23502.1
@lewing

Copy link
Copy Markdown
Member

The EAT/AOT wasm failures are because the signature of the method that was being explicitly preserved in AssertEqualityComparer.CompareTypedSets changed in dotnet/arcade@9856e56

@ViktorHofer

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available on CI.

CompareTypedSets was moved to CollectionTracker
@lewing

Copy link
Copy Markdown
Member

@lewing the other failure from above is a different thing, right? Looks like a newer SDK is required than what we have available

yeah still looking into the workload issue

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

Wasm library tests failing with:

info: Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/metadata/loader.c:1821, condition `<disabled>' not met
info: info: at yt (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:12923)
info: at Bl (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:177333)
info: at wasm_trace_logger (wasm://wasm/00b216fa:wasm-function[120]:0xa4e1)
info: at eglib_log_adapter (wasm://wasm/00b216fa:wasm-function[642]:0x3e079)
info: at monoeg_g_logv_nofree (wasm://wasm/00b216fa:wasm-function[564]:0x3c595)
info: at monoeg_assertion_message (wasm://wasm/00b216fa:wasm-function[568]:0x3c6b6)
info: at mono_assertion_message (wasm://wasm/00b216fa:wasm-function[570]:0x3c6f9)
info: at mono_assertion_message_disabled (wasm://wasm/00b216fa:wasm-function[569]:0x3c6cc)
info: at mono_method_signature_checked_slow (wasm://wasm/00b216fa:wasm-function[2165]:0xabd28)
info: at mono_method_signature_internal_slow (wasm://wasm/00b216fa:wasm-function[2172]:0xacbf1)
info: at mono_interp_get_imethod (wasm://wasm/00b216fa:wasm-function[220]:0xd234)
info: at get_virtual_method (wasm://wasm/00b216fa:wasm-function[244]:0x1c03e)
info: at get_virtual_method_fast (wasm://wasm/00b216fa:wasm-function[243]:0x1be00)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xfb6f)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_invoke_checked (wasm://wasm/00b216fa:wasm-function[2518]:0xbe72a)
info: at ves_icall_InternalInvoke_raw (wasm://wasm/00b216fa:wasm-function[1889]:0x9a907)
info: at do_icall (wasm://wasm/00b216fa:wasm-function[317]:0x1f173)
info: at do_icall_wrapper (wasm://wasm/00b216fa:wasm-function[246]:0x1c1b1)
info: at mono_interp_exec_method (wasm://wasm/00b216fa:wasm-function[239]:0xf2d8)
info: at interp_runtime_invoke (wasm://wasm/00b216fa:wasm-function[276]:0x1d53f)
info: at mono_jit_runtime_invoke (wasm://wasm/00b216fa:wasm-function[3198]:0xe8a1a)
info: at do_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2519]:0xbe79a)
info: at mono_runtime_try_invoke (wasm://wasm/00b216fa:wasm-function[2525]:0xbef65)
info: at mono_runtime_invoke (wasm://wasm/00b216fa:wasm-function[2549]:0xc15ac)
info: at mono_wasm_invoke_method_bound (wasm://wasm/00b216fa:wasm-function[129]:0xa6d7)
info: at Module._mono_wasm_invoke_method_bound [as mono_wasm_invoke_method_bound] (/root/helix/work/workitem/e/_framework/dotnet.native.js:8:122887)
info: at uo (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:63373)
info: at p.javaScriptExports.call_entry_point (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:208727)
info: at Object.Jc [as runMain] (/root/helix/work/workitem/e/_framework/dotnet.runtime.js:3:138601)
info: at run (/root/helix/work/workitem/e/test-main.js:401:50)
info: at async /root/helix/work/workitem/e/test-main.js:417:1
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

log.

cc @lambdageek@pavelsavara

Update: this is without trimming.

@radical

radical commented Oct 16, 2023

Copy link
Copy Markdown
Member

The Wasi/Wasm build tests failed with:

dotnet exec xunit.console.dll Wasi.Build.Tests.dll -xml /root/helix/work/workitem/uploads/xharness-output/testResults.xml -nocolor -verbose -notrait category=IgnoreForCI -notrait category=failing -notrait category=no-workload popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e /root/helix/work/workitem/e
You must install or update .NET to run this application.
App: /root/helix/work/workitem/e/xunit.console.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0-rc.1.23419.4' (x64)
.NET location: /root/helix/work/workitem/e/dotnet-latest/
The following frameworks were found:
8.0.0-rc.1.23414.4 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-rc.1.23419.4&arch=x64&rid=linux-x64&os=ubuntu.22.04

.. which is when running xunit itself. IIUC, the above means that xunit.console.dll was built with 8.0.0-rc.1.23419.4, but the sdk has an older version 8.0.0-rc.1.23414.4. Also, a rollforward setting for xunit.console.dll won't help this, AFAIU!
@akoeplinger should use a little older version of xunit, or wait for #93066?

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

MichalStrehovsky added a commit that referenced this pull request Oct 17, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
@pavelsavara

pavelsavara commented Oct 17, 2023

Copy link
Copy Markdown
Member
info: MONO_WASM: mono_exit failed TypeError: Cannot read properties of undefined (reading 'log')

this is my fault, I will fix it in #93472

but the assert at loader.c:1821 is something else.

@ViktorHofer

Copy link
Copy Markdown
Member

#93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

@radicalradical closed this Oct 17, 2023
@radicalradical reopened this Oct 17, 2023
@radical

Copy link
Copy Markdown
Member

dotnet/runtime/pull/93066 will update the sdk used for WBT, but that PR isn't ready yet.

@radical any idea when that change will be ready? That's AFAIK the remaining blocking issue.

I'm actively working on it, and hoping to have it fixed by tomorrow.

PR has merged. And I've triggered the build here to see what failures might be there now.

@ViktorHofer

Copy link
Copy Markdown
Member

WOHOO, nice. Thank you

@radical

Copy link
Copy Markdown
Member

The WBT failure is unrelated, and known - #93583 . And it should be fixed on latest main.

@radical

Copy link
Copy Markdown
Member

Wasm runtime tests job will timeout because of #93134 . No remaining wasm failures.

@radical
radical merged commit bf547c6 into mainOct 18, 2023
@radical
radical deleted the darc-main-dc54e365-ee0e-40dd-b4c9-65901d79d0e8 branch October 18, 2023 02:04
github-actionsBot pushed a commit that referenced this pull request Oct 19, 2023
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
carlossanlop pushed a commit that referenced this pull request Oct 20, 2023
)
* Fix analysis of interface methods on generic types
Fixes an issue observed in #92881. The dependency analysis within the compiler was incorrectly considering `Equals(object x, object y)` to be the implementation of `IEqualityComparer<T>.Equals(T, T)`. When we generate the interface dispatch table, we'd use the correct algorithm (that looks at uninstantiated types) and fail the compilation. The fix is to use the same algorithm during dependency analysis.
Looks like this has been broken ever since interface support was added to CoreRT: dotnet/corert#626.
* Stop building a test
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@ViktorHofer@ericstj@mthalman@jkoritzinsky@agocke@MichalStrehovsky@akoeplinger@lewing@radical@pavelsavara