Merge CoreCLR-based official builds legs into one leg per platform - #92901

Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged

Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom
jkoritzinsky:coreclr-single-build

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Oct 2, 2023

Copy link
Copy Markdown
Member

Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.

This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.

Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).

Note

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results

Important

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.

@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky added this to the 9.0.0 milestone Oct 2, 2023
@ghost

ghost commented Oct 2, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.

This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.

Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).

[!NOTE]
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results

[!IMPORTANT]
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.

Author:jkoritzinsky
Assignees:-
Labels:

area-Infrastructure

Milestone:9.0.0

ViktorHofer
ViktorHofer reviewed Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml Outdated
@jkoritzinsky

jkoritzinsky commented Oct 3, 2023

Copy link
Copy Markdown
MemberAuthor

DAC/DBI signing has been validated.

hoyosjs
hoyosjs reviewed Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml Outdated
Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml Outdated
@jkoritzinsky

jkoritzinsky commented Oct 4, 2023

Copy link
Copy Markdown
MemberAuthor

Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results

@jkoritzinsky

jkoritzinsky commented Oct 4, 2023

Copy link
Copy Markdown
MemberAuthor

Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results

@build-analysisbuild-analysisBot mentioned this pull request Oct 4, 2023
Closed
agocke
agocke approved these changes Oct 4, 2023
View reviewed changes

@agockeagocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction

@jkoritzinsky

jkoritzinsky commented Oct 4, 2023

Copy link
Copy Markdown
MemberAuthor

@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.

@jkoritzinsky
jkoritzinsky merged commit dc20390 into dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky deleted the coreclr-single-build branch October 4, 2023 22:43
@lewing

lewing commented Oct 5, 2023

Copy link
Copy Markdown
Member

Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Merge CoreCLR-based official builds legs into one leg per platform - #92901
Merged
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Oct 4, 2023
Merged
Merge CoreCLR-based official builds legs into one leg per platform#92901
jkoritzinsky merged 33 commits into
dotnet:mainfrom 
jkoritzinsky:coreclr-single-build
Conversation
@jkoritzinsky
@jkoritzinskyjkoritzinsky
commented
Oct 2, 2023

Copy link


Copy Markdown

Member
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
Note
Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
Important
Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
@jkoritzinsky
Move Mac and Linux CoreCLR builds to use single jobs for each all-up …
6c9698f
…build.
@jkoritzinsky
Fix binlog argument for OSX jobs.
120d210
@jkoritzinsky
Build clr.aot in the CoreCLR official build legs because we NativeAOT…
f504858
… crossgen.
@jkoritzinsky
Remove libraries legs that were only kept around for PGO
2646ffc
@jkoritzinsky
Fix indentation
71507b9
@jkoritzinsky
Fix indentation
eeae55c
@jkoritzinsky
Move variables from xplat-job up to xplat-setup and fix our condition…
58c9c3b
…s/names to use the right variable names.
@jkoritzinsky
Include more subsets in runtime-official.
4ab5925
@jkoritzinsky
Add missing arguments for linux packaging jobs (they are specified di…
8a444bd
…fferently in the installer build-linux-package step, will fix this later).
@jkoritzinsky
Update Alpine crossdac to output to linux_musl folder directly.
6361cf5
@jkoritzinsky
Build the Windows CrossDacs and pack the CrossDac package in a separa…
d276528
…te job from the Windows CoreCLR builds.
@jkoritzinsky
Pass variables to a higher scope template.
e3294cc
@jkoritzinsky
Fix dependencies
a4e16ad
@jkoritzinsky
Fix paths and don't copy the "sharedFramework" folder.
646c519
@jkoritzinsky
Refactor more names into variables.
d2d58c2
@jkoritzinsky
Don't try publishing the CrossDac for Windows. Remove the publishing …
49d5bbc
…for Linux as we don't use it any more
@jkoritzinsky
Remove old crossdac-pack.yml script as we do it differently now.
7c23c69
@jkoritzinsky
Condition macos signing on the same condition as previously.
d80d945
@jkoritzinsky
Fix typo for post build steps
fb40f73
@jkoritzinsky
Move Windows CoreCLR build legs to the single-job format and remove a…
8695585
…ll of the separate CoreCLR/Libraries/Installer jobs that existed to support these jobs as they were.
@jkoritzinsky
Don't try to build NativeAOT on win-x86. Add comment labels for each …
d41620f
…leg.
@jkoritzinsky
Convert AllConfigurations leg to the global build template.
386e5b2
@jkoritzinsky
Pass config for AllConfigurations leg
882a992
@jkoritzinskyjkoritzinsky
added this to the 9.0.0 milestone
Oct 2, 2023
@ghost
ghost
commented
Oct 2, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
Issue Details
Today, we split our official builds for CoreCLR-based artifacts into multiple separate jobs and we flow artifacts between the jobs. This adds significant complexity to our build and takes longer due to waiting for machine provisioning. Additionally, for the VMR, we need to build each platform in a single job as we need to be able to build all of the constituent repos in one job.
This PR merges each CoreCLR platform to build in a single job. It continues to keep one job for the CrossDac packages, as those need to be built cross-machine. Additionally, it preserves the Libraries AllConfigurations leg as a separate job as that is platform-agnostic.
Various platform legs for CoreCLR have additional pre and post build steps to account for signing (DAC/DBI and macOS tools), entitlements (macOS), uploading artifacts for the CrossDac job (Linux), and building installers in specific containers (Linux).
[!NOTE]

Official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2280331&view=results
[!IMPORTANT]

Due to branch restrictions on the service connection for the DAC/DBI signing, I was unable to validate it end-to-end.
Author:jkoritzinsky
Assignees:-
Labels:
area-Infrastructure
Milestone:9.0.0
ViktorHofer
ViktorHofer
reviewed
Oct 2, 2023
View reviewed changes
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 3, 2023

Copy link


Copy Markdown

MemberAuthor
DAC/DBI signing has been validated.
hoyosjs
hoyosjs
reviewed
Oct 4, 2023
View reviewed changes
Comment threadeng/pipelines/common/global-build-job.yml
Outdated

Comment threadsrc/coreclr/build-runtime.cmd
Comment threadeng/pipelines/runtime-official.yml
Comment threadeng/pipelines/runtime-official.yml
Outdated

@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9cebeb1 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283609&view=results
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
Official build link for 9e64389 (#92901): https://dev.azure.com/dnceng/internal/_build/results?buildId=2283677&view=results
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 4, 2023

Closed

agocke
agocke
approved these changes
Oct 4, 2023
View reviewed changes
@agockeagocke
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure I completely understand the crossdac interaction
@jkoritzinsky
jkoritzinsky
commented
Oct 4, 2023

Copy link


Copy Markdown

MemberAuthor
@hoyosjs can you take another look at the CrossDac work and approve/request changes? I think I've got it all right, but I really want to make sure I don't break that space.
@jkoritzinsky
jkoritzinsky
merged commit dc20390
into
dotnet:mainOct 4, 2023
@jkoritzinsky
jkoritzinsky
deleted the

coreclr-single-build

branch
October 4, 2023 22:43
@lewing
lewing
commented
Oct 5, 2023

Copy link


Copy Markdown

Member
Looks like this broke the official build by producing packages with -ci version

This was referenced Oct 5, 2023

Closed


Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Nov 4, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@agockeagockeagocke approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-Infrastructure

Projects


None yet


Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jkoritzinsky@lewing@agocke@ViktorHofer@hoyosjs