[mono][interp] Fix calling of static delegates with simd arguments by BrzVlad · Pull Request #92927 · dotnet/runtime

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad · 2023-10-03T10:59:35Z

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes#92925

Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Pass param_count directly

ghost · 2023-10-03T10:59:54Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

If we do a delegate call that translates to a static call, the delegate pointer that was passed needs to be skipped and we need to pass the actual arguments. However, the following arguments might not come immediately after the delegate pointer, if the first argument is simd aligned. Pass this information to MINT_CALL_DELEGATE so the correct offset of the arguments can be computed.

Fixes #92925

Author:	BrzVlad
Assignees:	BrzVlad
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

BrzVlad · 2023-10-04T13:21:35Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-10-04T13:22:01Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2023-10-04T14:05:32Z

This is actually a fix for a regression from .net7, so it is a backport candidate, which can be reproduced with a trivial sample:

using System;
using System.Runtime.Intrinsics;
public class Program {
public static void Method (Vector128<int> v)
{
Console.WriteLine (v);
}
public static void Main (string[] args)
{
Vector128<int> v = Vector128.Create (1, 2, 3, 4);
Action<Vector128<int>> act = Method;
act (v);
}
}

On .net8 rc1 this prints <1711280944, 32733, 1, 2>

BrzVlad · 2023-10-05T10:01:10Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

matouskozak · 2023-10-05T15:10:15Z

@matouskozak could you take a look at the extra platforms failures to see if everything looks ok ?

The failures seem unrelated.

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

BrzVlad added 3 commits October 3, 2023 13:49

[mono][interp] Small refactoring to make the code clearer
542bccc
Previous code was checking if we should have already pushed a dreg, to compute the correct position of the argument on the stack. Save pointer to args directly instead.

[mono][interp] Don't pass csignature to MINT_CALL_DELEGATE
f6baa58
Pass param_count directly

BrzVlad requested review from kotlarmilos and vargaz as code owners October 3, 2023 10:59

ghost assigned BrzVlad Oct 3, 2023

ghost added the area-Codegen-Interpreter-mono label Oct 3, 2023

vargaz approved these changes Oct 4, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 4, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

BrzVlad merged commit 49f9f7a into dotnet:mainOct 6, 2023

ghost locked as resolved and limited conversation to collaborators Nov 5, 2023

Uh oh!

Conversation

BrzVlad commented Oct 3, 2023

Uh oh!

ghost commented Oct 3, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!

azure-pipelinesBot commented Oct 4, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!

BrzVlad commented Oct 5, 2023

Uh oh!

matouskozak commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

BrzVlad commented Oct 3, 2023

Uh oh!

ghost commented Oct 3, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!

azure-pipelinesBot commented Oct 4, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!

BrzVlad commented Oct 5, 2023

Uh oh!

matouskozak commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

BrzVlad commented Oct 3, 2023

Uh oh!

ghost commented Oct 3, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!

azure-pipelinesBot commented Oct 4, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!

BrzVlad commented Oct 5, 2023

Uh oh!

matouskozak commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

BrzVlad commented Oct 3, 2023

Uh oh!

ghost commented Oct 3, 2023

Uh oh!

BrzVlad commented Oct 4, 2023

Uh oh!