[browser] streamline Task/Promise marshalling - #93010

Merged

pavelsavara merged 1 commit into

dotnet:mainfrom

pavelsavara:browser_one_direction_tcs

Oct 16, 2023

pavelsavara commented Oct 4, 2023•
edited
Loading

Member

This streamlines passing Promise/Task from two cross-boundary calls per promise argument to one.

none when it's passed
one when it's resolved, rejected or garbage collected

Changes

drop create_task_callback
simplify complete_task
simplify mono_wasm_marshal_promise and rename it to mono_wasm_resolve_or_reject_promise
introduced GCVHandle
- it's like GCHandle in that it keeps proxy of C# object alive while JS owns it.
- but it's allocated ahead of time on JS side
introduced JSVHandle
- it's like JSHandle in that it keeps proxy of JS object alive while C# owns it.
- but it's allocated ahead of time on C# side
improved GetTaskResultDynamic to handle void Task
introduced internal JSObject.DisposeLocal
- we can dispose both sides during resolve/reject call without extra dispose call

Interop "stack frame"

fixed IntPtr and handles to be I32 rather than U32
changed MarshalerType from I32 to U8 size
added MarshalerType.TaskResolved and MarshalerType.TaskRejected
- this allows us to pass better metadata in the same JSMarshalerArgument slot
moved JSMarshalerArgument.ElementType to different offset
- to not clash with handles
JSMarshalerArgument.ElementType now contains type of the promise's result
- this is necessary for marshaling with dynamic type
changed JSBindingType layout accordingly.
- In future this could also help with nested generic types.
bumped schema version to 2

Other

better type for WeakRefInternal<T>
interop unit test no longer ForceDisposeProxies in the middle of the program because it can't balance C# side of handles

pavelsavara added arch-wasm area-System.Runtime.InteropServices.JavaScript os-browser labels

pavelsavara added this to the 9.0.0 milestone

pavelsavara requested a review from maraf

October 4, 2023 14:55

pavelsavara self-assigned this

ghost commented Oct 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`, `os-browser`
Milestone:	9.0.0

pavelsavara commented Oct 4, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara commented Oct 4, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 4, 2023

[7.0][mono][arm64] futex-internal.h: No such file or directory - futex_wait_cancelable native crash in Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests #87444

Closed

[browser][MT] The WebSocket is not connected. #88084

Closed

pavelsavara requested a review from lambdageek

October 5, 2023 13:01

pavelsavara force-pushed the browser_one_direction_tcs branch from a8d0432 to e53d763Compare

October 5, 2023 13:01

pavelsavara commented Oct 5, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 5, 2023

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 5, 2023

[wasm][debugger] Debugger tests disabled #89409

Open

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Closed

[browser] Fragile WebSocket CI tests #90257

Closed

Test infra failure on iOS.Device.Aot.Test.WorkItemExecution CI leg #92792

Closed

pavelsavara force-pushed the browser_one_direction_tcs branch from e53d763 to 8614283Compare

October 9, 2023 17:58

pavelsavara changed the title ~~[browser] drop create_task_callback~~[browser] drop create_task_callback and mono_wasm_marshal_promise

This was referenced Oct 9, 2023

System.Text.Json failing some large file tests #59678

Closed

RequestDuration_EnrichmentHandler_Success_Recorded fails with System.Net.Quic.QuicException : Stream aborted by peer #93250

Closed

Tracking issue for CI build timeouts #76454

Closed

LibraryImportGenerator unit test segfault illegal memory access #89054

Closed

pavelsavara force-pushed the browser_one_direction_tcs branch from 4bd77bd to 68ae9f1Compare

October 11, 2023 11:53

pavelsavara changed the title ~~[browser] drop create_task_callback and mono_wasm_marshal_promise~~[browser] streamline Task/Promise marshalling

pavelsavara force-pushed the browser_one_direction_tcs branch from 68ae9f1 to d6b56c2Compare

October 11, 2023 12:45

pavelsavara commented Oct 12, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

maraf approved these changes

View reviewed changes

maraf left a comment

Member

Looks great! 👍

...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Outdated

src/mono/wasm/runtime/loader/logging.ts Outdated

build-analysisBot mentioned this pull request

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

pavelsavara commented Oct 12, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

build-analysisBot mentioned this pull request

MSBuild crashing in the build #92290

Open

pavelsavara requested a review from radical as a code owner

October 12, 2023 16:37

pavelsavara commented Oct 12, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara commented Oct 12, 2023

MemberAuthor

/azp run runtime-wasm

azure-pipelinesBot commented Oct 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

radical closed this

radical reopened this

radical commented Oct 12, 2023

Member

Re-triggered the builds to pick up the build fixes from #93412 .

radical commented Oct 12, 2023

Member

/azp run runtime-wasm

azure-pipelinesBot commented Oct 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

build-analysisBot mentioned this pull request

[6.0, 7.0, 8.0] Connection reset assert failure in System.Net.Sockets.Tests.SendReceive_SyncForceNonBlocking.TcpReceiveSendGetsCanceledByDispose #92423

Closed

rebase

a55eda9

pavelsavara force-pushed the browser_one_direction_tcs branch from 0706b84 to a55eda9Compare

October 13, 2023 13:18

pavelsavara commented Oct 13, 2023

MemberAuthor

I moved logging changes to #93472

pavelsavara merged commit 018efc5 into dotnet:main

pavelsavara deleted the browser_one_direction_tcs branch

October 16, 2023 10:10

radical mentioned this pull request

[wasm] WBT tests failing because of missing test app output #93583

Closed

radical commented Oct 17, 2023

Member

Please avoid merging on red when the failure is not known, and especially when the failures are in wasm jobs. If merging any way, then please add an explanation for that.
#93583

pavelsavara added a commit to pavelsavara/runtime that referenced this pull request

Revert " [browser] streamline Task/Promise marshalling (dotnet#93010)"

a44f7d2

This reverts commit 018efc5.

radical pushed a commit that referenced this pull request

[browser] Revert - streamline Task/Promise marshalling (#93010) (#93618)

de09811

This reverts commit 018efc5.

pavelsavara added a commit to pavelsavara/runtime that referenced this pull request

second attemptdotnet#93010

d652302

pavelsavara mentioned this pull request

[browser] streamline Task/Promise marshalling - atttemp 2 #93648

Merged

ghost locked as resolved and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmarea-System.Runtime.InteropServices.JavaScript os-browser