Fix Options Source Gen Trimming Issues by tarekgh · Pull Request #93088 · dotnet/runtime

tarekgh · 2023-10-05T22:56:06Z

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh · 2023-10-05T22:56:06Z

Fixes#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

ghost · 2023-10-05T22:56:22Z

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

#92327

This change addresses issues that arise when using the Options source generator in AOT builds. The trimming linker generates warnings due to the use of Validation attributes that rely on reflection. Additionally, the source generator emits code that uses ValidationContext, which has constructors annotated with the RequiredUnreferencedCode attribute, leading to linker warnings. It's important to note that the ValidationContext object created in this context is exclusively used within the Validator.TryValidateValue API call.

The solution consists of two parts:

We generate code to create the ValidationContext object and initialize the display and member names within it. This ensures the object's safe use because the reflection code path is not executed during this time. Consequently, we suppress the trimming linker warnings associated with this part.
For attributes such as MaxLengthAttribute, MinLengthAttribute, LengthAttribute, CompareAttribute, and RangeAttribute, which rely on reflection, we generate replacement attributes. These replacement attributes are strongly typed and entirely avoid the use of reflection.

These changes address the issues and improve the overall safety and performance of the code in AOT buildings.

Author:	tarekgh
Assignees:	tarekgh
Labels:	`area-Extensions-Options`
Milestone:	-

jeffhandley · 2023-10-05T23:55:51Z

It's kind of a bummer that we have to special-case the built-in validators to pull this off, but it makes sense for .NET 8. This will address the vast majority of instances where AOT would have been blocked for customers. If we hear feedback about ecosystem or customer attributes that need this same type of substitution treatment, we can explore approaches for a general-purpose substitution.

eiriktsarpalis

I'm guessing this will be backported to 8?

tarekgh · 2023-10-06T15:42:46Z

I'm guessing this will be backported to 8?

Yes.

jeffhandley

Looks good to me, save @eiriktsarpalis's question about the target framework handling.

tarekgh · 2023-10-08T23:26:21Z

/backport to release/8.0

github-actions · 2023-10-08T23:26:32Z

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6450606563

tarekgh requested a review from jeffhandley as a code owner October 5, 2023 22:56

ghost assigned tarekgh Oct 5, 2023

ghost added the area-Extensions-Options label Oct 5, 2023

tarekgh added this to the 8.0.0 milestone Oct 5, 2023

jeffhandley reviewed Oct 5, 2023
View reviewed changes

This was referenced Oct 6, 2023
Test infra failure on iOS.Device.Aot.Test.WorkItemExecution CI leg #92792
Closed
Build crashes in System.Runtime.Serialization.SerializationGuard #92007
Closed

eiriktsarpalis reviewed Oct 6, 2023
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Options/gen/CommonUtilities.cs Outdated

eiriktsarpalis reviewed Oct 6, 2023
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.Options/gen/Emitter.cs Outdated

eiriktsarpalis reviewed Oct 6, 2023
View reviewed changes

jeffhandley approved these changes Oct 6, 2023
View reviewed changes

build-analysisBot mentioned this pull request Oct 7, 2023
MSBuild crashing in the build #92290
Open

eiriktsarpalis approved these changes Oct 8, 2023
View reviewed changes

Fix Options Source Gen Trimming Issues
6eddd0d

tarekgh force-pushed the FixOptionsSourceGenTrimmingIssues branch from ff86e3f to 6eddd0dCompare October 8, 2023 21:45

tarekgh merged commit 26a809a into dotnet:mainOct 8, 2023

github-actionsBot mentioned this pull request Oct 8, 2023
[release/8.0] Fix Options Source Gen Trimming Issues #93193
Merged

RussKie mentioned this pull request Oct 12, 2023
[main] Update dependencies from dotnet/aspnetcore dotnet/extensions#4546
Merged

tarekgh mentioned this pull request Oct 12, 2023
Options source gen produce diagnostics with LengthAttribute when applied on properties of interface type #93403
Closed

RussKie mentioned this pull request Oct 12, 2023
[release/8.0] Update dependencies from dotnet/aspnetcore dotnet/extensions#4557
Merged

This was referenced Oct 12, 2023
Fix Options Source Gen with Length attributes applied on properties of Interface type #93426
Merged
[release/8.0] Fix Options Source Gen with Length attributes applied on properties of Interface type #93482
Merged

ghost locked as resolved and limited conversation to collaborators Nov 8, 2023